Skip to content

Commit e49ce3e

Browse files
committed
Be explicit with rails constants in the Engine
For some of these if you haven't loaded in the Rails gem, then the classes within RailsSemanticLogger cause the `defined?` check to pass and then the code to blow up. Be explicit in checking these are top level constants, not nested ones inside ourselves.
1 parent 47112b2 commit e49ce3e

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

lib/rails_semantic_logger/engine.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,14 @@ class Engine < ::Rails::Engine
131131
Bugsnag.configure { |config| config.logger = SemanticLogger[Bugsnag] } if defined?(Bugsnag)
132132

133133
# Rails Patches
134-
require("rails_semantic_logger/extensions/action_cable/tagged_logger_proxy") if defined?(ActionCable)
135-
require("rails_semantic_logger/extensions/action_controller/live") if defined?(ActionController::Live)
136-
require("rails_semantic_logger/extensions/action_dispatch/debug_exceptions") if defined?(ActionDispatch::DebugExceptions)
137-
if defined?(ActionView::StreamingTemplateRenderer::Body)
134+
require("rails_semantic_logger/extensions/action_cable/tagged_logger_proxy") if defined?(::ActionCable)
135+
require("rails_semantic_logger/extensions/action_controller/live") if defined?(::ActionController::Live)
136+
require("rails_semantic_logger/extensions/action_dispatch/debug_exceptions") if defined?(::ActionDispatch::DebugExceptions)
137+
if defined?(::ActionView::StreamingTemplateRenderer::Body)
138138
require("rails_semantic_logger/extensions/action_view/streaming_template_renderer")
139139
end
140140
require("rails_semantic_logger/extensions/active_job/logging") if defined?(::ActiveJob)
141-
require("rails_semantic_logger/extensions/active_model_serializers/logging") if defined?(ActiveModelSerializers)
141+
require("rails_semantic_logger/extensions/active_model_serializers/logging") if defined?(::ActiveModelSerializers)
142142

143143
if config.rails_semantic_logger.semantic
144144
# Active Job

0 commit comments

Comments
 (0)