remove search --detailed

Author: niechen

src/mcpm/commands/search.py

@@ -14,22 +14,20 @@
 
 @click.command()
 @click.argument("query", required=False)
-@click.option("--detailed", is_flag=True, help="Show detailed server information")
 @click.option("--table", is_flag=True, help="Display results in table format with descriptions")
 @click.help_option("-h", "--help")
-def search(query, detailed=False, table=False):
+def search(query, table=False):
     """Search available MCP servers.
 
     Searches the MCP registry for available servers. Without arguments, lists all available servers.
-    By default, only shows server names. Use --table for more details or --detailed for full information.
+    By default, only shows server names. Use --table for more details.
 
     Examples:
 
     \b
         mcpm search                  # List all available servers (names only)
         mcpm search github           # Search for github server
         mcpm search --table          # Show results in a table with descriptions
-        mcpm search --detailed       # Show detailed information
     """
     # Show appropriate search message
     search_criteria = []
@@ -53,9 +51,7 @@ def search(query, detailed=False, table=False):
             return
 
         # Show different views based on detail level
-        if detailed:
-            _display_detailed_results(servers)
-        elif table:
+        if table:
             print_servers_table(servers)
         else:
             print_simple_servers_list(servers)
@@ -65,88 +61,3 @@ def search(query, detailed=False, table=False):
 
     except Exception as e:
         print_error("Error searching for servers", str(e))
-
-
-def _display_detailed_results(servers):
-    """Display detailed information about each server"""
-    for i, server in enumerate(sorted(servers, key=lambda s: s["name"])):
-        # Get server data
-        name = server["name"]
-        display_name = server.get("display_name", name)
-        description = server.get("description", "No description")
-        license_info = server.get("license", "Unknown")
-
-        # Get author info
-        author_info = server.get("author", {})
-        author_name = author_info.get("name", "Unknown")
-        author_email = author_info.get("email", "")
-
-        # Build categories and tags
-        categories = server.get("categories", [])
-        tags = server.get("tags", [])
-
-        # Get installation details
-        installations = server.get("installations", {})
-        installation = server.get("installation", {})
-        package = installation.get("package", "")
-
-        # Print server header
-        console.print(f"[bold cyan]{display_name}[/] [dim]({name})[/]")
-        console.print(f"[italic]{description}[/]\n")
-
-        # Server information section
-        console.print("[bold yellow]Server Information:[/]")
-        if categories:
-            console.print(f"Categories: {', '.join(categories)}")
-        if tags:
-            console.print(f"Tags: {', '.join(tags)}")
-        if package:
-            console.print(f"Package: {package}")
-        console.print(f"Author: {author_name}" + (f" ({author_email})" if author_email else ""))
-        console.print(f"License: {license_info}")
-        console.print("")
-
-        # Installation details section
-        if installations:
-            console.print("[bold yellow]Installation Details:[/]")
-            for method in installations.values():
-                method_type = method.get("type", "unknown")
-                description = method.get("description", f"{method_type} installation")
-                recommended = " [green](recommended)[/]" if method.get("recommended", False) else ""
-
-                console.print(f"[cyan]{method_type}[/]: {description}{recommended}")
-
-                # Show command if available
-                if "command" in method:
-                    cmd = method["command"]
-                    args = method.get("args", [])
-                    cmd_str = f"{cmd} {' '.join(args)}" if args else cmd
-                    console.print(f"Command: [green]{cmd_str}[/]")
-
-                # Show dependencies if available
-                dependencies = method.get("dependencies", [])
-                if dependencies:
-                    console.print("Dependencies: " + ", ".join(dependencies))
-
-                # Show environment variables if available
-                env_vars = method.get("env", {})
-                if env_vars:
-                    console.print("Environment Variables:")
-                    for key, value in env_vars.items():
-                        console.print(f'  [bold blue]{key}[/] = [green]"{value}"[/]')
-                console.print("")
-
-        # If there are examples, show the first one
-        examples = server.get("examples", [])
-        if examples:
-            console.print("[bold yellow]Example:[/]")
-            first_example = examples[0]
-            if "title" in first_example:
-                console.print(f"[bold]{first_example['title']}[/]")
-            if "description" in first_example:
-                console.print(f"{first_example['description']}")
-            console.print("")
-
-        # Add a separator between servers (except for the last one)
-        if i < len(servers) - 1:
-            console.print("[dim]" + "-" * 50 + "[/]\n")

tests/test_search.py

@@ -86,8 +86,8 @@ def test_search_no_results(monkeypatch):
     mock_repo_manager.search_servers.assert_called_once_with("nonexistent")
 
 
-def test_search_detailed_view(monkeypatch):
-    """Test searching with detailed view"""
+def test_search_table_view(monkeypatch):
+    """Test searching with table view"""
     # Mock repository manager
     mock_repo_manager = Mock()
     mock_repo_manager.search_servers = Mock(
@@ -118,16 +118,17 @@ def test_search_detailed_view(monkeypatch):
     )
     monkeypatch.setattr("mcpm.commands.search.repo_manager", mock_repo_manager)
 
-    # Run the command with detailed flag
+    # Run the command with table flag
     runner = CliRunner()
-    result = runner.invoke(search, ["--detailed"])
+    result = runner.invoke(search, ["--table"])
 
     assert result.exit_code == 0
     assert "Test Server" in result.output
     assert "A test server" in result.output
-    assert "Server Information:" in result.output
-    assert "Installation Details:" in result.output
-    assert "Example:" in result.output
+    # Table output won't have these detailed sections that were in the detailed view
+    # assert "Server Information:" in result.output
+    # assert "Installation Details:" in result.output
+    # assert "Example:" in result.output
     assert "Found 1 server(s) matching search criteria" in result.output
     mock_repo_manager.search_servers.assert_called_once_with(None)
 
@@ -149,8 +150,8 @@ def test_search_error_handling(monkeypatch):
     mock_repo_manager.search_servers.assert_called_once_with(None)
 
 
-def test_search_with_query_and_detailed(monkeypatch):
-    """Test searching with both a query and detailed view"""
+def test_search_with_query_and_table(monkeypatch):
+    """Test searching with both a query and table view"""
     # Mock repository manager
     mock_repo_manager = Mock()
     mock_repo_manager.search_servers = Mock(
@@ -181,15 +182,13 @@ def test_search_with_query_and_detailed(monkeypatch):
     )
     monkeypatch.setattr("mcpm.commands.search.repo_manager", mock_repo_manager)
 
-    # Run the command with both query and detailed flag
+    # Run the command with both query and table flag
     runner = CliRunner()
-    result = runner.invoke(search, ["test", "--detailed"])
+    result = runner.invoke(search, ["test", "--table"])
 
     assert result.exit_code == 0
     assert "Searching for MCP servers matching 'test'" in result.output
     assert "Test Server" in result.output
-    assert "Server Information:" in result.output
-    assert "Installation Details:" in result.output
-    assert "Example:" in result.output
+    assert "A test server" in result.output
     assert "Found 1 server(s) matching search criteria" in result.output
     mock_repo_manager.search_servers.assert_called_once_with("test")