Refactor client registry

Author: niechen

src/mcpm/cli.py

@@ -73,8 +73,8 @@ def main(ctx, help_flag):
         console.print(panel)
 
         # Get information about installed clients
-        from mcpm.utils.client_detector import detect_installed_clients
-        installed_clients = detect_installed_clients()
+        from mcpm.utils.client_registry import ClientRegistry
+        installed_clients = ClientRegistry.detect_installed_clients()
 
         # Display active client information and main help
         client_status = "[green]✓[/]" if installed_clients.get(active_client, False) else "[yellow]⚠[/]"

src/mcpm/clients/__init__.py

@@ -2,7 +2,14 @@
 Client integrations for MCPM - manages client-specific configurations
 """
 
+from mcpm.clients.base import BaseClientManager
 from mcpm.clients.claude_desktop import ClaudeDesktopManager
 from mcpm.clients.windsurf import WindsurfManager
+from mcpm.clients.cursor import CursorManager
 
-__all__ = ['ClaudeDesktopManager', 'WindsurfManager']
+__all__ = [
+    'BaseClientManager',
+    'ClaudeDesktopManager', 
+    'WindsurfManager',
+    'CursorManager'
+]

src/mcpm/clients/base.py

@@ -14,6 +14,11 @@
 class BaseClientManager:
     """Base class for all client managers providing a common interface"""
 
+    # Client information properties
+    client_key = ""         # Client identifier (e.g., "claude-desktop")
+    display_name = ""      # Human-readable name (e.g., "Claude Desktop")
+    download_url = ""      # URL to download the client
+    
     def __init__(self, config_path: str):
         """Initialize with a configuration path"""
         self.config_path = config_path
@@ -192,15 +197,27 @@ def remove_server(self, server_name: str) -> bool:
         # To be implemented by subclasses
         raise NotImplementedError("Subclasses must implement remove_server")
 
+    def get_client_info(self) -> Dict[str, str]:
+        """Get information about this client
+        
+        Returns:
+            Dict: Information about the client including display name, download URL, and config path
+        """
+        return {
+            "name": self.display_name,
+            "download_url": self.download_url,
+            "config_file": self.config_path
+        }
+    
     def is_client_installed(self) -> bool:
         """Check if this client is installed
         
         Returns:
             bool: True if client is installed, False otherwise
         """
-        # Default implementation - can be overridden by subclasses
-        client_dir = os.path.dirname(self.config_path)
-        return os.path.isdir(client_dir)
+        # Default implementation checks if the config directory exists
+        # Can be overridden by subclasses
+        return os.path.isdir(os.path.dirname(self.config_path))
 
     def disable_server(self, server_name: str) -> bool:
         """Temporarily disable (stash) a server without removing its configuration

src/mcpm/clients/claude_desktop.py

@@ -24,6 +24,11 @@
 class ClaudeDesktopManager(BaseClientManager):
     """Manages Claude Desktop MCP server configurations"""
 
+    # Client information
+    client_key = "claude-desktop"
+    display_name = "Claude Desktop"
+    download_url = "https://claude.ai/download"
+    
     def __init__(self, config_path: str = CLAUDE_CONFIG_PATH):
         super().__init__(config_path)
 

src/mcpm/clients/cursor.py

@@ -24,6 +24,11 @@
 class CursorManager(BaseClientManager):
     """Manages Cursor MCP server configurations"""
 
+    # Client information
+    client_key = "cursor"
+    display_name = "Cursor"
+    download_url = "https://cursor.sh/download"
+    
     def __init__(self, config_path: str = CURSOR_CONFIG_PATH):
         super().__init__(config_path)
 

src/mcpm/clients/windsurf.py

@@ -24,6 +24,11 @@
 class WindsurfManager(BaseClientManager):
     """Manages Windsurf MCP server configurations"""
 
+    # Client information
+    client_key = "windsurf"
+    display_name = "Windsurf"
+    download_url = "https://codeium.com/windsurf/download"
+    
     def __init__(self, config_path: str = WINDSURF_CONFIG_PATH):
         super().__init__(config_path)
 

src/mcpm/commands/add.py

@@ -12,7 +12,7 @@
 
 from mcpm.utils.repository import RepositoryManager
 from mcpm.utils.server_config import ServerConfig
-from mcpm.utils.client_manager import get_active_client, get_active_client_manager, get_active_client_info
+from mcpm.utils.client_registry import ClientRegistry
 
 console = Console()
 repo_manager = RepositoryManager()
@@ -28,15 +28,15 @@ def add(server_name, force=False):
         mcpm add everything --force
     """
     # Get the active client info
-    client = get_active_client()
+    client = ClientRegistry.get_active_client()
     if not client:
         console.print("[bold red]Error:[/] No active client found.")
         console.print("Please set an active client with 'mcpm client set <client>'.")
         return
     console.print(f"[yellow]Using active client: {client}[/]")
 
     # Get client manager
-    client_manager = get_active_client_manager()
+    client_manager = ClientRegistry.get_active_client_manager()
     if client_manager is None:
         console.print(f"[bold red]Error:[/] Unsupported client '{client}'.")
         return
@@ -70,7 +70,8 @@ def add(server_name, force=False):
         console.print(f"[dim]Author: {author_name} {author_url}[/]")
 
     # Get client display name from the utility
-    _, client_display_name, _ = get_active_client_info()
+    client_info = ClientRegistry.get_client_info(client)
+    client_display_name = client_info.get("name", client)
 
     # Confirm addition
     if not force and not Confirm.ask(f"Add this server to {client_display_name}?"):

src/mcpm/commands/client.py

@@ -8,6 +8,7 @@
 from rich.panel import Panel
 
 from mcpm.utils.config import ConfigManager
+from mcpm.utils.client_registry import ClientRegistry
 
 console = Console()
 config_manager = ConfigManager()
@@ -27,15 +28,15 @@ def client(client_name, list):
         mcpm client claude-desktop  # Set Claude Desktop as the active client
     """
     # Get the list of supported clients
-    supported_clients = config_manager.get_supported_clients()
+    supported_clients = ClientRegistry.get_supported_clients()
 
     # List all supported clients if requested
     if list:
         table = Table(title="Supported MCP Clients")
         table.add_column("Client Name", style="cyan")
         table.add_column("Status", style="green")
 
-        active_client = config_manager.get_active_client()
+        active_client = ClientRegistry.get_active_client()
 
         for client in sorted(supported_clients):
             status = "[bold green]ACTIVE[/]" if client == active_client else ""
@@ -46,7 +47,7 @@ def client(client_name, list):
 
     # If no client name specified, show the current active client
     if not client_name:
-        active_client = config_manager.get_active_client()
+        active_client = ClientRegistry.get_active_client()
         console.print(f"Current active client: [bold cyan]{active_client}[/]")
 
         # Display some helpful information about setting clients
@@ -67,12 +68,12 @@ def client(client_name, list):
         return
 
     # Set the active client
-    if client_name == config_manager.get_active_client():
+    if client_name == ClientRegistry.get_active_client():
         console.print(f"[bold yellow]Note:[/] {client_name} is already the active client")
         return
 
     # Attempt to set the active client
-    success = config_manager.set_active_client(client_name)
+    success = ClientRegistry.set_active_client(client_name)
     if success:
         console.print(f"[bold green]Success:[/] Active client set to {client_name}")
 

src/mcpm/commands/edit.py

@@ -10,7 +10,7 @@
 from rich.panel import Panel
 from rich.prompt import Confirm
 
-from mcpm.utils.client_manager import get_active_client_info
+from mcpm.utils.client_registry import ClientRegistry
 
 console = Console()
 
@@ -29,7 +29,10 @@ def edit(edit, create):
         mcpm edit --create  # Create a basic config file if it doesn't exist
     """
     # Get the active client manager and related information
-    client_manager, client_name, install_url = get_active_client_info()
+    client_manager = ClientRegistry.get_active_client_manager()
+    client = ClientRegistry.get_active_client()
+    client_info = ClientRegistry.get_client_info(client)
+    client_name = client_info.get("name", client)
 
     # Check if client is supported
     if client_manager is None:

src/mcpm/commands/list.py

@@ -7,7 +7,7 @@
 from rich.table import Table
 from rich.markup import escape
 
-from mcpm.utils.client_manager import get_active_client_info
+from mcpm.utils.client_registry import ClientRegistry
 
 console = Console()
 
@@ -48,7 +48,10 @@ def list(available, outdated):
         console.print("[bold yellow]Checking for outdated MCP servers...[/]")
 
         # Get the active client manager and information
-        client_manager, client_name, _ = get_active_client_info()
+        client_manager = ClientRegistry.get_active_client_manager()
+        client = ClientRegistry.get_active_client()
+        client_info = ClientRegistry.get_client_info(client)
+        client_name = client_info.get("name", client)
 
         # Check if client is supported
         if client_manager is None:
@@ -105,7 +108,10 @@ def list(available, outdated):
 
     else:
         # Get the active client manager and information
-        client_manager, client_name, _ = get_active_client_info()
+        client_manager = ClientRegistry.get_active_client_manager()
+        client = ClientRegistry.get_active_client()
+        client_info = ClientRegistry.get_client_info(client)
+        client_name = client_info.get("name", client)
 
         # Check if client is supported
         if client_manager is None: