Fix v1 to v2 migration to only occur after user confirmation

Previously, ProfileConfigManager would automatically migrate v1 profiles.json
files on initialization, which happened before users confirmed they wanted
to migrate. This caused profiles to be migrated prematurely.

Changes:
- Removed automatic migration from ProfileConfigManager.__init__
- Removed unused _migrate_legacy_profiles methods from ProfileConfigManager
- Added create_profile() method to ProfileConfigManager for V1ToV2Migrator
- Updated V1ToV2Migrator to also remove profiles.json after migration
- Updated test to reflect that ProfileConfigManager no longer auto-migrates
- Fixed ASCII art logo spacing in cli.py and rich_click_config.py

Now profile migration only happens after user explicitly chooses to migrate
via the V1ToV2Migrator prompt.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: niechen

src/mcpm/cli.py

@@ -49,12 +49,12 @@ def print_logo():
 
     # Clean ASCII art design - simplified with light shades
     logo_text = """
- ███░   ███░  ██████░ ██████░ ███░   ███░
- ████░ ████░ ██░░░░░░ ██░░░██░████░ ████░
- ██░████░██░ ██░      ██████░░██░████░██░
- ██░░██░░██░ ██░      ██░░░░░ ██░░██░░██░
- ██░ ░░░ ██░ ░██████░ ██░     ██░ ░░░ ██░
- ░░░     ░░░  ░░░░░░░ ░░░     ░░░     ░░░
+ ███░   ███░  ██████░ ██████░  ███░   ███░
+ ████░ ████░ ██░░░░░░ ██░░░██░ ████░ ████░
+ ██░████░██░ ██░      ██████░░ ██░████░██░
+ ██░░██░░██░ ██░      ██░░░░░  ██░░██░░██░
+ ██░ ░░░ ██░ ░██████░ ██░      ██░ ░░░ ██░
+ ░░░     ░░░  ░░░░░░░ ░░░      ░░░     ░░░
 
 """
 

src/mcpm/migration/v1_migrator.py

@@ -430,14 +430,22 @@ def _cleanup_main_config(self):
             except Exception as e:
                 console.print(f"  ⚠️  Failed to remove config.json: {e}")
 
+        # Remove v1 profiles.json file after migration
+        if self.detector.profiles_file.exists():
+            try:
+                self.detector.profiles_file.unlink()
+                console.print("  🧹 Removed v1 profiles.json file")
+            except Exception as e:
+                console.print(f"  ⚠️  Failed to remove profiles.json: {e}")
+
     def _show_migration_summary(self, migrated_profiles: Dict[str, int]):
         """Show migration completion summary"""
         summary_panel = Panel(
             "[bold green]✅ Migration Completed Successfully![/]\n\n"
             f"📊 [bold]Migration Results[/]\n"
             f"   • {len(migrated_profiles)} profiles migrated\n"
             f"   • {sum(migrated_profiles.values())} servers migrated\n"
-            f"   • v1 config.json removed\n"
+            f"   • v1 config.json and profiles.json removed\n"
             f"   • v1 configs backed up in [cyan]~/.config/mcpm/backups/[/]\n\n"
             f"🎯 [bold]What's Different Now[/]\n"
             f"   • All servers are in global configuration\n"

src/mcpm/profile/profile_config.py

@@ -1,10 +1,7 @@
-import json
 import logging
 import os
 from typing import Dict, List, Optional
 
-from pydantic import TypeAdapter
-
 from mcpm.core.schema import ProfileMetadata, ServerConfig
 from mcpm.global_config import GlobalConfigManager
 
@@ -30,47 +27,8 @@ def __init__(
         self.profile_path = os.path.expanduser(profile_path)
         self.global_config = global_config_manager or GlobalConfigManager()
 
-        # For backward compatibility, attempt migration if old profiles.json exists
-        self._migrate_legacy_profiles_if_needed()
-
-    def _migrate_legacy_profiles_if_needed(self) -> None:
-        """Migrate old profiles.json to virtual profile system if it exists."""
-        if os.path.exists(self.profile_path):
-            logger.info(f"Migrating legacy profiles from {self.profile_path}")
-            try:
-                self._migrate_legacy_profiles()
-                # Backup the old file
-                backup_path = self.profile_path + ".backup"
-                os.rename(self.profile_path, backup_path)
-                logger.info(f"Legacy profiles migrated successfully. Backup saved to {backup_path}")
-            except Exception as e:
-                logger.error(f"Failed to migrate legacy profiles: {e}")
-
-    def _migrate_legacy_profiles(self) -> None:
-        """Migrate profiles from old profiles.json format to virtual profiles."""
-        try:
-            with open(self.profile_path, "r", encoding="utf-8") as f:
-                legacy_profiles = json.load(f) or {}
-        except (json.JSONDecodeError, FileNotFoundError):
-            return
-
-        for profile_name, configs in legacy_profiles.items():
-            # Create profile metadata
-            self.global_config.create_profile_metadata(profile_name)
-
-            # Add servers to global config and tag them with profile
-            for config_data in configs:
-                try:
-                    server_config = TypeAdapter(ServerConfig).validate_python(config_data)
-
-                    # Add server to global config if not exists
-                    if not self.global_config.server_exists(server_config.name):
-                        self.global_config.add_server(server_config)
-
-                    # Tag server with profile
-                    self.global_config.add_profile_tag_to_server(server_config.name, profile_name)
-                except Exception as e:
-                    logger.error(f"Failed to migrate server {config_data.get('name', 'unknown')}: {e}")
+        # Note: Legacy profile migration is now handled by V1ToV2Migrator
+        # to ensure it only happens after user confirms migration
 
     def _load_profiles(self) -> Dict[str, List[ServerConfig]]:
         """Legacy method - now returns virtual profiles from global config."""
@@ -225,6 +183,18 @@ def get_complete_profile(self, profile_name: str) -> Optional[Dict]:
         """Get complete profile info including metadata and servers."""
         return self.global_config.get_complete_profile(profile_name)
 
+    def create_profile(self, profile_name: str, description: str = "") -> bool:
+        """Create a new profile with optional description."""
+        # Check if profile already exists
+        if self.global_config.get_profile_metadata(profile_name) or self.global_config.virtual_profile_exists(
+            profile_name
+        ):
+            return False
+
+        # Create profile metadata with description
+        metadata = ProfileMetadata(name=profile_name, description=description)
+        return self.global_config.update_profile_metadata(metadata)
+
     def add_server_to_profile(self, profile_name: str, server_name: str) -> bool:
         """Add an existing global server to a profile by tagging it."""
         # Ensure profile exists

src/mcpm/utils/rich_click_config.py

@@ -20,12 +20,12 @@
 
 # ASCII art logo - simplified with light shades
 ASCII_ART = """
- ███░   ███░  ██████░ ██████░ ███░   ███░
- ████░ ████░ ██░░░░░░ ██░░░██░████░ ████░
- ██░████░██░ ██░      ██████░░██░████░██░
- ██░░██░░██░ ██░      ██░░░░░ ██░░██░░██░
- ██░ ░░░ ██░ ░██████░ ██░     ██░ ░░░ ██░
- ░░░     ░░░  ░░░░░░░ ░░░     ░░░     ░░░
+ ███░   ███░  ██████░ ██████░  ███░   ███░
+ ████░ ████░ ██░░░░░░ ██░░░██░ ████░ ████░
+ ██░████░██░ ██░      ██████░░ ██░████░██░
+ ██░░██░░██░ ██░      ██░░░░░  ██░░██░░██░
+ ██░ ░░░ ██░ ░██████░ ██░      ██░ ░░░ ██░
+ ░░░     ░░░  ░░░░░░░ ░░░      ░░░     ░░░
 
 """
 

tests/test_profile.py

@@ -71,22 +71,19 @@ def test_profile_manager_init_custom_path(profile_manager_clean, temp_dirs):
 
 
 def test_legacy_migration(profile_manager_with_legacy, temp_dirs):
-    """Test that legacy profiles.json is migrated to virtual profiles"""
+    """Test that legacy profiles.json is NOT automatically migrated"""
     temp_dir, servers_path, metadata_path, legacy_path = temp_dirs
     manager = profile_manager_with_legacy
 
-    # Check that legacy file was moved to backup
-    assert os.path.exists(legacy_path + ".backup")
+    # Check that legacy file still exists (no auto-migration)
+    assert os.path.exists(legacy_path)
+    assert not os.path.exists(legacy_path + ".backup")
 
-    # Check that profiles were migrated
+    # Check that profiles were NOT migrated automatically
     profiles = manager.list_profiles()
-    assert "test_profile" in profiles
-    assert "empty_profile" in profiles
+    assert len(profiles) == 0  # No profiles should exist yet
 
-    # Check that server was migrated to global config
-    test_profile_servers = manager.get_profile("test_profile")
-    assert len(test_profile_servers) == 1
-    assert test_profile_servers[0].name == "test-server"
+    # Legacy migration is now handled by V1ToV2Migrator, not ProfileConfigManager
 
 
 def test_new_profile(profile_manager_clean):