Skip to content

Commit 654872d

Browse files
xingyaowwJoJoJoJoJoJoJoniechen
authored
feat(router): Improve function naming in router
Only prefix server id to elements in mcp server if there's a conflict in name. * allow profile and client id to be unset for router * support pass in profile path for router * make sure tool name is unique across servers * tweak message * add api to get the app directly * handle life span * fix type * fix router * chore: provide a mode to control only rename tool when there is conflict * test: fix tests * Update semantic-check.yml * Update semantic-check.yml * Update semantic-check.yml * Update semantic-check.yml * Update semantic-check.yml * Update semantic-check.yml * chore: fix comment --------- Co-authored-by: Jonathan Wang <[email protected]> Co-authored-by: cnie <[email protected]>
1 parent 903c89e commit 654872d

File tree

6 files changed

+223
-137
lines changed

6 files changed

+223
-137
lines changed
Lines changed: 17 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
name: Semantic Version Check
22

33
on:
4-
pull_request:
4+
pull_request_target:
55
types: [opened, synchronize, reopened]
66

7-
permissions:
8-
contents: read
9-
pull-requests: write
10-
issues: write
11-
127
jobs:
138
semver-check:
149
name: Validate Semantic Version
1510
runs-on: ubuntu-latest
11+
permissions:
12+
contents: write
13+
pull-requests: write
14+
issues: write
1615

1716
steps:
1817
- name: Checkout
1918
uses: actions/checkout@v4
2019
with:
20+
ref: ${{ github.event.pull_request.head.sha }}
2121
fetch-depth: 0
2222
persist-credentials: false
2323

@@ -41,38 +41,24 @@ jobs:
4141
id: semantic
4242
with:
4343
dry_run: true
44-
ci: false
44+
ci: true
4545
extra_plugins: |
4646
@semantic-release/commit-analyzer
4747
@semantic-release/release-notes-generator
48-
branches: |
49-
[
50-
"${GITHUB_HEAD_REF}"
51-
]
5248
env:
5349
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5450

5551
- name: Comment PR
56-
if: always()
57-
uses: actions/github-script@v7
52+
uses: thollander/actions-comment-pull-request@v2
5853
with:
59-
script: |
60-
let comment = '## Semantic Version Check\n\n';
54+
message: |
55+
## Semantic Version Check
6156
62-
if ('${{ steps.semantic.outputs.new_release_version }}') {
63-
comment += `✅ Valid semantic version changes detected!\n\n`;
64-
comment += `Next version will be: **${{ steps.semantic.outputs.new_release_version }}**\n`;
65-
} else {
66-
comment += `⚠️ No semantic version changes detected.\n\n`;
67-
comment += 'Please ensure your commits follow the [Conventional Commits](https://www.conventionalcommits.org/) format:\n\n';
68-
comment += '- `feat: new feature` (triggers MINOR version bump)\n';
69-
comment += '- `fix: bug fix` (triggers PATCH version bump)\n';
70-
comment += '- `BREAKING CHANGE: description` (triggers MAJOR version bump)\n';
71-
}
57+
${{ steps.semantic.outputs.new_release_version && '✅ Valid semantic version changes detected!' || '⚠️ No semantic version changes detected.' }}
7258
73-
github.rest.issues.createComment({
74-
issue_number: context.issue.number,
75-
owner: context.repo.owner,
76-
repo: context.repo.repo,
77-
body: comment
78-
});
59+
${{ steps.semantic.outputs.new_release_version && format('Next version will be: **{0}**', steps.semantic.outputs.new_release_version) || 'Please ensure your commits follow the [Conventional Commits](https://www.conventionalcommits.org/) format:
60+
61+
- `feat: new feature` (triggers MINOR version bump)
62+
- `fix: bug fix` (triggers PATCH version bump)
63+
- `BREAKING CHANGE: description` (triggers MAJOR version bump)' }}
64+
comment_tag: semantic-version-check

0 commit comments

Comments
 (0)