Skip to content

Conversation

@GabrielDrapor
Copy link
Contributor

@GabrielDrapor GabrielDrapor commented Jun 25, 2025

User description

https://github.com/modelcontextprotocol/servers-archived

#175

image image

PR Type

Enhancement


Description

  • Add archived badge support for deprecated servers

  • Display archived status in CLI info command

  • Mark 13 official servers as archived

  • Update JSON schema to include archived field


Changes walkthrough 📝

Relevant files
Enhancement
2 files
info.py
Display archived status in server info                                     
+19/-8   
index.html
Add archived badge styling and display                                     
+54/-18 
Configuration changes
14 files
server-schema.json
Add is_archived field to schema                                                   
+4/-1     
aws-kb-retrieval.json
Mark server as archived                                                                   
+2/-1     
brave-search.json
Mark server as archived                                                                   
+2/-1     
everart.json
Mark server as archived                                                                   
+2/-1     
git.json
Mark server as archived                                                                   
+2/-1     
github.json
Mark server as archived                                                                   
+2/-1     
gitlab.json
Mark server as archived                                                                   
+2/-1     
google-drive.json
Mark server as archived                                                                   
+2/-1     
google-maps.json
Mark server as archived                                                                   
+2/-1     
postgresql.json
Mark server as archived                                                                   
+2/-1     
puppeteer.json
Mark server as archived                                                                   
+2/-1     
sentry.json
Mark server as archived                                                                   
+2/-1     
slack.json
Mark server as archived                                                                   
+2/-1     
sqlite.json
Mark server as archived                                                                   
+2/-1     

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jun 25, 2025

    PR Reviewer Guide 🔍

    (Review updated until commit 92251f2)

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Code Formatting

    Several lines have inconsistent formatting with line breaks and indentation that could affect readability and maintainability.

    console.print(f"Author: {author_name}" +
                  (f" ({author_email})" if author_email else ""))
    console.print(f"License: {license_info}")
    console.print(f"Official: {is_official}")
    if is_archived:
        console.print(f"Archived: {is_archived}")
    Hard-coded Color

    The archived badge uses a hard-coded color value (#60491a) instead of CSS variables, which breaks the design system consistency.

    background-color: #60491a;
    color: var(--text-secondary);

    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented Jun 25, 2025

    PR Code Suggestions ✨

    Latest suggestions up to 92251f2
    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Improve archived status display format

    The archived status should only be displayed when true, not show the boolean
    value. Consider using a more descriptive message or just showing "Archived"
    without the boolean value.

    src/mcpm/commands/info.py [91-92]

     if is_archived:
    -    console.print(f"Archived: {is_archived}")
    +    console.print("Archived: Yes")
    • Apply / Chat
    Suggestion importance[1-10]: 4

    __

    Why: The suggestion correctly identifies that printing the boolean value True is not ideal for user-facing output. The existing_code at line 92 would print Archived: True, and the proposed change to Archived: Yes improves the readability and user-friendliness of the command's output.

    Low
    • More

    Previous suggestions

    Suggestions up to commit 92251f2
    CategorySuggestion                                                                                                                                    Impact
    General
    Improve archived status display styling

    The archived status should be displayed with a warning style to make it more
    prominent. Using a simple boolean value doesn't provide clear visual indication
    that this server is archived.

    src/mcpm/commands/info.py [91-92]

     if is_archived:
    -    console.print(f"Archived: {is_archived}")
    +    console.print("[yellow]Archived: Yes[/]")
    Suggestion importance[1-10]: 6

    __

    Why: The suggestion correctly identifies that printing a boolean True for the archived status is not visually prominent. Using colored output via [yellow]Archived: Yes[/] makes the status clearer and more user-friendly, which aligns with the PR's intent.

    Low

    @github-actions
    Copy link
    Contributor

    Summary

    Adds a new is_archived flag to the server schema and registry UI/CLI, then marks several legacy servers as archived so the web page and mcpm info command show an “Archived” badge.

    Key changes
    • schema: mcp-registry/schema/server-schema.json now accepts is_archived: boolean
    • data: 13 server JSON files updated with "is_archived": true
    • CLI: mcpm info prints “Archived” when the flag is set
    • UI: pages/registry/index.html shows a styled “Archived” badge


    Review

    Nice, tidy update that cleanly introduces the new flag and surfaces it everywhere it’s needed.

    👍 Looks good to merge; two minor nits for a follow-up:

    • Add a trailing newline to the edited JSON files to keep git diffs clean.
    • Consider documenting the new field in README / contributor docs so future packages stay consistent.

    View workflow run

    @GabrielDrapor GabrielDrapor merged commit 44f4c26 into main Jun 26, 2025
    8 of 9 checks passed
    @GabrielDrapor GabrielDrapor deleted the Jiarui/archived-badge branch June 26, 2025 07:29
    @mcpm-semantic-release
    Copy link

    🎉 This PR is included in version 1.14.1 🎉

    The release is available on GitHub release

    Your semantic-release bot 📦🚀

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants