Run unload_entry, already_configured tests only once (#632)

* run unload test only once

all BMSs are identical for unload, so one test is sufficient. Better scales with increasing number of BMSs

* run already_configured test only once

Author: patman15

tests/test_config_flow.py

@@ -196,10 +196,10 @@ async def test_device_not_supported(
 
 
 @pytest.mark.usefixtures("enable_bluetooth")
-async def test_already_configured(bms_fixture: str, hass: HomeAssistant) -> None:
+async def test_already_configured(hass: HomeAssistant) -> None:
     """Test that same device cannot be added twice."""
 
-    cfg: MockConfigEntry = mock_config(bms_fixture)
+    cfg: MockConfigEntry = mock_config()
     cfg.add_to_hass(hass)
 
     await hass.config_entries.async_setup(cfg.entry_id)
@@ -210,7 +210,7 @@ async def test_already_configured(bms_fixture: str, hass: HomeAssistant) -> None
         context={"source": SOURCE_USER},
         data={
             CONF_ADDRESS: "cc:cc:cc:cc:cc:cc",
-            "type": "aiobmsble.bms.ogt_bms",
+            "type": "aiobmsble.bms.dummy_bms",
         },
     )
     assert result.get("type") == FlowResultType.ABORT

tests/test_init.py

@@ -68,7 +68,6 @@ async def mock_coord_shutdown(_self) -> None:
 @pytest.mark.usefixtures("enable_bluetooth", "patch_default_bleak_client")
 async def test_unload_entry(
     monkeypatch: pytest.MonkeyPatch,
-    bms_fixture: str,
     bool_fixture: bool,
     bt_discovery: BluetoothServiceInfoBleak,
     hass: HomeAssistant,
@@ -79,12 +78,12 @@ async def test_unload_entry(
     # first load entry (see test_async_setup_entry)
     inject_bluetooth_service_info_bleak(hass, bt_discovery)
 
-    cfg: MockConfigEntry = mock_config(bms=bms_fixture)
+    cfg: MockConfigEntry = mock_config()
     cfg.add_to_hass(hass)
 
-    bms_module: Final[str] = f"aiobmsble.bms.{bms_fixture}"
-    monkeypatch.setattr(f"{bms_module}.BMS.device_info", mock_devinfo_min)
-    monkeypatch.setattr(f"{bms_module}.BMS.async_update", mock_update_min)
+    bms_class: Final[str] = "aiobmsble.bms.dummy_bms.BMS"
+    monkeypatch.setattr(f"{bms_class}.device_info", mock_devinfo_min)
+    monkeypatch.setattr(f"{bms_class}.async_update", mock_update_min)
 
     async def mock_coord_shutdown(_self) -> None:
         trace_fct["shutdown_called"] = True