Merge branch 'main' into fix-reduce-test-effort

Author: patman15

custom_components/bms_ble/coordinator.py

@@ -143,7 +143,7 @@ async def _async_update_data(self) -> BMSSample:
             raise UpdateFailed(
                 translation_domain=DOMAIN,
                 translation_key="bms_com_fail_rssi"
-                if not rssi or rssi < LOW_RSSI
+                if rssi is not None and rssi < LOW_RSSI
                 else "bms_com_fail",
                 translation_placeholders={
                     "rssi": f"{rssi}" if rssi is not None else "--",

custom_components/bms_ble/sensor.py

@@ -43,6 +43,7 @@
     ATTR_POWER,
     ATTR_RSSI,
     ATTR_RUNTIME,
+    ATTR_TEMP_SENSORS,
     DOMAIN,
     LOGGER,
 )
@@ -98,13 +99,11 @@ def _attr_pack(
     ),
     BmsEntityDescription(
         attr_fn=lambda data: (
-            {"temperature_sensors": data.get("temp_values", [])}
+            {ATTR_TEMP_SENSORS: data.get("temp_values", [])}
             if "temp_values" in data
-            else (
-                {"temperature_sensors": [data.get("temperature", 0.0)]}
-                if "temperature" in data
-                else {}
-            )
+            else {ATTR_TEMP_SENSORS: [data.get("temperature", 0.0)]}
+            if "temperature" in data
+            else {}
         ),
         device_class=SensorDeviceClass.TEMPERATURE,
         key=ATTR_TEMPERATURE,
@@ -219,7 +218,7 @@ def _attr_pack(
         key=ATTR_RSSI,
         native_unit_of_measurement=SIGNAL_STRENGTH_DECIBELS_MILLIWATT,
         state_class=SensorStateClass.MEASUREMENT,
-        value_fn=lambda data: None,  # RSSI is handled in a separate class
+        value_fn=lambda data: None,
     ),
     BmsEntityDescription(
         entity_category=EntityCategory.DIAGNOSTIC,
@@ -228,7 +227,7 @@ def _attr_pack(
         native_unit_of_measurement=PERCENTAGE,
         state_class=SensorStateClass.MEASUREMENT,
         translation_key=ATTR_LQ,
-        value_fn=lambda data: None,  # LQ is handled in a separate class
+        value_fn=lambda data: None,
     ),
 ]
 

custom_components/bms_ble/strings.json

@@ -5,7 +5,7 @@
       "no_devices_found": "No supported devices found via Bluetooth.",
       "not_supported": "Device is not supported."
     },
-    "flow_title": "Setup {name} ({id}) as {model}",
+    "flow_title": "Set up {name} ({id}) as {model}",
     "step": {
       "bluetooth_confirm": {
         "description": "Do you want to set up {name} ({id})?"