Read DataInput with buffer

Author: patrickfav

src/main/java/at/favre/lib/bytes/Util.java

@@ -278,8 +278,13 @@ static byte[] readFromStream(InputStream inputStream) {
     static byte[] readFromDataInput(DataInput dataInput, int length) {
         ByteArrayOutputStream out = new ByteArrayOutputStream();
         try {
+            byte[] buf;
+            int remaining = length;
             for (int i = 0; i < length; i++) {
-                out.write(dataInput.readUnsignedByte());
+                buf = new byte[Math.min(remaining, BUF_SIZE)];
+                dataInput.readFully(buf);
+                out.write(buf);
+                remaining -= buf.length;
             }
             return out.toByteArray();
         } catch (Exception e) {

src/test/java/at/favre/lib/bytes/BytesConstructorTests.java

@@ -229,6 +229,7 @@ public void fromInputStream() throws Exception {
         checkInputStream(example_bytes_seven);
         checkInputStream(example_bytes_eight);
         checkInputStream(example_bytes_sixteen);
+        checkInputStream(Bytes.random(32 * 987).array());
     }
 
     private void checkInputStream(byte[] array) {
@@ -243,6 +244,7 @@ public void fromDataInput() throws Exception {
         checkDataInput(example_bytes_seven);
         checkDataInput(example_bytes_eight);
         checkDataInput(example_bytes_sixteen);
+        checkDataInput(Bytes.random(32 * 987).array());
     }
 
     private void checkDataInput(byte[] array) {
@@ -266,7 +268,7 @@ public void fromList() throws Exception {
 
     private void checkList(byte[] array) {
         Bytes bList = Bytes.from(Util.toList(array));
-        Bytes bLinkedList = Bytes.from(new LinkedList<Byte>(Util.toList(array)));
+        Bytes bLinkedList = Bytes.from(new LinkedList<>(Util.toList(array)));
         assertArrayEquals(array, bList.array());
         assertArrayEquals(array, bLinkedList.array());
     }