Remove caching of mutable bytes hashcode

Author: patrickfav

src/main/java/at/favre/lib/bytes/Bytes.java

@@ -1880,8 +1880,7 @@ public boolean equalsContent(Bytes other) {
     @Override
     public int hashCode() {
         if (hashCodeCache == 0) {
-            hashCodeCache = Arrays.hashCode(byteArray);
-            hashCodeCache = 31 * hashCodeCache + (byteOrder != null ? byteOrder.hashCode() : 0);
+            hashCodeCache = Util.hashCode(internalArray(), byteOrder());
         }
         return hashCodeCache;
     }

src/main/java/at/favre/lib/bytes/MutableBytes.java

@@ -126,6 +126,11 @@ public MutableBytes secureWipe(SecureRandom random) {
         return this;
     }
 
+    @Override
+    public int hashCode() {
+        return Util.hashCode(internalArray(), byteOrder());
+    }
+
     /**
      * Factory creating mutable byte types
      */

src/main/java/at/favre/lib/bytes/Util.java

@@ -21,10 +21,25 @@
 
 package at.favre.lib.bytes;
 
-import java.io.*;
+import java.io.ByteArrayOutputStream;
+import java.io.DataInput;
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
 import java.nio.ByteBuffer;
+import java.nio.ByteOrder;
 import java.nio.file.Files;
-import java.util.*;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.List;
+import java.util.Map;
+import java.util.NoSuchElementException;
+import java.util.Objects;
+import java.util.Random;
+import java.util.UUID;
 
 /**
  * Common Util methods to convert or modify byte arrays
@@ -489,6 +504,19 @@ static ByteBuffer getBytesFromUUID(UUID uuid) {
         return bb;
     }
 
+    /**
+     * Hashcode implementation for a byte array and given byte order
+     *
+     * @param byteArray
+     * @param byteOrder
+     * @return hashCode
+     */
+    static int hashCode(byte[] byteArray, ByteOrder byteOrder) {
+        int result = Arrays.hashCode(byteArray);
+        result = 31 * result + (byteOrder != null ? byteOrder.hashCode() : 0);
+        return result;
+    }
+
     /*
     =================================================================================================
      Copyright 2011 Twitter, Inc.