Remove hashCode caching since it could introduce very subtle bugs

Author: patrickfav

src/main/java/at/favre/lib/bytes/Bytes.java

@@ -745,7 +745,6 @@ public static Bytes random(int length, Random random) {
     private final byte[] byteArray;
     private final ByteOrder byteOrder;
     private final BytesFactory factory;
-    private transient int hashCodeCache;
 
     Bytes(byte[] byteArray, ByteOrder byteOrder) {
         this(byteArray, byteOrder, new Factory());
@@ -2221,10 +2220,7 @@ public boolean equalsContent(Bytes other) {
 
     @Override
     public int hashCode() {
-        if (hashCodeCache == 0) {
-            hashCodeCache = Util.Obj.hashCode(internalArray(), byteOrder());
-        }
-        return hashCodeCache;
+        return Util.Obj.hashCode(internalArray(), byteOrder());
     }
 
     /**

src/main/java/at/favre/lib/bytes/MutableBytes.java

@@ -178,11 +178,6 @@ public Bytes immutable() {
         return Bytes.wrap(internalArray(), byteOrder());
     }
 
-    @Override
-    public int hashCode() {
-        return Util.Obj.hashCode(internalArray(), byteOrder());
-    }
-
     @Override
     public boolean equals(Object o) {
         return super.equals(o);