Skip to content

Commit 528413b

Browse files
committed
Remove errorprone and proguard optimized version to be able to build with JDK11
Not yet JDK17 compatible
1 parent ff440e6 commit 528413b

File tree

4 files changed

+10
-14
lines changed

4 files changed

+10
-14
lines changed

.github/workflows/build_deploy.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ jobs:
3333
path: ~/.m2
3434
key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }}
3535
restore-keys: ${{ runner.os }}-m2
36-
- name: Set up JDK 8
36+
- name: Set up JDK 11
3737
uses: actions/setup-java@v3
3838
with:
39-
java-version: '8'
40-
distribution: 'adopt'
39+
java-version: '11'
40+
distribution: 'temurin'
4141
- name: Build with Maven
4242
run: ./mvnw -B clean verify checkstyle:checkstyle jacoco:report -DcommonConfig.jarSign.skip=true
4343
- name: Analyze with SonaQube
@@ -68,8 +68,8 @@ jobs:
6868
- name: Set up Maven Central Repository
6969
uses: actions/setup-java@v3
7070
with:
71-
java-version: '8'
72-
distribution: 'adopt'
71+
java-version: '11'
72+
distribution: 'temurin'
7373
server-id: ossrh # Value of the distributionManagement/repository/id field of the pom.xml
7474
server-username: MAVEN_USERNAME # env variable for username in deploy
7575
server-password: MAVEN_PASSWORD # env variable for token in deploy

.mvn/maven.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
-DcommonConfig.compiler.profile=jdk7_w_errorprone
1+
-DcommonConfig.compiler.profile=jdk7

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -700,8 +700,8 @@ the plugin versions as well as providing the checkstyle config rules. Specifical
700700

701701
## Tech Stack
702702

703-
* Java 7 (+ [errorprone](https://github.com/google/error-prone) static analyzer)
704-
* Maven
703+
* Java 7 Source, JDK 11 required to build (not yet JDK17 compatible)
704+
* Maven 3
705705

706706
# Credits
707707

pom.xml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<parent>
88
<groupId>at.favre.lib</groupId>
99
<artifactId>common-parent</artifactId>
10-
<version>18</version>
10+
<version>18.1</version>
1111
</parent>
1212

1313
<artifactId>bytes</artifactId>
@@ -41,7 +41,7 @@
4141
<plugin>
4242
<groupId>org.apache.felix</groupId>
4343
<artifactId>maven-bundle-plugin</artifactId>
44-
<version>4.2.0</version>
44+
<version>5.1.8</version>
4545
<extensions>true</extensions>
4646
</plugin>
4747
<plugin>
@@ -71,10 +71,6 @@
7171
<groupId>org.jacoco</groupId>
7272
<artifactId>jacoco-maven-plugin</artifactId>
7373
</plugin>
74-
<plugin>
75-
<groupId>com.github.wvengen</groupId>
76-
<artifactId>proguard-maven-plugin</artifactId>
77-
</plugin>
7874
<plugin>
7975
<groupId>org.apache.maven.plugins</groupId>
8076
<artifactId>maven-jarsigner-plugin</artifactId>

0 commit comments

Comments
 (0)