Update travis config and update checkstyle config

Author: patrickfav

.travis.yml

@@ -1,9 +1,7 @@
 # To let the CI execute the maven wrapper, use this command and push the change:
 #    git update-index --chmod=+x mvnw
 
-sudo: false # route your build to the container-based infrastructure for a faster build
 language: java
-install: true
 jdk:
   - openjdk8
 
@@ -17,8 +15,8 @@ before_install:
   - tar xvf secrets.tar
 
 script:
-  - 'if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then ./mvnw clean install -Djarsigner.skip=true checkstyle:check; fi'
-  - 'if [ "$TRAVIS_PULL_REQUEST" = "false" ]; then ./mvnw clean install -Djarsigner.skip=false checkstyle:check; fi'
+  - 'if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then ./mvnw clean install -Djarsigner.skip=true; fi'
+  - 'if [ "$TRAVIS_PULL_REQUEST" = "false" ]; then ./mvnw clean install -Djarsigner.skip=false; fi'
 
 after_success:
   - ./mvnw test jacoco:report coveralls:report
@@ -31,14 +29,14 @@ deploy:
       branch: master
       tags: true
   - provider: releases
-    api_key:
+    token:
       secure: "ozRga/xe4pNZNH59tmPK1lLpCFa4WFW674JMTBWLbf+7zjPiN8K5dtAYUkhDqngw0ifasukVCRey4F9fu479KlFciGrLBd4r/hq/rh7inVHqd1qcn4AwyDX3EkbloD5qwfas7yn5zJ7cWm7KyEkfpr+fgReaQzSRvJUpjpDBrS2xNIYOhL1tInu84/RtyB6QuJjQOkH9rulP9M8gjcEH9Iu0k40jAVYLJDL9opOWrc9qpAzL0wN4xXGbnI30WrA8nmLcrHRxODOxbYEQ5EndLFJyS3nYxL9D3QJeEYkXf9uqz46V4dgfrEirWrtin3PlSUKTD9/0Mqz4uxqrGky0vrpha7m231+ilTUJzvE0a29LdS3R4A6ssDb0oFtj4pP3O6uNDqZN20r83ughGi0GrlKL/CGpQ4fS5nOpqppx0Xg+SR78/uOqQDIOn570FILBTKiaTsCn6xKqYC4QFSlsZiXojgU4FDZpKygH932qUDE0BnzsZEtzCube2oXMktZs6keSmELMyRYVs/K9yC7+8R1Pez1Xz72zxNG1ke6588sO3wxN+Q+0ZhqmQC8Y2OY8i72b06M5SyGz5TV38SrntLU88HOMWVJtfRDcMcPnJdFgaujZCoOw5SfokzXncipldfJGpKGIb3fHBMJw0MzspT7Kp6XRzSbtJI5+NVestR4="
     file_glob: true
     file:
       - "target/*.jar"
       - "target/*.sha256"
       - "target/checksum-sha256.txt"
-    skip_cleanup: true
+    cleanup: true
     on:
       branch: master
       tags: true

CONTRIBUTING.md

@@ -8,7 +8,7 @@ This repo validates against checkstyle (import the xml found in the root to your
 To run the tests (and checkstyle):
 
 ```shell
-mvn test checkstyle:check
+mvn test
 ```
 
 Tests are automatically run against branches and pull requests

checkstyle.xml

@@ -34,13 +34,15 @@
     <module name="FileLength"><!-- max line length for single file: http://checkstyle.sourceforge.net/config_sizes.html#FileLength -->
         <property name="max" value="3500"/>
     </module>
+    <module name="LineLength"><!-- max char length per line http://checkstyle.sourceforge.net/config_sizes.html#LineLength -->
+        <property name="max" value="300"/>
+    </module>
 
     <module name="TreeWalker">
         <module name="SuppressionCommentFilter"/> <!-- use //CHECKSTYLE:OFF (...) //CHECKSTYLE:ON to disable checkstyle: http://checkstyle.sourceforge.net/config_filters.html#SuppressionCommentFilter -->
 
         <!-- Annotations -->
         <module name="MissingDeprecated"> <!-- if @deprecated and javadoc is there, must be explained in javadoc: http://checkstyle.sourceforge.net/config_annotation.html#MissingDeprecated -->
-            <property name="skipNoJavadoc" value="true"/>
         </module>
         <module name="MissingOverride"/> <!-- if has @inheritDoc in javadoc must have @Override http://checkstyle.sourceforge.net/config_annotation.html#MissingOverride -->
         <module name="PackageAnnotation"/> <!-- must only be in package-info: http://checkstyle.sourceforge.net/config_annotation.html#PackageAnnotation -->
@@ -107,9 +109,6 @@
         <module name="IllegalInstantiation"/> <!-- Must not use const of certain types (Activity, Fragment): http://checkstyle.sourceforge.net/config_coding.html#IllegalInstantiation -->
 
         <!-- Size Limitiations -->
-        <module name="LineLength"><!-- max char length per line http://checkstyle.sourceforge.net/config_sizes.html#LineLength -->
-            <property name="max" value="300"/>
-        </module>
         <module name="MethodLength"><!-- max line length for single method http://checkstyle.sourceforge.net/config_sizes.html#MethodLength -->
             <property name="max" value="150"/>
         </module>

pom.xml

@@ -62,17 +62,24 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
-                <version>3.0.0</version>
+                <version>3.1.1</version>
                 <configuration>
                     <configLocation>checkstyle.xml</configLocation>
                     <suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
                     <suppressionsFileExpression>checkstyle.suppressions.file</suppressionsFileExpression>
                 </configuration>
+                <executions>
+                    <execution>
+                        <goals>
+                            <goal>check</goal>
+                        </goals>
+                    </execution>
+                </executions>
                 <dependencies>
                     <dependency>
                         <groupId>com.puppycrawl.tools</groupId>
                         <artifactId>checkstyle</artifactId>
-                        <version>8.18</version>
+                        <version>8.31</version>
                     </dependency>
                 </dependencies>
             </plugin>

src/main/java/at/favre/lib/bytes/BytesValidators.java

@@ -113,7 +113,6 @@ public static BytesValidator noneOf(byte refByte) {
         return new BytesValidator.IdenticalContent(refByte, BytesValidator.IdenticalContent.Mode.NONE_OF);
     }
 
-
     /**
      * This will execute all passed validators and returns true if at least one returns true (i.e. OR concatenation)
      *

src/main/java/at/favre/lib/bytes/Util.java

@@ -72,7 +72,6 @@ static byte[] concat(byte[]... arrays) {
             return result;
         }
 
-
         /**
          * Combines a single argument with a vararg to a single array
          *