Non working version of new type hierarchy

Author: patrickfav

src/main/java/at/favre/lib/bytes/AbstractBytes.java

@@ -0,0 +1,51 @@
+/*
+ * Copyright 2017 Patrick Favre-Bulle
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package at.favre.lib.bytes;
+
+import java.nio.ByteOrder;
+
+public abstract class AbstractBytes {
+
+    private final byte[] byteArray;
+    private final ByteOrder byteOrder;
+
+    /**
+     * Creates a new immutable instance
+     *
+     * @param byteArray internal byte array
+     * @param byteOrder the internal byte order - this is used to interpret given array, not to change it
+     */
+    public AbstractBytes(byte[] byteArray, ByteOrder byteOrder) {
+        this.byteArray = byteArray;
+        this.byteOrder = byteOrder;
+    }
+
+    abstract BytesFactory getFactory();
+
+    public boolean isMutable() {
+        return false;
+    }
+
+    public boolean isReadOnly() {
+        return false;
+    }
+}

src/main/java/at/favre/lib/bytes/Bytes.java

@@ -56,7 +56,7 @@
  * </pre>
  */
 @SuppressWarnings("WeakerAccess")
-public class Bytes implements Comparable<Bytes> {
+public class Bytes extends AbstractBytes implements Comparable<Bytes> {
 
     /* FACTORY ***************************************************************************************************/
 
@@ -381,42 +381,16 @@ public static Bytes random(int length, Random random) {
 
     private final byte[] byteArray;
     private final ByteOrder byteOrder;
-    private final boolean mutable;
-    private final boolean readonly;
 
     /**
      * Creates a new immutable instance
      *
      * @param byteArray internal byte array
      * @param byteOrder the internal byte order - this is used to interpret given array, not to change it
      */
-    Bytes(byte[] byteArray, ByteOrder byteOrder) {
-        this(byteArray, byteOrder, false, false);
-    }
-
-    /**
-     * Creates a new instance with given array and copies all attributes from old instance
-     *
-     * @param byteArray   internal byte array
-     * @param oldInstance old instance to copy all internal attributes
-     */
-    Bytes(byte[] byteArray, Bytes oldInstance) {
-        this(byteArray, oldInstance.byteOrder(), oldInstance.mutable, oldInstance.readonly);
-    }
-
-    /**
-     * Creates a new instance
-     *
-     * @param byteArray internal byte array
-     * @param byteOrder the internal byte order - this is used to interpret given array, not to change it
-     * @param mutable   if the internal state can be changed
-     * @param readonly  if all getter for internal byte array will fail
-     */
-    Bytes(byte[] byteArray, ByteOrder byteOrder, boolean mutable, boolean readonly) {
+    public Bytes(byte[] byteArray, ByteOrder byteOrder) {
         this.byteArray = byteArray;
         this.byteOrder = byteOrder;
-        this.mutable = mutable;
-        this.readonly = readonly;
     }
 
     /* TRANSFORMER **********************************************************************************************/
@@ -692,7 +666,7 @@ public Bytes shuffle() {
      * @return the transformed instance (might be the same, or a new one)
      */
     public Bytes transform(BytesTransformer transformer) {
-        return transformer.transform(this, mutable);
+        return transformer.transform(this, isMutable());
     }
 
     /**
@@ -776,8 +750,9 @@ public ByteOrder byteOrder() {
      *
      * @return true if read only
      */
+    @Override
     public boolean isReadOnly() {
-        return readonly;
+        return false;
     }
 
     /**
@@ -904,7 +879,7 @@ public Bytes byteOrder(ByteOrder byteOrder) {
      * @return a new instance if not already readonly, or "this" otherwise
      */
     public Bytes readOnly() {
-        if (readonly) {
+        if (isReadOnly()) {
             return this;
         } else {
             return new Bytes(internalArray(), byteOrder, false, true);
@@ -980,7 +955,7 @@ public InputStream inputStream() {
      * @throws ReadOnlyBufferException if this is a read-only instance
      */
     public byte[] array() {
-        if (!readonly) {
+        if (!isReadOnly()) {
             return internalArray();
         }
         throw new ReadOnlyBufferException();

src/main/java/at/favre/lib/bytes/BytesFactory.java

@@ -0,0 +1,28 @@
+/*
+ * Copyright 2017 Patrick Favre-Bulle
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package at.favre.lib.bytes;
+
+import java.nio.ByteOrder;
+
+public interface BytesFactory {
+    Bytes wrap(byte[] array, ByteOrder byteOrder);
+}

src/main/java/at/favre/lib/bytes/MutableBytes.java

@@ -34,7 +34,12 @@
 public final class MutableBytes extends Bytes {
 
     MutableBytes(byte[] byteArray, ByteOrder byteOrder) {
-        super(byteArray, byteOrder, true, false);
+        super(byteArray, byteOrder);
+    }
+
+    @Override
+    public boolean isMutable() {
+        return true;
     }
 
     /**