Encoder honor byte order

Author: patrickfav

src/main/java/at/favre/lib/bytes/BinaryToTextEncoding.java

@@ -78,9 +78,12 @@ public Hex(boolean upperCase) {
         @Override
         public String encode(byte[] byteArray, ByteOrder byteOrder) {
             StringBuilder sb = new StringBuilder(byteArray.length * 2);
-            for (byte anArray : byteArray) {
-                char first4Bit = Character.forDigit((anArray >> 4) & 0xF, 16);
-                char last4Bit = Character.forDigit((anArray & 0xF), 16);
+
+            int index;
+            for (int i = 0; i < byteArray.length; i++) {
+                index = (byteOrder == ByteOrder.BIG_ENDIAN) ? i : byteArray.length - i - 1;
+                char first4Bit = Character.forDigit((byteArray[index] >> 4) & 0xF, 16);
+                char last4Bit = Character.forDigit((byteArray[index] & 0xF), 16);
                 if (upperCase) {
                     first4Bit = Character.toUpperCase(first4Bit);
                     last4Bit = Character.toUpperCase(last4Bit);
@@ -114,7 +117,7 @@ public byte[] decode(String hexString) {
     class Base64Encoding implements Encoder, Decoder {
         @Override
         public String encode(byte[] array, ByteOrder byteOrder) {
-            return Base64.encode(array);
+            return Base64.encode((byteOrder == ByteOrder.BIG_ENDIAN) ? array : Bytes.from(array).reverse().array());
         }
 
         @Override
@@ -132,7 +135,7 @@ class BaseRadix implements Encoder, Decoder {
 
         @Override
         public String encode(byte[] array, ByteOrder byteOrder) {
-            return new BigInteger(1, array).toString(radix);
+            return new BigInteger(1, (byteOrder == ByteOrder.BIG_ENDIAN) ? array : Bytes.from(array).reverse().array()).toString(radix);
         }
 
         @Override

src/test/java/at/favre/lib/bytes/BinaryToTextEncodingTest.java

@@ -0,0 +1,33 @@
+package at.favre.lib.bytes;
+
+import org.junit.Test;
+
+import java.nio.ByteOrder;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotEquals;
+
+public class BinaryToTextEncodingTest {
+    @Test
+    public void encodeHex() throws Exception {
+        assertEquals("010203", new BinaryToTextEncoding.Hex(false).encode(new byte[]{1, 2, 3}, ByteOrder.BIG_ENDIAN));
+        assertEquals("030201", new BinaryToTextEncoding.Hex(false).encode(new byte[]{1, 2, 3}, ByteOrder.LITTLE_ENDIAN));
+        assertNotEquals(new BinaryToTextEncoding.Hex(false).encode(new byte[]{1, 2, 3}, ByteOrder.LITTLE_ENDIAN), new BinaryToTextEncoding.Hex(false).encode(new byte[]{1, 2, 3}, ByteOrder.BIG_ENDIAN));
+    }
+
+    @Test
+    public void encodeBaseRadix() throws Exception {
+        assertEquals("100211", new BinaryToTextEncoding.BaseRadix(16).encode(new byte[]{16, 2, 17}, ByteOrder.BIG_ENDIAN));
+        assertEquals("110210", new BinaryToTextEncoding.BaseRadix(16).encode(new byte[]{16, 2, 17}, ByteOrder.LITTLE_ENDIAN));
+        assertNotEquals(new BinaryToTextEncoding.BaseRadix(2).encode(new byte[]{1, 2, 3}, ByteOrder.LITTLE_ENDIAN), new BinaryToTextEncoding.BaseRadix(2).encode(new byte[]{1, 2, 3}, ByteOrder.BIG_ENDIAN));
+
+    }
+
+    @Test
+    public void encodeBase64() throws Exception {
+        assertEquals("EAIR", new BinaryToTextEncoding.Base64Encoding().encode(new byte[]{16, 2, 17}, ByteOrder.BIG_ENDIAN));
+        assertEquals("EQIQ", new BinaryToTextEncoding.Base64Encoding().encode(new byte[]{17, 2, 16}, ByteOrder.BIG_ENDIAN));
+        assertEquals("EQIQ", new BinaryToTextEncoding.Base64Encoding().encode(new byte[]{16, 2, 17}, ByteOrder.LITTLE_ENDIAN));
+        assertNotEquals(new BinaryToTextEncoding.Base64Encoding().encode(new byte[]{1, 2, 3}, ByteOrder.LITTLE_ENDIAN), new BinaryToTextEncoding.Base64Encoding().encode(new byte[]{1, 2, 3}, ByteOrder.BIG_ENDIAN));
+    }
+}