Skip to content

Commit bc573f5

Browse files
patrickfavpatrickfav
committed
Minimalize POM with using common-parent POM
1 parent baf088b commit bc573f5

File tree

3 files changed

+10
-282
lines changed

3 files changed

+10
-282
lines changed

‎checkstyle-suppressions.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@
2828
<suppress checks="FileLength"
2929
files="Bytes.java"
3030
lines="0-3000"/>
31-
</suppressions>
31+
</suppressions>

‎checkstyle.xml‎

Lines changed: 0 additions & 156 deletions
This file was deleted.

‎pom.xml‎

Lines changed: 9 additions & 125 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,12 @@
44
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
55
<modelVersion>4.0.0</modelVersion>
66

7-
<groupId>at.favre.lib</groupId>
7+
<parent>
8+
<groupId>at.favre.lib</groupId>
9+
<artifactId>common-parent</artifactId>
10+
<version>5</version>
11+
</parent>
12+
813
<artifactId>bytes</artifactId>
914
<version>1.3.0</version>
1015
<packaging>bundle</packaging>
@@ -17,14 +22,11 @@
1722
<url>https://github.com/patrickfav/bytes-java</url>
1823
<inceptionYear>2017</inceptionYear>
1924

20-
<properties>
21-
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
22-
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
23-
</properties>
2425
<repositories>
2526
<repository>
26-
<id>maven-central-repo</id>
27-
<url>http://repo1.maven.org/maven2</url>
27+
<id>jcenter</id>
28+
<name>jcenter</name>
29+
<url>https://jcenter.bintray.com</url>
2830
<snapshots>
2931
<enabled>false</enabled>
3032
</snapshots>
@@ -36,22 +38,6 @@
3638
<plugin>
3739
<groupId>org.apache.maven.plugins</groupId>
3840
<artifactId>maven-enforcer-plugin</artifactId>
39-
<version>3.0.0-M2</version>
40-
<executions>
41-
<execution>
42-
<id>enforce-maven</id>
43-
<goals>
44-
<goal>enforce</goal>
45-
</goals>
46-
<configuration>
47-
<rules>
48-
<requireMavenVersion>
49-
<version>[3.3.9,)</version>
50-
</requireMavenVersion>
51-
</rules>
52-
</configuration>
53-
</execution>
54-
</executions>
5541
</plugin>
5642
<plugin>
5743
<groupId>org.apache.felix</groupId>
@@ -62,101 +48,33 @@
6248
<plugin>
6349
<groupId>org.apache.maven.plugins</groupId>
6450
<artifactId>maven-checkstyle-plugin</artifactId>
65-
<version>3.1.1</version>
6651
<configuration>
67-
<configLocation>checkstyle.xml</configLocation>
6852
<suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
69-
<suppressionsFileExpression>checkstyle.suppressions.file</suppressionsFileExpression>
7053
</configuration>
71-
<executions>
72-
<execution>
73-
<goals>
74-
<goal>check</goal>
75-
</goals>
76-
</execution>
77-
</executions>
78-
<dependencies>
79-
<dependency>
80-
<groupId>com.puppycrawl.tools</groupId>
81-
<artifactId>checkstyle</artifactId>
82-
<version>8.31</version>
83-
</dependency>
84-
</dependencies>
8554
</plugin>
8655
<plugin>
8756
<groupId>org.apache.maven.plugins</groupId>
8857
<artifactId>maven-compiler-plugin</artifactId>
89-
<version>3.7.0</version>
90-
<configuration>
91-
<compilerId>javac-with-errorprone</compilerId>
92-
<forceJavacCompilerUse>true</forceJavacCompilerUse>
93-
<source>1.7</source>
94-
<target>1.7</target>
95-
</configuration>
96-
<dependencies>
97-
<dependency>
98-
<groupId>org.codehaus.plexus</groupId>
99-
<artifactId>plexus-compiler-javac-errorprone</artifactId>
100-
<version>2.8.2</version>
101-
</dependency>
102-
<!-- override plexus-compiler-javac-errorprone's dependency on
103-
Error Prone with the latest version -->
104-
<dependency>
105-
<groupId>com.google.errorprone</groupId>
106-
<artifactId>error_prone_core</artifactId>
107-
<!-- only one compatible with java 7-->
108-
<version>2.0.5</version>
109-
</dependency>
110-
</dependencies>
11158
</plugin>
11259
<plugin>
11360
<groupId>org.apache.maven.plugins</groupId>
11461
<artifactId>maven-source-plugin</artifactId>
115-
<version>3.0.1</version>
116-
<executions>
117-
<execution>
118-
<id>attach-sources</id>
119-
<goals>
120-
<goal>jar</goal>
121-
</goals>
122-
</execution>
123-
</executions>
12462
</plugin>
12563
<plugin>
12664
<groupId>org.apache.maven.plugins</groupId>
12765
<artifactId>maven-javadoc-plugin</artifactId>
128-
<version>3.0.1</version>
129-
<executions>
130-
<execution>
131-
<id>attach-javadocs</id>
132-
<goals>
133-
<goal>jar</goal>
134-
</goals>
135-
</execution>
136-
</executions>
13766
</plugin>
13867
<plugin>
13968
<groupId>org.apache.maven.plugins</groupId>
14069
<artifactId>maven-surefire-plugin</artifactId>
141-
<version>2.22.0</version>
14270
</plugin>
14371
<plugin>
14472
<groupId>org.jacoco</groupId>
14573
<artifactId>jacoco-maven-plugin</artifactId>
146-
<version>0.8.1</version>
147-
<executions>
148-
<execution>
149-
<id>prepare-agent</id>
150-
<goals>
151-
<goal>prepare-agent</goal>
152-
</goals>
153-
</execution>
154-
</executions>
15574
</plugin>
15675
<plugin>
15776
<groupId>org.eluder.coveralls</groupId>
15877
<artifactId>coveralls-maven-plugin</artifactId>
159-
<version>4.3.0</version>
16078
</plugin>
16179
<plugin>
16280
<groupId>com.github.wvengen</groupId>
@@ -195,43 +113,10 @@
195113
<plugin>
196114
<groupId>org.apache.maven.plugins</groupId>
197115
<artifactId>maven-jarsigner-plugin</artifactId>
198-
<version>1.4</version>
199-
<executions>
200-
<execution>
201-
<id>sign</id>
202-
<goals>
203-
<goal>sign</goal>
204-
</goals>
205-
</execution>
206-
</executions>
207-
<configuration>
208-
<skip>false</skip> <!-- set this to true if fail because of missing credentials -->
209-
<keystore>keystore.jks</keystore>
210-
<alias>pfopensource</alias>
211-
<storepass>${env.OPENSOURCE_PROJECTS_KS_PW}</storepass>
212-
<keypass>${env.OPENSOURCE_PROJECTS_KEY_PW}</keypass>
213-
</configuration>
214116
</plugin>
215117
<plugin>
216118
<groupId>net.nicoulaj.maven.plugins</groupId>
217119
<artifactId>checksum-maven-plugin</artifactId>
218-
<version>1.6</version>
219-
<executions>
220-
<execution>
221-
<goals>
222-
<goal>artifacts</goal>
223-
</goals>
224-
</execution>
225-
</executions>
226-
<configuration>
227-
<algorithms>
228-
<algorithm>SHA-256</algorithm>
229-
</algorithms>
230-
<shasumSummary>true</shasumSummary>
231-
<shasumSummaryFile>checksum-sha256.txt</shasumSummaryFile>
232-
<attachChecksums>false</attachChecksums>
233-
<quiet>false</quiet>
234-
</configuration>
235120
</plugin>
236121
</plugins>
237122
</build>
@@ -241,7 +126,6 @@
241126
<dependency>
242127
<groupId>junit</groupId>
243128
<artifactId>junit</artifactId>
244-
<version>4.12</version>
245129
<scope>test</scope>
246130
</dependency>
247131
<dependency>

0 commit comments

Comments
 (0)