fix bad inspections like trailing comma

add test for trailing comma

Author: patricklx

src/main/kotlin/com/emberjs/glint/GlintLanguageServiceFileEditorListener.kt

@@ -1,8 +1,14 @@
 package com.emberjs.glint
 
+import com.emberjs.gts.GjsLanguage
+import com.emberjs.gts.GtsFileViewProvider
+import com.emberjs.gts.GtsLanguage
+import com.intellij.codeInsight.daemon.impl.analysis.FileHighlightingSetting
+import com.intellij.codeInsight.daemon.impl.analysis.HighlightingSettingsPerFile
 import com.intellij.openapi.fileEditor.FileEditorManager
 import com.intellij.openapi.fileEditor.FileEditorManagerListener
 import com.intellij.openapi.vfs.VirtualFile
+import com.intellij.psi.PsiManager
 
 class GlintLanguageServiceFileEditorListener : FileEditorManagerListener {
     override fun fileOpened(source: FileEditorManager, file: VirtualFile) {

src/main/kotlin/com/emberjs/gts/GtsSupport.kt

@@ -13,6 +13,7 @@ import com.emberjs.index.EmberNameIndex
 import com.emberjs.resolver.EmberName
 import com.emberjs.utils.EmberUtils
 import com.emberjs.utils.ifTrue
+import com.intellij.extapi.psi.PsiFileBase
 import com.intellij.formatting.*
 import com.intellij.formatting.templateLanguages.DataLanguageBlockWrapper
 import com.intellij.lang.*
@@ -25,9 +26,11 @@ import com.intellij.lang.javascript.*
 import com.intellij.lang.javascript.config.JSImportResolveContext
 import com.intellij.lang.javascript.dialects.ECMA6ParserDefinition
 import com.intellij.lang.javascript.dialects.TypeScriptParserDefinition
+import com.intellij.lang.javascript.ecmascript6.TypeScriptAnnotatingVisitor
 import com.intellij.lang.javascript.editing.JavascriptCommenter
 import com.intellij.lang.javascript.formatter.JavascriptFormattingModelBuilder
 import com.intellij.lang.javascript.highlighting.JSHighlighter
+import com.intellij.lang.javascript.highlighting.JSSemanticHighlightingVisitor
 import com.intellij.lang.javascript.index.IndexedFileTypeProvider
 import com.intellij.lang.javascript.modules.JSImportCandidateDescriptor
 import com.intellij.lang.javascript.modules.JSImportPlaceInfo
@@ -41,6 +44,9 @@ import com.intellij.lang.javascript.psi.*
 import com.intellij.lang.javascript.psi.ecmal4.JSClass
 import com.intellij.lang.javascript.psi.impl.JSFileImpl
 import com.intellij.lang.javascript.types.JSFileElementType
+import com.intellij.lang.javascript.validation.JSAnnotatingVisitor
+import com.intellij.lang.javascript.validation.JSAnnotator
+import com.intellij.lang.javascript.validation.TypeScriptKeywordHighlighterVisitor
 import com.intellij.lang.typescript.tsconfig.*
 import com.intellij.lang.xml.XMLLanguage
 import com.intellij.lang.xml.XmlFormattingModel
@@ -49,7 +55,6 @@ import com.intellij.lexer.Lexer
 import com.intellij.lexer.LookAheadLexer
 import com.intellij.openapi.editor.Document
 import com.intellij.openapi.editor.Editor
-import com.intellij.openapi.editor.actions.lists.TrailingComma
 import com.intellij.openapi.editor.colors.EditorColorsScheme
 import com.intellij.openapi.editor.ex.util.LayerDescriptor
 import com.intellij.openapi.editor.ex.util.LayeredLexerEditorHighlighter
@@ -58,6 +63,7 @@ import com.intellij.openapi.fileTypes.*
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.util.IconLoader
 import com.intellij.openapi.util.Key
+import com.intellij.openapi.util.Pair
 import com.intellij.openapi.util.TextRange
 import com.intellij.openapi.util.text.StringUtil
 import com.intellij.openapi.vfs.VirtualFile
@@ -72,14 +78,19 @@ import com.intellij.psi.formatter.xml.XmlFormattingPolicy
 import com.intellij.psi.formatter.xml.XmlTagBlock
 import com.intellij.psi.html.HtmlTag
 import com.intellij.psi.impl.source.PsiFileImpl
+import com.intellij.psi.impl.source.StubbedSpine
 import com.intellij.psi.impl.source.html.HtmlDocumentImpl
 import com.intellij.psi.impl.source.html.HtmlFileImpl
 import com.intellij.psi.impl.source.resolve.reference.impl.PsiMultiReference
+import com.intellij.psi.impl.source.tree.FileElement
 import com.intellij.psi.impl.source.tree.LeafElement
 import com.intellij.psi.impl.source.tree.PsiWhiteSpaceImpl
 import com.intellij.psi.search.FilenameIndex
 import com.intellij.psi.search.GlobalSearchScope
 import com.intellij.psi.search.ProjectScope
+import com.intellij.psi.stubs.LanguageStubDescriptor
+import com.intellij.psi.stubs.StubElement
+import com.intellij.psi.stubs.StubTree
 import com.intellij.psi.templateLanguages.*
 import com.intellij.psi.tree.IElementType
 import com.intellij.psi.tree.IFileElementType
@@ -89,6 +100,7 @@ import com.intellij.refactoring.suggested.endOffset
 import com.intellij.refactoring.suggested.startOffset
 import com.intellij.util.Processor
 import com.intellij.xml.template.formatter.AbstractXmlTemplateFormattingModelBuilder
+import org.jetbrains.annotations.Unmodifiable
 import java.util.function.Predicate
 import javax.swing.Icon
 
@@ -99,6 +111,7 @@ val JS: JSLanguageDialect = JavaScriptSupportLoader.ECMA_SCRIPT_6
 
 open class GtsLanguage(val lang: JSLanguageDialect = TS, id: String ="Gts") : Language(lang, id) {
     public var fileElementType: JSFileElementType? = null
+
     override fun <T : Any?> getUserData(key: Key<T>): T? {
         if (key.toString() == "js.file.element.type") {
             return fileElementType as T?
@@ -114,7 +127,7 @@ open class GtsLanguage(val lang: JSLanguageDialect = TS, id: String ="Gts") : La
     }
 
     companion object {
-        val INSTANCE = GtsLanguage()
+        val INSTANCE = GtsLanguage(TS)
     }
 }
 
@@ -135,8 +148,6 @@ class GtsFile(viewProvider: FileViewProvider?, val isJS: Boolean =false)
     override fun toString(): String {
         return "GTS File"
     }
-
-
 }
 
 
@@ -397,6 +408,9 @@ class GtsFileType : LanguageFileType(GtsLanguage.INSTANCE) {
         if (other == TypeScriptFileType) {
             return true
         }
+        if (other == JavaScriptFileType) {
+            return true
+        }
         return super.equals(other)
     }
 

src/test/kotlin/com/emberjs/gts/GtsFileTest.kt

@@ -3,7 +3,10 @@ package com.emberjs.hbs
 import com.emberjs.gts.GjsFileType
 import com.emberjs.gts.GtsFileType
 import com.intellij.codeInsight.daemon.impl.HighlightInfo
+import com.intellij.lang.javascript.BasicDialectDetector
+import com.intellij.lang.javascript.JavaScriptSupportLoader
 import com.intellij.lang.javascript.inspections.ES6UnusedImportsInspection
+import com.intellij.lang.javascript.inspections.JSLastCommaInObjectLiteralInspection
 import com.intellij.lang.javascript.inspections.JSUnusedGlobalSymbolsInspection
 import com.intellij.lang.javascript.inspections.JSUnusedLocalSymbolsInspection
 import com.intellij.lang.javascript.psi.impl.JSFileImpl
@@ -121,4 +124,27 @@ class GtsFileTest : BasePlatformTestCase() {
         TestCase.assertTrue(highlightInfos.first().description.contains("quux"))
         TestCase.assertTrue(highlightInfos.last().description.contains("qux"))
     }
+
+    @Test
+    fun testGtsTrailingCommaAllowed() {
+        val gts = """
+            const a = {
+                a: 1,
+                b: 2,
+            }
+        """.trimIndent()
+        myFixture.addFileToProject("main.gts", gts)
+        myFixture.configureByFile("main.gts")
+        myFixture.enableInspections(JSLastCommaInObjectLiteralInspection())
+        try {
+            CodeInsightTestFixtureImpl.ensureIndexesUpToDate(project)
+        } catch (exception: Exception) {
+
+        }
+
+        val highlighting = myFixture.doHighlighting()
+        System.out.println(highlighting)
+        val noCommaAllowed = highlighting.filter { it.description?.contains("comma") == true }
+        TestCase.assertEquals(noCommaAllowed.toString(), 0, noCommaAllowed.size)
+    }
 }