Skip to content

Commit 33e15db

Browse files
authored
upgrade intellij (#200)
* upgrade intellij * use JavaScriptBundle * fix
1 parent fd79a85 commit 33e15db

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

build.gradle.kts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ plugins {
2222

2323

2424
group = "com.emberjs"
25-
version = "2024.3.4"
25+
version = "2024.3.5"
2626

2727
dependencies {
2828
testImplementation("org.jetbrains.kotlin:kotlin-test")
@@ -35,13 +35,13 @@ dependencies {
3535
// and https://www.jetbrains.com/intellij-repository/snapshots/
3636
// https://plugins.jetbrains.com/plugin/6884-handlebars-mustache/versions/stable
3737
intellijPlatform {
38-
plugins(listOf("com.dmarcotte.handlebars:242.21829.3"))
38+
plugins(listOf("com.dmarcotte.handlebars:243.21565.122"))
3939
bundledPlugins(listOf("JavaScript", "com.intellij.css", "org.jetbrains.plugins.yaml"))
4040
pluginVerifier()
4141
zipSigner()
4242
instrumentationTools()
4343
testFramework(TestFrameworkType.Platform)
44-
create(IntelliJPlatformType.IntellijIdeaUltimate, "2024.2.4")
44+
create(IntelliJPlatformType.IntellijIdeaUltimate, "2024.3")
4545
}
4646
}
4747

src/main/kotlin/com/emberjs/glint/GlintLanguageService.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import com.intellij.lang.javascript.integration.JSAnnotationError
2020
import com.intellij.lang.javascript.integration.JSAnnotationError.*
2121
import com.intellij.lang.javascript.psi.JSFile
2222
import com.intellij.lang.javascript.psi.JSFunctionType
23+
import com.intellij.lang.javascript.service.JSLanguageService
2324
import com.intellij.lang.javascript.service.JSLanguageServiceProvider
2425
import com.intellij.lang.parameterInfo.CreateParameterInfoContext
2526
import com.intellij.lang.typescript.compiler.TypeScriptService
@@ -56,8 +57,8 @@ class GlintLanguageServiceProvider(val project: Project) : JSLanguageServiceProv
5657

5758
override fun getService(file: VirtualFile) = allServices.firstOrNull()
5859

59-
override fun getAllServices() =
60-
if (EmberUtils.isEnabledEmberProject(project)) listOf(GlintTypeScriptService.getInstance(project)) else emptyList()
60+
override val allServices: List<GlintTypeScriptService>
61+
get() = if (EmberUtils.isEnabledEmberProject(project)) listOf(GlintTypeScriptService.getInstance(project)) else emptyList()
6162
}
6263

6364

src/main/kotlin/com/emberjs/hbs/linter/ember-template-lint/TemplateLintEnabler.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import com.intellij.javascript.nodejs.PackageJsonData
2-
import com.intellij.lang.javascript.JSBundle
2+
import com.intellij.lang.javascript.JavaScriptBundle
33
import com.intellij.lang.javascript.linter.JSLinterGuesser
44
import com.intellij.lang.javascript.linter.JSLinterUtil
55
import com.intellij.notification.Notification
@@ -62,15 +62,15 @@ class TemplateLintEnabler : DirectoryProjectConfigurator {
6262
}
6363

6464
fun notifyEnabled(project: Project, dependency: String) {
65-
val message = JSBundle.message("js.linter.guesser.linter.enabled.because.of.package.json.section",
65+
val message = JavaScriptBundle.message("js.linter.guesser.linter.enabled.because.of.package.json.section",
6666
"TemplateLint",
6767
dependency)
6868

6969
JSLinterUtil.NOTIFICATION_GROUP.createNotification(message, MessageType.INFO).addAction(object : NotificationAction("Disable TemplateLint") {
7070
override fun actionPerformed(e: AnActionEvent, notification: Notification) {
7171
JSLinterGuesser.LOG.info("TemplateLint disabled by user")
7272
templateLintEnabled(project, false)
73-
JSLinterUtil.NOTIFICATION_GROUP.createNotification(JSBundle.message("js.linter.guesser.linter.disabled", "TemplateLint"), MessageType.INFO).notify(project)
73+
JSLinterUtil.NOTIFICATION_GROUP.createNotification(JavaScriptBundle.message("js.linter.guesser.linter.disabled", "TemplateLint"), MessageType.INFO).notify(project)
7474
}
7575
}).notify(project)
7676
}

0 commit comments

Comments
 (0)