fix empty glint config (#227)

* allow empty package

* allow empty package for glint config

* fix

* fix

* fix

Author: patricklx

src/main/kotlin/com/emberjs/gts/GlintExternalAnnotator.kt

@@ -16,6 +16,7 @@ import com.intellij.lang.annotation.AnnotationHolder
 import com.intellij.lang.javascript.integration.JSAnnotationError
 import com.intellij.lang.javascript.linter.*
 import com.intellij.lang.javascript.psi.JSFile
+import com.intellij.openapi.components.Service
 import com.intellij.openapi.components.State
 import com.intellij.openapi.components.Storage
 import com.intellij.openapi.options.OptionsBundle
@@ -66,8 +67,7 @@ data class GlintState(
     private val myPackageRef: NodePackageRef = NodePackageRef.create(myTemplateLintPackage)
 
     override fun withLinterPackage(packageRef: NodePackageRef): GlintState {
-        val constantPackage = packageRef.constantPackage
-            ?: throw AssertionError(this.javaClass.simpleName + " does not support non-constant package refs")
+        val constantPackage = packageRef.constantPackage ?: return DEFAULT
 
         return copy(myTemplateLintPackage = constantPackage)
     }
@@ -93,6 +93,7 @@ data class GlintState(
 }
 
 
+@Service(Service.Level.PROJECT)
 @State(name = "GlintConfiguration", storages = [Storage("emberLinters/glint.xml")])
 class GlintConfiguration(project: Project) : JSLinterConfiguration<GlintState>(project) {
     private val myPackage: JSLinterPackage = JSLinterPackage(project, "@glint/core")
@@ -103,7 +104,10 @@ class GlintConfiguration(project: Project) : JSLinterConfiguration<GlintState>(p
     override fun loadPrivateSettings(state: GlintState): GlintState {
         this.myPackage.readOrDetect()
         val constantPackage = myPackage.getPackage().constantPackage
-            ?: throw AssertionError("glint does not support non-constant node package refs")
+
+        if (constantPackage == null) {
+            return defaultState
+        }
 
         return state.copy(
             myInterpreterRef = this.myPackage.interpreter,
@@ -245,4 +249,4 @@ class GlintExternalAnnotator : JSLinterExternalAnnotator<GlintState>(true) {
     override fun getInspectionClass(): Class<out JSLinterInspection> {
         return GlintInspection::class.java
     }
-}
+}

src/main/kotlin/com/emberjs/hbs/linter/ember-template-lint/TemplateLintConfiguration.kt

@@ -16,9 +16,15 @@ class TemplateLintConfiguration(project: Project) : JSLinterConfiguration<Templa
     override fun loadPrivateSettings(state: TemplateLintState): TemplateLintState {
         this.myPackage.readOrDetect()
 
+        val constantPackage = this.myPackage.getPackage().constantPackage
+
+        if (constantPackage == null) {
+            return defaultState
+        }
+
         return state.copy(
                 myInterpreterRef = this.myPackage.interpreter,
-                myTemplateLintPackage = this.myPackage.getPackage().constantPackage
+                myTemplateLintPackage = constantPackage
         )
     }
 

src/main/kotlin/com/emberjs/hbs/linter/ember-template-lint/TemplateLintState.kt

@@ -6,15 +6,14 @@ import com.intellij.lang.javascript.linter.JSNpmLinterState
 
 data class TemplateLintState(
         private val myInterpreterRef: NodeJsInterpreterRef,
-        private val myTemplateLintPackage: NodePackage?,
+        private val myTemplateLintPackage: NodePackage,
         val isRunOnSave: Boolean,
 ) : JSNpmLinterState<TemplateLintState> {
 
-    private val myPackageRef: NodePackageRef? = myTemplateLintPackage?.let { NodePackageRef.create(it) }
+    private val myPackageRef: NodePackageRef = myTemplateLintPackage.let { NodePackageRef.create(it) }
 
     override fun withLinterPackage(packageRef: NodePackageRef): TemplateLintState {
-        val constantPackage = packageRef.constantPackage
-                ?: throw AssertionError(this.javaClass.simpleName + " does not support non-constant package refs")
+        val constantPackage = packageRef.constantPackage ?: return DEFAULT
 
         return copy(myTemplateLintPackage = constantPackage)
     }
@@ -24,12 +23,12 @@ data class TemplateLintState(
     }
 
     override fun getNodePackageRef(): NodePackageRef {
-        return this.myPackageRef!!
+        return this.myPackageRef
     }
 
     val templateLintPackage: NodePackage
         get() {
-            return this.myTemplateLintPackage!!
+            return this.myTemplateLintPackage
         }
 
     companion object {

src/main/resources/META-INF/plugin.xml

@@ -182,7 +182,6 @@
         <annotator language="Handlebars" implementationClass="com.emberjs.gts.HbLintAnnotator"/>
         <annotator language="HTML" implementationClass="com.emberjs.gts.HbLintAnnotator"/>
         <projectService serviceImplementation="TemplateLintConfiguration"/>
-        <projectService serviceImplementation="com.emberjs.gts.GlintConfiguration"/>
         <projectService serviceImplementation="TemplateLintConfigFileChangeTracker"/>
         <projectService serviceImplementation="TemplateLintUnsavedConfigFileManager"/>
         <projectService serviceImplementation="com.emberjs.glint.GlintTypeScriptService"/>