Removed invariant check from accessors

Author: patrickroberts

package.json

@@ -1,6 +1,6 @@
 {
   "name": "complex-js",
-  "version": "7.1.0",
+  "version": "7.1.1",
   "description": "Complex math module for JavaScript",
   "repository": "github:patrickroberts/complex",
   "homepage": "https://patrickroberts.github.io/complex/",

src/accessors/__mocks__/abs.ts

@@ -1,5 +1,5 @@
 import Complex from '../../complex';
 
-const abs = (_: typeof Complex, z: Complex): number => z._abs;
+const abs = (z: Complex): number => z._abs;
 
 export default jest.fn(abs);

src/accessors/__mocks__/arg.ts

@@ -1,5 +1,5 @@
 import Complex from '../../complex';
 
-const arg = (_: typeof Complex, z: Complex): number => z._arg;
+const arg = (z: Complex): number => z._arg;
 
 export default jest.fn(arg);

src/accessors/__mocks__/imag.ts

@@ -1,5 +1,5 @@
 import Complex from '../../complex';
 
-const imag = (_: typeof Complex, z: Complex): number => z._imag;
+const imag = (z: Complex): number => z._imag;
 
 export default jest.fn(imag);

src/accessors/__mocks__/real.ts

@@ -1,5 +1,5 @@
 import Complex from '../../complex';
 
-const real = (_: typeof Complex, z: Complex): number => z._real;
+const real = (z: Complex): number => z._real;
 
 export default jest.fn(real);

src/accessors/abs.test.ts

@@ -2,16 +2,14 @@ import _ from '../__fixtures__/any/number';
 import mock from '../__fixtures__/mock';
 
 import Complex from '../complex';
-import { Component, invariant } from '../internal';
+import { Component } from '../internal';
 import abs from '../math/abs';
 import sut from './abs';
 
 jest.mock('../complex');
-jest.mock('../internal/invariant');
 jest.mock('../math/abs');
 
 beforeEach(() => {
-  mock(invariant).mockClear();
   mock(abs).mockClear();
 });
 
@@ -24,9 +22,8 @@ test.each<[Component]>([
   const expected = {} as number;
   const z = new Complex(_, _, expected, _, testHas);
 
-  const actual = sut(Complex, z);
+  const actual = sut(z);
 
-  expect(invariant).toHaveBeenCalledWith(Complex, z);
   expect(abs).not.toHaveBeenCalled();
   expect(z._abs).toBe(expected);
   expect(z._has).toBe(testHas);
@@ -44,26 +41,10 @@ test.each<[Component]>([
 
   mock(abs).mockReturnValueOnce(expected);
 
-  const actual = sut(Complex, z);
+  const actual = sut(z);
 
-  expect(invariant).toHaveBeenCalledWith(Complex, z);
   expect(abs).toHaveBeenCalledWith(testReal, testImag);
   expect(z._abs).toBe(expected);
   expect(z._has).toBe(testHas | Component.ABS);
   expect(actual).toBe(expected);
 });
-
-it('should not modify computed value if invariant is violated', () => {
-  const z = {} as Complex;
-  const expected = new TypeError();
-
-  mock(invariant).mockImplementationOnce(() => {
-    throw expected;
-  });
-
-  expect(() => sut(Complex, z)).toThrowError(expected);
-  expect(invariant).toHaveBeenCalledWith(Complex, z);
-  expect(abs).not.toHaveBeenCalled();
-  expect(z).not.toHaveProperty('_abs');
-  expect(z).not.toHaveProperty('_has');
-});

src/accessors/abs.ts

@@ -1,10 +1,8 @@
 import Complex from '../complex';
-import { Component, invariant } from '../internal';
+import { Component } from '../internal';
 import _abs from '../math/abs';
 
-const abs = (Ctor: typeof Complex, z: Complex): number => {
-  invariant(Ctor, z);
-
+const abs = (z: Complex): number => {
   if (!(z._has & Component.ABS)) {
     z._abs = _abs(z._real, z._imag);
     z._has |= Component.ABS;

src/accessors/arg.test.ts

@@ -2,17 +2,15 @@ import _ from '../__fixtures__/any/number';
 import mock from '../__fixtures__/mock';
 
 import Complex from '../complex';
-import { Component, invariant } from '../internal';
+import { Component } from '../internal';
 import arg from '../math/arg';
 import sut from './arg';
 
 jest.mock('../complex');
-jest.mock('../internal/invariant');
 jest.mock('../internal/principal');
 jest.mock('../math/arg');
 
 beforeEach(() => {
-  mock(invariant).mockClear();
   mock(arg).mockClear();
 });
 
@@ -25,9 +23,8 @@ test.each<[Component]>([
   const expected = {} as number;
   const z = new Complex(_, _, _, expected, testHas);
 
-  const actual = sut(Complex, z);
+  const actual = sut(z);
 
-  expect(invariant).toHaveBeenCalledWith(Complex, z);
   expect(arg).not.toHaveBeenCalled();
   expect(z._arg).toBe(expected);
   expect(z._has).toBe(testHas);
@@ -45,26 +42,10 @@ test.each<[Component]>([
 
   mock(arg).mockReturnValueOnce(expected);
 
-  const actual = sut(Complex, z);
+  const actual = sut(z);
 
-  expect(invariant).toHaveBeenCalledWith(Complex, z);
   expect(arg).toHaveBeenCalledWith(testReal, testImag);
   expect(z._arg).toBe(expected);
   expect(z._has).toBe(testHas | Component.ARG);
   expect(actual).toBe(expected);
 });
-
-it('should not modify computed value if invariant is violated', () => {
-  const z = {} as Complex;
-  const expected = new TypeError();
-
-  mock(invariant).mockImplementationOnce(() => {
-    throw expected;
-  });
-
-  expect(() => sut(Complex, z)).toThrowError(expected);
-  expect(invariant).toHaveBeenCalledWith(Complex, z);
-  expect(arg).not.toHaveBeenCalled();
-  expect(z).not.toHaveProperty('_arg');
-  expect(z).not.toHaveProperty('_has');
-});

src/accessors/arg.ts

@@ -1,10 +1,8 @@
 import Complex from '../complex';
-import { Component, invariant } from '../internal';
+import { Component } from '../internal';
 import _arg from '../math/arg';
 
-const arg = (Ctor: typeof Complex, z: Complex): number => {
-  invariant(Ctor, z);
-
+const arg = (z: Complex): number => {
   if (!(z._has & Component.ARG)) {
     z._arg = _arg(z._real, z._imag);
     z._has |= Component.ARG;

src/accessors/imag.test.ts

@@ -2,17 +2,15 @@ import _ from '../__fixtures__/any/number';
 import mock from '../__fixtures__/mock';
 
 import Complex from '../complex';
-import { Component, invariant } from '../internal';
+import { Component } from '../internal';
 import imag from '../math/imag';
 import sut from './imag';
 
 jest.mock('../complex');
-jest.mock('../internal/invariant');
 jest.mock('../internal/principal');
 jest.mock('../math/imag');
 
 beforeEach(() => {
-  mock(invariant).mockClear();
   mock(imag).mockClear();
 });
 
@@ -25,9 +23,8 @@ test.each<[Component]>([
   const expected = {} as number;
   const z = new Complex(_, expected, _, _, testHas);
 
-  const actual = sut(Complex, z);
+  const actual = sut(z);
 
-  expect(invariant).toHaveBeenCalledWith(Complex, z);
   expect(imag).not.toHaveBeenCalled();
   expect(z._imag).toBe(expected);
   expect(z._has).toBe(testHas);
@@ -45,26 +42,10 @@ test.each<[Component]>([
 
   mock(imag).mockReturnValueOnce(expected);
 
-  const actual = sut(Complex, z);
+  const actual = sut(z);
 
-  expect(invariant).toHaveBeenCalledWith(Complex, z);
   expect(imag).toHaveBeenCalledWith(testAbs, testArg);
   expect(z._imag).toBe(expected);
   expect(z._has).toBe(testHas | Component.IMAG);
   expect(actual).toBe(expected);
 });
-
-it('should not modify computed value if invariant is violated', () => {
-  const z = {} as Complex;
-  const expected = new TypeError();
-
-  mock(invariant).mockImplementationOnce(() => {
-    throw expected;
-  });
-
-  expect(() => sut(Complex, z)).toThrowError(expected);
-  expect(invariant).toHaveBeenCalledWith(Complex, z);
-  expect(imag).not.toHaveBeenCalled();
-  expect(z).not.toHaveProperty('_imag');
-  expect(z).not.toHaveProperty('_has');
-});