Only visible attributes should be rendered

Author: patrickschur

src/Html5Gen/Html5Gen.php

@@ -196,7 +196,11 @@ public static function __callStatic($name, $arguments)
                     $attrName = $attrValue;
                 }
 
-                $elem->setAttribute($attrName, $attrValue);
+                if (self::isVisible($elem->tagName, $attrName, $attrValue) ||
+                    $attrValue != false && $attrValue != "false")
+                {
+                    $elem->setAttribute($attrName, $attrValue);
+                }
             }
         }
 
@@ -208,7 +212,7 @@ public static function __callStatic($name, $arguments)
         if (isset($arguments[1]) && is_callable($arguments[1]))
         {
             self::$parentNodes[] = $elem;
-            $retVal = $arguments[1]();
+            $retVal = $arguments[1]($elem);
 
             if ($retVal instanceof \Traversable)
             {
@@ -231,6 +235,21 @@ public static function __callStatic($name, $arguments)
         return $elem->ownerDocument->saveHTML($elem);
     }
 
+    private static function isVisible($elem, $attrName, $attrValue)
+    {
+        $html = new \DOMDocument();
+
+        $elem = $html->createElement($elem);
+        $elem->setAttribute($attrName, $attrValue);
+        $html->appendChild($elem);
+
+        if ($attrValue && strpos($html->saveHTML(), $attrValue) !== false) {
+            return true;
+        }
+
+        return false;
+    }
+
     /**
      * @param string $tag
      * @param array &$attrs
@@ -721,4 +740,4 @@ public function __toString()
     {
         return self::$document->saveHTML();
     }
-}
+}