Skip to content
This repository was archived by the owner on Dec 10, 2019. It is now read-only.

Commit b9e8139

Browse files
committed
Merge branch 'dev' into pattern-engines
2 parents 600b990 + 717e139 commit b9e8139

20 files changed

+1091
-1105
lines changed

.eslintrc

Lines changed: 50 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -5,70 +5,79 @@
55
},
66
"globals": {},
77
"rules": {
8-
"block-scoped-var": 2,
8+
"block-scoped-var": 0,
99
"camelcase": 0,
10-
"curly": [
11-
2,
12-
"all"
13-
],
14-
"dot-notation": [
15-
1,
16-
{
17-
"allowKeywords": true
18-
}
19-
],
20-
"eqeqeq": [
21-
2,
22-
"allow-null"
23-
],
24-
"global-strict": [
25-
0,
26-
"never"
27-
],
10+
"comma-spacing": [1, {"before": false, "after": true}],
11+
"consistent-return": 2,
12+
"curly": [2, "all"],
13+
"dot-notation": [1, { "allowKeywords": true }],
14+
"eqeqeq": [2, "allow-null"],
15+
"global-strict": [0, "never"],
2816
"guard-for-in": 2,
29-
"key-spacing": [
30-
0
31-
],
17+
"indent": [2, 2, {"SwitchCase": 1, "VariableDeclarator": 1}],
18+
"lines-around-comment": [2, {
19+
"beforeBlockComment": true,
20+
"beforeLineComment": true,
21+
"allowBlockStart": true,
22+
"allowObjectStart": true,
23+
"allowArrayStart": true
24+
}],
25+
"key-spacing": 0,
26+
"keyword-spacing": 1,
3227
"new-cap": 0,
28+
"no-alert": 2,
3329
"no-bitwise": 2,
3430
"no-caller": 2,
35-
"no-cond-assign": [
36-
2,
37-
"except-parens"
38-
],
31+
"no-cond-assign": [2, "except-parens"],
3932
"no-debugger": 2,
33+
"no-dupe-args": 2,
34+
"no-dupe-keys": 2,
4035
"no-empty": 2,
4136
"no-eval": 2,
4237
"no-extend-native": 2,
38+
"no-extra-bind": 2,
4339
"no-extra-parens": 0,
40+
"no-extra-semi": 2,
41+
"no-func-assign": 2,
42+
"no-implied-eval": 2,
43+
"no-invalid-regexp": 2,
4444
"no-irregular-whitespace": 1,
4545
"no-iterator": 2,
4646
"no-loop-func": 2,
4747
"no-mixed-requires": 0,
4848
"no-multi-str": 2,
49-
"no-multi-spaces": 0,
49+
"no-multi-spaces": 1,
50+
"no-native-reassign": 2,
5051
"no-new": 2,
52+
"no-param-reassign": 1,
5153
"no-proto": 2,
54+
"no-redeclare": 0,
5255
"no-script-url": 2,
56+
"no-self-assign": 2,
57+
"no-self-compare": 2,
5358
"no-sequences": 2,
5459
"no-shadow": 2,
5560
"no-undef": 2,
56-
"no-underscore-dangle": 1,
57-
"no-unused-vars": 2,
61+
"no-underscore-dangle": 0,
62+
"no-unreachable": 1,
63+
"no-unused-vars": 1,
64+
"no-use-before-define": 1,
65+
"no-useless-call": 2,
66+
"no-useless-concat": 2,
5867
"no-with": 2,
59-
"quotes": [
60-
0,
61-
"single"
62-
],
63-
"semi": [
64-
0,
65-
"never"
66-
],
68+
"quotes": [0, "single"],
69+
"radix": 2,
70+
"semi": [0, "never"],
6771
"strict": 0,
72+
"space-before-blocks": 1,
73+
"space-before-function-paren": [1, {
74+
"anonymous": "always",
75+
"named": "never"
76+
}],
77+
"space-in-parens": [1, "never"],
78+
"space-infix-ops": 1,
6879
"valid-typeof": 2,
69-
"wrap-iife": [
70-
2,
71-
"inside"
72-
]
80+
"vars-on-top": 0,
81+
"wrap-iife": [2, "inside"]
7382
}
7483
}

.github/CONTRIBUTING.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Contributing to Patternlab Node
2-
If you'd like to contribute to Pattern Lab Node, please do so! There is always a lot of ground to cover and something for your wheelhouse.
2+
If you'd like to contribute to Pattern Lab Node, please do so! There is always a lot of ground to cover and something for your wheelhouse.
33

44
No pull request is too small. Check out any [up for grabs issues](https://github.com/pattern-lab/patternlab-node/labels/up%20for%20grabs) as a good way to get your feet wet, or add some more unit tests.
55

@@ -9,4 +9,7 @@ No pull request is too small. Check out any [up for grabs issues](https://github
99
3. If you can, add some unit tests using the existing patterns in the `./test` directory
1010

1111
##Coding style
12-
Regarding code style like indentation and whitespace, follow the conventions you see used in the source already. Add enough source code comments to help the next person.
12+
Two files combine within the project to define and maintain our coding style.
13+
14+
* The `.editorconfig` controls spaces / tabs within supported editors. Check out their [site](http://editorconfig.org/).
15+
* The `.eslintrc` defines our javascript standards. Some editors will evaluate this real-time - otherwise it's run using `grunt|gulp build`

.jslintrc

Lines changed: 0 additions & 36 deletions
This file was deleted.

0 commit comments

Comments
 (0)