Skip to content

Commit 04409d3

Browse files
committed
update patternlab.partials[key] if an extended template changes
added as part of #240
1 parent b45a809 commit 04409d3

7 files changed

+50
-23
lines changed

builder/list_item_hunter.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,9 @@
100100
var repeatingBlock = pattern.extendedTemplate.substring(pattern.extendedTemplate.indexOf(liMatch), pattern.extendedTemplate.indexOf(end) + end.length);
101101
pattern.extendedTemplate = pattern.extendedTemplate.replace(repeatingBlock, repeatedBlockHtml);
102102

103+
//update the extendedTemplate in the partials object in case this pattern is consumed later
104+
patternlab.partials[pattern.key] = pattern.extendedTemplate;
105+
103106
});
104107
}
105108
}

builder/parameter_hunter.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,9 @@
6161

6262
//remove the parameter from the partial and replace it with the rendered partial + paramData
6363
pattern.extendedTemplate = pattern.extendedTemplate.replace(pMatch, renderedPartial);
64+
65+
//update the extendedTemplate in the partials object in case this pattern is consumed later
66+
patternlab.partials[pattern.key] = pattern.extendedTemplate;
6467
});
6568
}
6669
}

builder/pattern_assembler.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,8 @@
233233

234234
currentPattern.extendedTemplate = currentPattern.extendedTemplate.replace(foundPatternPartials[i], partialPattern.extendedTemplate);
235235

236+
//update the extendedTemplate in the partials object in case this pattern is consumed later
237+
patternlab.partials[currentPattern.key] = currentPattern.extendedTemplate;
236238
}
237239

238240
} else{

builder/style_modifier_hunter.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@
2828

2929
//replace the stylemodifier placeholder with the class name
3030
pattern.extendedTemplate = pattern.extendedTemplate.replace(/{{[ ]?styleModifier[ ]?}}/i, styleModifier);
31+
32+
//update the extendedTemplate in the partials object in case this pattern is consumed later
33+
patternlab.partials[pattern.key] = pattern.extendedTemplate;
3134
}
3235
}
3336

test/list_item_hunter_tests.js

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@
3636
"link": {},
3737
"partials": []
3838
},
39-
"config": {"debug": false}
39+
"config": {"debug": false},
40+
"partials" : {}
4041
};
4142

4243
var list_item_hunter = new lih();
@@ -80,7 +81,8 @@
8081
"link": {},
8182
"partials": []
8283
},
83-
"config": {"debug": false}
84+
"config": {"debug": false},
85+
"partials" : {}
8486
};
8587

8688
var list_item_hunter = new lih();
@@ -132,7 +134,8 @@
132134
"key": "test-simple",
133135
"jsonFileData" : {}
134136
}
135-
]
137+
],
138+
"partials" : {}
136139
};
137140

138141
var list_item_hunter = new lih();
@@ -199,7 +202,8 @@
199202
"jsonFileData" : {},
200203
"key": "test-bar",
201204
}
202-
]
205+
],
206+
"partials" : {}
203207
};
204208

205209
var list_item_hunter = new lih();
@@ -263,7 +267,8 @@
263267
"key": "test-simple",
264268
"jsonFileData" : {}
265269
}
266-
]
270+
],
271+
"partials" : {}
267272
};
268273

269274
var list_item_hunter = new lih();
@@ -325,7 +330,8 @@
325330
"key": "test-simple",
326331
"jsonFileData" : {}
327332
}
328-
]
333+
],
334+
"partials" : {}
329335
};
330336

331337
var list_item_hunter = new lih();
@@ -387,7 +393,8 @@
387393
"key": "test-simple",
388394
"jsonFileData" : {}
389395
}
390-
]
396+
],
397+
"partials" : {}
391398
};
392399

393400
var list_item_hunter = new lih();
@@ -414,6 +421,7 @@
414421
pl.data.link = {};
415422
pl.config.debug = false;
416423
pl.patterns = [];
424+
pl.partials = {};
417425
pl.config.patterns = { source: patterns_dir};
418426
pl.listitems = {
419427
"1": [

test/parameter_hunter_tests.js

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -26,26 +26,27 @@
2626
};
2727
var patternlab = {
2828
patterns: [
29-
{
30-
"fileName": "02-single-comment",
31-
"subdir": "01-molecules/06-components",
32-
"name": "01-molecules-06-components-02-single-comment",
33-
"patternName": "single-comment",
34-
"patternLink": "01-molecules-06-components-02-single-comment/01-molecules-06-components-02-single-comment.html",
35-
"patternGroup": "molecules",
36-
"patternSubGroup": "components",
37-
"flatPatternPath": "01-molecules-06-components",
38-
"key": "molecules-single-comment",
39-
"template": "<p>{{description}}</p>",
40-
"extendedTemplate": "<p>{{description}}</p>"
41-
}
29+
{
30+
"fileName": "02-single-comment",
31+
"subdir": "01-molecules/06-components",
32+
"name": "01-molecules-06-components-02-single-comment",
33+
"patternName": "single-comment",
34+
"patternLink": "01-molecules-06-components-02-single-comment/01-molecules-06-components-02-single-comment.html",
35+
"patternGroup": "molecules",
36+
"patternSubGroup": "components",
37+
"flatPatternPath": "01-molecules-06-components",
38+
"key": "molecules-single-comment",
39+
"template": "<p>{{description}}</p>",
40+
"extendedTemplate": "<p>{{description}}</p>"
41+
}
4242
],
4343
config: {
4444
debug: false
4545
},
4646
data: {
4747
description: 'Not a quote from a smart man'
48-
}
48+
},
49+
partials: {},
4950
};
5051

5152
var parameter_hunter = new ph();
@@ -77,6 +78,7 @@
7778
]
7879
};
7980
var patternlab = {
81+
partials: {},
8082
patterns: [
8183
{
8284
"fileName": "02-single-comment",
@@ -130,7 +132,8 @@
130132
]
131133
};
132134
var patternlab = {
133-
patterns: [
135+
partials: {},
136+
patterns: [
134137
{
135138
"fileName": "02-single-comment",
136139
"subdir": "01-molecules/06-components",
@@ -182,7 +185,8 @@
182185
]
183186
};
184187
var patternlab = {
185-
patterns: [
188+
partials: {},
189+
patterns: [
186190
{
187191
"fileName": "02-single-comment",
188192
"subdir": "01-molecules/06-components",

test/style_modifier_hunter_tests.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
'uses the partial stylemodifer to modify the patterns extendedTemplate' : function(test){
88
//arrange
99
var pl = {};
10+
pl.partials = {};
1011
pl.config = {};
1112
pl.config.debug = false;
1213

@@ -26,6 +27,7 @@
2627
'replaces style modifiers with spaces in the syntax' : function(test){
2728
//arrange
2829
var pl = {};
30+
pl.partials = {};
2931
pl.config = {};
3032
pl.config.debug = false;
3133

@@ -45,6 +47,7 @@
4547
'replaces multiple style modifiers' : function(test){
4648
//arrange
4749
var pl = {};
50+
pl.partials = {};
4851
pl.config = {};
4952
pl.config.debug = false;
5053

@@ -64,6 +67,7 @@
6467
'does not alter pattern extendedTemplate if styleModifier not found in partial' : function(test){
6568
//arrange
6669
var pl = {};
70+
pl.partials = {};
6771
pl.config = {};
6872
pl.config.debug = false;
6973

0 commit comments

Comments
 (0)