Skip to content

Commit 14797d9

Browse files
author
Brian Muenzenmeyer
committed
Merge pull request #230 from geoffp/configurable-paths-galore
Root out a few more hard-coded paths
2 parents e15062b + 31d5ff6 commit 14797d9

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

builder/patternlab.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ var patternlab_engine = function () {
9090
console.log(err);
9191
return;
9292
}
93-
pattern_assembler.process_pattern_iterative(file.substring(2), patternlab);
93+
pattern_assembler.process_pattern_iterative(path.resolve(file), patternlab);
9494
});
9595

9696
//now that all the main patterns are known, look for any links that might be within data and expand them
@@ -115,8 +115,9 @@ var patternlab_engine = function () {
115115
console.log(err);
116116
return;
117117
}
118-
pattern_assembler.process_pattern_recursive(file.substring(2), patternlab);
119-
});
118+
pattern_assembler.process_pattern_recursive(path.resolve(file), patternlab);
119+
});
120+
120121

121122
//delete the contents of config.patterns.public before writing
122123
if(deletePatternDir){

test/pattern_assembler_tests.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@
239239
return;
240240
}
241241

242-
pattern_assembler.process_pattern_iterative(file.substring(2), patternlab);
242+
pattern_assembler.process_pattern_iterative(path.resolve(file), patternlab);
243243
}
244244
);
245245

@@ -263,7 +263,7 @@
263263
return;
264264
}
265265

266-
pattern_assembler.process_pattern_recursive(file.substring(2), patternlab);
266+
pattern_assembler.process_pattern_recursive(path.resolve(file), patternlab);
267267
}
268268
);
269269

@@ -532,11 +532,12 @@
532532
var patternlab = {};
533533
//THIS IS BAD.
534534
patternlab.config = fs.readJSONSync('./config.json');
535-
patternlab.config.patterns = {source: patterns_dir};
536-
patternlab.data = fs.readJSONSync('./source/_data/data.json');
537-
patternlab.listitems = fs.readJSONSync('./source/_data/listitems.json');
538-
patternlab.header = fs.readFileSync('./source/_patternlab-files/pattern-header-footer/header.html', 'utf8');
539-
patternlab.footer = fs.readFileSync('./source/_patternlab-files/pattern-header-footer/footer.html', 'utf8');
535+
patternlab.config.paths.source.patterns = patterns_dir;
536+
537+
patternlab.data = fs.readJSONSync(path.resolve(patternlab.config.paths.source.data, 'data.json'));
538+
patternlab.listitems = fs.readJSONSync(path.resolve(patternlab.config.paths.source.data, 'listitems.json'));
539+
patternlab.header = fs.readFileSync(path.resolve(patternlab.config.paths.source.patternlabFiles, 'pattern-header-footer/header.html'), 'utf8');
540+
patternlab.footer = fs.readFileSync(path.resolve(patternlab.config.paths.source.patternlabFiles, 'pattern-header-footer/footer.html'), 'utf8');
540541
patternlab.patterns = [];
541542
patternlab.data.link = {};
542543
patternlab.partials = {};
@@ -560,7 +561,7 @@
560561
return;
561562
}
562563

563-
pattern_assembler.process_pattern_iterative(file.substring(2), patternlab);
564+
pattern_assembler.process_pattern_iterative(path.resolve(file), patternlab);
564565
}
565566
);
566567

0 commit comments

Comments
 (0)