Skip to content

Commit 14c9705

Browse files
committed
Found pattern parameter data bleeding into global data object
Closes #139
1 parent c7d0399 commit 14c9705

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

CHANGELOG

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ THIS CHANGELOG IS AN ATTEMPT TO DOCUMENT CHANGES TO THIS PROJECT.
22

33
PL-node-v0.11.0
44
- ADD: Ignore pattern directories that start with an underscore.
5+
- FIX: Resolved issue where pattern parameter data bled into global data object
56

67
PL-node-v0.10.1
78
- ADD: Added more unit tests for recently more-modular code

builder/parameter_hunter.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,13 @@
4141

4242
//compile this partial immeadiately, essentially consuming it.
4343
var partialPattern = pattern_assembler.get_pattern_by_key(partialName, patternlab);
44-
var existingData = pattern.data || patternlab.data;
44+
var existingData = pattern.data ? JSON.parse(JSON.stringify(pattern.data)) : JSON.parse(JSON.stringify(patternlab.data));
4545

4646
//merge paramData with any other data that exists.
4747
for (var prop in paramData) {
4848
if (existingData.hasOwnProperty(prop)) {
4949
existingData[prop] = paramData[prop];
50-
}
50+
}
5151
}
5252

5353
//extend pattern data links into link for pattern link shortcuts to work. we do this locally and globally

0 commit comments

Comments
 (0)