Skip to content

Commit 25c9366

Browse files
committed
fix: fix inability to previously open / close / traverse pattern lab's navigation via keyboard
1 parent cc9bf02 commit 25c9366

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

packages/uikit-workshop/src/html/partials/pattern-nav.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
{{# patternTypes }}
22
<li class="pl-c-nav__item pl-c-nav__item--{{ patternTypeLC }}">
33

4-
<a class="pl-c-nav__link pl-c-nav__link--dropdown pl-js-acc-handle" tabindex="0" role="tab" aria-controls="{{ patternTypeLC }}">{{ patternTypeUC }}</a>
4+
<button class="pl-c-nav__link pl-c-nav__link--dropdown pl-js-acc-handle" role="tab" aria-controls="{{ patternTypeLC }}">{{ patternTypeUC }}</button>
55

66
<ol class="pl-c-nav__sublist pl-c-nav__sublist--dropdown pl-js-acc-panel" id="{{ patternTypeLC }}">
77

88
{{# patternTypeItems }}
99
<li class="pl-c-nav__item pl-c-nav__item--{{ patternSubtypeLC }}">
1010

11-
<a class="pl-c-nav__link pl-c-nav__link--dropdown pl-js-acc-handle">{{ patternSubtypeUC }}</a>
11+
<button class="pl-c-nav__link pl-c-nav__link--dropdown pl-js-acc-handle" aria-controls="{{ patternSubtypeUC }}" role="tab">{{ patternSubtypeUC }}</button>
1212

13-
<ol class="pl-c-nav__subsublist pl-c-nav__subsublist--dropdown pl-js-acc-panel">
13+
<ol id="{{ patternSubtypeUC }}" class="pl-c-nav__subsublist pl-c-nav__subsublist--dropdown pl-js-acc-panel">
1414

1515
{{# patternSubtypeItems }}
1616
<li class="pl-c-nav__item">

packages/uikit-workshop/src/sass/scss/04-components/_navigation.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,7 @@
185185
.pl-c-nav__subsublist--dropdown {
186186
@include listReset();
187187
@include accordionPanel();
188+
visibility: hidden;
188189
}
189190

190191
/**
@@ -194,6 +195,7 @@
194195
.pl-c-nav__sublist--dropdown.pl-is-active,
195196
.pl-c-nav__subsublist--dropdown.pl-is-active {
196197
margin-left: $pl-space / 2;
198+
visibility: visible;
197199

198200
@media all and (min-width: $pl-bp-med) {
199201
height: auto;

packages/uikit-workshop/src/scripts/components/styleguide.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@ import { urlHandler, DataSaver } from '../utils';
6363

6464
// Accordion dropdown
6565
$('.pl-js-acc-handle').on('click', function(e) {
66-
e.preventDefault();
67-
6866
const $this = $(this);
6967
const $panel = $this.next('.pl-js-acc-panel');
7068
const subnav = $this

0 commit comments

Comments
 (0)