Merge pull request #120 from walmokrani/dev

Brian Muenzenmeyer · Brian Muenzenmeyer · commit 29390ecf0697 · 2015-04-29T22:00:59.000-05:00
Guard against index out of bounds errors in View All Nav logic
diff --git a/builder/patternlab.js b/builder/patternlab.js
@@ -367,7 +367,7 @@ var entity_encoder = new he();
           navViewAllSubItem.patternPartial = "viewall-" + pattern.patternGroup + "-" + pattern.patternSubGroup;
 
           //check if we are moving to a new sub section in the next loop
-          if (pattern.patternSubGroup !== patternlab.patterns[i + 1].patternSubGroup) {
+          if (!patternlab.patterns[i + 1] || pattern.patternSubGroup !== patternlab.patterns[i + 1].patternSubGroup) {
             navItem.navSubItems.push(navViewAllSubItem);
             navItem.navSubItemsIndex.push("View All");
           }

Original file line number	Diff line number	Diff line change
`@@ -367,7 +367,7 @@ var entity_encoder = new he();`
`367`	`367`	`navViewAllSubItem.patternPartial = "viewall-" + pattern.patternGroup + "-" + pattern.patternSubGroup;`
`368`	`368`
`369`	`369`	`//check if we are moving to a new sub section in the next loop`
`370`		`- if (pattern.patternSubGroup !== patternlab.patterns[i + 1].patternSubGroup) {`
	`370`	`+ if (!patternlab.patterns[i + 1] \|\| pattern.patternSubGroup !== patternlab.patterns[i + 1].patternSubGroup) {`
`371`	`371`	`navItem.navSubItems.push(navViewAllSubItem);`
`372`	`372`	`navItem.navSubItemsIndex.push("View All");`
`373`	`373`	`}`