Skip to content

Commit 2c57401

Browse files
committed
refactor: replace compiling Sass via Ruby w/ much faster (and more easily supported) Gulp Sass (node-sass under the hood)
1 parent cd1d1e0 commit 2c57401

File tree

2 files changed

+20
-11
lines changed

2 files changed

+20
-11
lines changed

packages/uikit-workshop/gulpfile.js

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
/* load command line arguments */
2-
var args = require('yargs').argv;
2+
const args = require('yargs').argv;
33

44
/* load gulp */
5-
var gulp = require('gulp');
5+
const gulp = require('gulp');
66

77
/* load the plugins */
8-
var gulpLoadPlugins = require('gulp-load-plugins');
9-
var plugins = gulpLoadPlugins({ scope: ['devDependencies'] });
8+
const gulpLoadPlugins = require('gulp-load-plugins');
9+
const plugins = gulpLoadPlugins({ scope: ['devDependencies'] });
1010
plugins.del = require('del');
1111
plugins.mainBowerFiles = require('main-bower-files');
1212

@@ -51,11 +51,16 @@ gulp.task('build:bower', ['clean:bower'], function() {
5151
});
5252

5353
gulp.task('build:css', function() {
54-
return plugins
55-
.rubySass('src/sass/pattern-lab.scss', {
56-
style: 'expanded',
57-
'sourcemap=none': true,
58-
})
54+
return gulp
55+
.src('src/sass/pattern-lab.scss')
56+
.pipe(
57+
plugins
58+
.sass({
59+
outputStyle: 'expanded',
60+
sourceMap: false,
61+
})
62+
.on('error', plugins.sass.logError)
63+
)
5964
.pipe(
6065
plugins.autoprefixer(
6166
{

packages/uikit-workshop/package.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@
33
"version": "1.0.0-alpha.7",
44
"description": "Front-end assets and templates for the default Pattern Lab workshop view",
55
"main": "gulpfile.js",
6-
"scripts": {},
6+
"scripts": {
7+
"setup": "npx bower install",
8+
"build": "gulp",
9+
"watch": "gulp --watch"
10+
},
711
"authors": [
812
{
913
"name": "Brad Frost",
@@ -31,7 +35,7 @@
3135
"gulp-minify-css": "0.3.7",
3236
"gulp-rename": "1.2.0",
3337
"gulp-resolve-dependencies": "1.0.1",
34-
"gulp-ruby-sass": "3.0.0",
38+
"gulp-sass": "^4.0.1",
3539
"gulp-uglify": "1.1.0",
3640
"gulp-util": "3.0.0",
3741
"imagemin-pngcrush": "0.1.0",

0 commit comments

Comments
 (0)