fix(lint): Resolve lint issues

Author: bmuenzenmeyer

core/lib/decompose.js

@@ -3,7 +3,6 @@
 const logger = require('./log');
 const lh = require('./lineage_hunter');
 const lih = require('./list_item_hunter');
-const pa = require('./pattern_assembler');
 const ph = require('./parameter_hunter');
 const smh = require('./style_modifier_hunter');
 const addPattern = require('./addPattern');
@@ -13,7 +12,6 @@ const processRecursive = require('./processRecursive');
 
 const lineage_hunter = new lh();
 const list_item_hunter = new lih();
-const pattern_assembler = new pa();
 const parameter_hunter = new ph();
 const style_modifier_hunter = new smh();
 
@@ -96,7 +94,9 @@ module.exports = function (pattern, patternlab, ignoreLineage) {
 
   //find pattern lineage
   if (!ignoreLineage) {
-    lineagePromise.resolve(() => {lineage_hunter.find_lineage(pattern, patternlab);})
+    lineagePromise.resolve(() => {
+      lineage_hunter.find_lineage(pattern, patternlab);
+    });
   } else {
     lineagePromise = Promise.resolve();
   }

core/lib/list_item_hunter.js

@@ -30,7 +30,8 @@ const list_item_hunter = function () {
 
         //build arrays that repeat the block, however large we need to
         const repeatedBlockTemplate = [];
-        let repeatedBlockHtml = '';
+
+        //let repeatedBlockHtml = ''; //todo
         for (let i = 0; i < items.indexOf(loopNumberString); i++) {
 
           logger.debug(`list item(s) in pattern ${pattern.patternPartial}, adding ${patternBlock} to repeatedBlockTemplate`);
@@ -53,7 +54,8 @@ const list_item_hunter = function () {
         for (let i = 0; i < repeatedBlockTemplate.length; i++) {
 
           let thisBlockTemplate = repeatedBlockTemplate[i];
-          let thisBlockHTML = "";
+
+          //let thisBlockHTML = ""; //todo
 
           //combine listItem data with pattern data with global data
           const itemData = listData['' + items.indexOf(loopNumberString)]; //this is a property like "2"
@@ -109,18 +111,20 @@ const list_item_hunter = function () {
             //thisBlockHTML = pattern_assembler.renderPattern(thisBlockTemplate, allData, patternlab.partials);
 
           } else {
+
             //just render with mergedData
             //TODO
             //thisBlockHTML = pattern_assembler.renderPattern(thisBlockTemplate, allData, patternlab.partials);
           }
 
           //add the rendered HTML to our string
-          repeatedBlockHtml = repeatedBlockHtml + thisBlockHTML;
+          //repeatedBlockHtml = repeatedBlockHtml + thisBlockHTML; //todo
         }
 
         //replace the block with our generated HTML
         const repeatingBlock = pattern.extendedTemplate.substring(pattern.extendedTemplate.indexOf(liMatch), pattern.extendedTemplate.indexOf(end) + end.length);
-        pattern.extendedTemplate = pattern.extendedTemplate.replace(repeatingBlock, repeatedBlockHtml);
+
+        //pattern.extendedTemplate = pattern.extendedTemplate.replace(repeatingBlock, repeatedBlockHtml); //todo
 
         //update the extendedTemplate in the partials object in case this pattern is consumed later
         patternlab.partials[pattern.patternPartial] = pattern.extendedTemplate;

core/lib/object_factory.js

@@ -121,7 +121,6 @@ Pattern.prototype = {
       return promise.then(results => {
         return results;
       }).catch((reason) => {
-        console.log(reason)
         return Promise.reject(reason);
       });
     }

core/lib/parameter_hunter.js

@@ -9,11 +9,9 @@ const logger = require('./log');
 const parseLink = require('./parseLink');
 const render = require('./render');
 const jsonCopy = require('./json_copy');
-const pa = require('./pattern_assembler');
 const smh = require('./style_modifier_hunter');
 
 const style_modifier_hunter = new smh();
-const pattern_assembler = new pa();
 
 const parameter_hunter = function () {
 

core/lib/parseLink.js

@@ -55,4 +55,4 @@ module.exports = function (patternlab, obj, key) {
   }
 
   return dataObj;
-}
+};

core/lib/pattern_assembler.js

@@ -276,18 +276,22 @@ const pattern_assembler = function () {
     mark_modified_patterns: function (lastModified, patternlab) {
       return markModifiedPatterns(lastModified, patternlab);
     },
+
     //todo review for deletion
     find_pattern_partials: function (pattern) {
       return pattern.findPartials();
     },
+
     //todo review for deletion
     find_pattern_partials_with_style_modifiers: function (pattern) {
       return pattern.findPartialsWithStyleModifiers();
     },
+
     //todo review for deletion
     find_pattern_partials_with_parameters: function (pattern) {
       return pattern.findPartialsWithPatternParameters();
     },
+
     //todo review for deletion
     find_list_items: function (pattern) {
       return pattern.findListItems();

core/lib/patternlab.js

@@ -364,6 +364,7 @@ module.exports = class PatternLab {
 
     //re-rendering the headHTML each time allows pattern-specific data to influence the head of the pattern
     pattern.header = head;
+
     // const headHTML
     const headPromise = Promise.resolve(render(Pattern.createEmpty({extendedTemplate: pattern.header}), allData));
 

core/lib/ui_builder.js

@@ -13,7 +13,6 @@ const renderSync = require('./lib/renderSync');
 
 //these are mocked in unit tests, so let them be overridden
 let fs = require('fs-extra'); //eslint-disable-line prefer-const
-let pattern_assembler = require('./pattern_assembler')(); //eslint-disable-line prefer-const
 
 const ui_builder = function () {