fix: address bug causing viewport width to progressively decrease in size when resizing your screen / refreshing on certain devices

sghoweri · sghoweri · commit 41b11af8aaaf · 2019-11-03T20:01:50.000-05:00
diff --git a/packages/uikit-workshop/src/scripts/lit-components/pl-viewport/pl-viewport.js b/packages/uikit-workshop/src/scripts/lit-components/pl-viewport/pl-viewport.js
@@ -224,7 +224,7 @@ class IFrame extends BaseLitComponent {
   }
 
   handleResize() {
-    this.updateSizeReading(this.iframe.clientWidth);
+    this.updateSizeReading(this.iframeContainer.clientWidth);
   }
 
   // Update Pixel and Em inputs
@@ -414,7 +414,7 @@ class IFrame extends BaseLitComponent {
     const self = this;
     self.querySelector('.pl-js-resize-handle').classList.add('is-resizing');
     const origClientX = event.clientX;
-    const origViewportWidth = this.iframe.clientWidth + 40;
+    const origViewportWidth = this.iframeContainer.clientWidth;
 
     this.fullMode = false;
 

Original file line number	Diff line number	Diff line change
`@@ -224,7 +224,7 @@ class IFrame extends BaseLitComponent {`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`handleResize() {`
`227`		`- this.updateSizeReading(this.iframe.clientWidth);`
	`227`	`+ this.updateSizeReading(this.iframeContainer.clientWidth);`
`228`	`228`	`}`
`229`	`229`
`230`	`230`	`// Update Pixel and Em inputs`
`@@ -414,7 +414,7 @@ class IFrame extends BaseLitComponent {`
`414`	`414`	`const self = this;`
`415`	`415`	`self.querySelector('.pl-js-resize-handle').classList.add('is-resizing');`
`416`	`416`	`const origClientX = event.clientX;`
`417`		`- const origViewportWidth = this.iframe.clientWidth + 40;`
	`417`	`+ const origViewportWidth = this.iframeContainer.clientWidth;`
`418`	`418`
`419`	`419`	`this.fullMode = false;`
`420`	`420`