Skip to content

Commit 438c6b1

Browse files
committed
fix(package): Remove unneeded dependency
1 parent 6fe9785 commit 438c6b1

File tree

4 files changed

+19
-39
lines changed

4 files changed

+19
-39
lines changed

core/index.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,6 @@ const patternlab_module = function (config) {
172172

173173
patternlab.buildGlobalData();
174174

175-
// diveSync once to perform iterative populating of patternlab object
176175
return patternlab.processAllPatternsIterative(paths.source.patterns).then(() => {
177176

178177
patternlab.events.emit('patternlab-pattern-iteration-end', patternlab);
@@ -181,9 +180,8 @@ const patternlab_module = function (config) {
181180
//we need to do this before expanding patterns & partials into extendedTemplates, otherwise we could lose the data -> partial reference
182181
parseAllLinks(patternlab);
183182

184-
//diveSync again to recursively include partials, filling out the
183+
//dive again to recursively include partials, filling out the
185184
//extendedTemplate property of the patternlab.patterns elements
186-
// TODO we can reduce the time needed by only processing changed patterns and their partials
187185
return patternlab.processAllPatternsRecursive(paths.source.patterns).then(() => {
188186

189187
//take the user defined head and foot and process any data and patterns that apply

core/lib/patternlab.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
"use strict";
22

3-
const diveSync = require('diveSync');
43
const dive = require('dive');
54
const _ = require('lodash');
65
const path = require('path');
@@ -427,8 +426,7 @@ module.exports = class PatternLab {
427426
return dataLoader.loadDataFromFolder(dataFilesPath, 'listitems', fsDep);
428427
}
429428

430-
// GTP: these two diveSync pattern processors factored out so they can be reused
431-
// from unit tests to reduce code dupe!
429+
// dive once to perform iterative populating of patternlab object
432430
processAllPatternsIterative(patterns_dir) {
433431
const self = this;
434432
const promiseAllPatternFiles = new Promise(function (resolve) {

package-lock.json

Lines changed: 17 additions & 32 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
"chalk": "^1.1.3",
1010
"chokidar": "^1.7.0",
1111
"dive": "^0.5.0",
12-
"diveSync": "^0.3.0",
1312
"fs-extra": "^0.30.0",
1413
"glob": "^7.0.0",
1514
"graphlib": "^2.1.1",

0 commit comments

Comments
 (0)