Skip to content

Commit 4adce73

Browse files
Merge pull request #915 from sghoweri/feature/remove-bower-refactor-js
UIKit Refactor: Bower to NPM Migration, Partial JS Refactor, and New JS Build Pipeline
2 parents fb92e63 + 64a2c10 commit 4adce73

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+339
-3335
lines changed

packages/cli/CHANGELOG.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,13 @@ All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

66
<a name="0.0.1-alpha.23"></a>
7-
## [0.0.1-alpha.23](https://github.com/pattern-lab/patternlab-node/tree/master/packages/cli/compare/@pattern-lab/[email protected]...@pattern-lab/[email protected]) (2018-07-09)
87

8+
## [0.0.1-alpha.23](https://github.com/pattern-lab/patternlab-node/tree/master/packages/cli/compare/@pattern-lab/[email protected]...@pattern-lab/[email protected]) (2018-07-09)
99

1010
### Bug Fixes
1111

1212
* **install:** copy dependencies ([1acef87](https://github.com/pattern-lab/patternlab-node/tree/master/packages/cli/commit/1acef87))
1313

14-
15-
16-
17-
1814
<a name="0.0.1-alpha.22"></a>
1915

2016
## [0.0.1-alpha.22](https://github.com/pattern-lab/patternlab-node/tree/master/packages/cli/compare/@pattern-lab/[email protected]...@pattern-lab/[email protected]) (2018-07-06)

packages/edition-node-gulp/CHANGELOG.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,11 @@ All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

66
<a name="2.0.0-alpha.15"></a>
7+
78
# [2.0.0-alpha.15](https://github.com/pattern-lab/patternlab-node/tree/master/packages/edition-node-gulp/compare/@pattern-lab/[email protected]...@pattern-lab/[email protected]) (2018-07-09)
89

910
**Note:** Version bump only for package @pattern-lab/edition-node-gulp
1011

11-
12-
13-
14-
1512
<a name="2.0.0-alpha.14"></a>
1613

1714
# [2.0.0-alpha.14](https://github.com/pattern-lab/patternlab-node/tree/master/packages/edition-node-gulp/compare/@pattern-lab/[email protected]...@pattern-lab/[email protected]) (2018-07-06)

packages/edition-node/CHANGELOG.md

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,13 @@ All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

66
<a name="1.0.0-alpha.13"></a>
7-
# [1.0.0-alpha.13](https://github.com/pattern-lab/patternlab-node/tree/master/packages/edition-node/compare/@pattern-lab/[email protected]...@pattern-lab/[email protected]) (2018-07-09)
87

8+
# [1.0.0-alpha.13](https://github.com/pattern-lab/patternlab-node/tree/master/packages/edition-node/compare/@pattern-lab/[email protected]...@pattern-lab/[email protected]) (2018-07-09)
99

1010
### Features
1111

1212
* **scripts:** namespace scripts ([3ecbb3e](https://github.com/pattern-lab/patternlab-node/tree/master/packages/edition-node/commit/3ecbb3e))
1313

14-
15-
16-
17-
1814
<a name="1.0.0-alpha.12"></a>
1915

2016
# [1.0.0-alpha.12](https://github.com/pattern-lab/patternlab-node/tree/master/packages/edition-node/compare/@pattern-lab/[email protected]...@pattern-lab/[email protected]) (2018-07-06)

packages/uikit-workshop/.bowerrc

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/uikit-workshop/bower.json

Lines changed: 0 additions & 34 deletions
This file was deleted.

packages/uikit-workshop/dist/index.html

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@ <h3 class="pl-c-annotations__item-title">{{ title }}</h3>
375375
<script src="styleguide/data/patternlab-data.js" defer></script>
376376

377377
<!-- applying theme config to get classes on before PL renders so there's no flash of unstyled content -->
378-
<!-- @todo Consider moving this to own file -->
378+
<!-- @todo fold this into it's own standalone JS component -->
379379
<script>
380380
// need to make sure that window.config is defined first on acccount of us async loading everything ;)
381381
window.patternlab = window.patternlab || {};
@@ -407,31 +407,14 @@ <h3 class="pl-c-annotations__item-title">{{ title }}</h3>
407407
}
408408
</script>
409409

410-
<script src="annotations/annotations.js" async></script>
411-
412-
<!-- load Pattern Lab external library js -->
413-
<script src="styleguide/bower_components/jquery.min.js" defer></script>
414-
<script src="styleguide/bower_components/hogan-3.0.2.min.js" defer></script>
415-
<script src="styleguide/bower_components/prism.min.js" defer></script>
416-
<script src="styleguide/bower_components/jwerty.min.js" defer></script>
417-
<script src="styleguide/bower_components/typeahead.bundle.min.js" defer></script>
418-
<script src="styleguide/bower_components/EventEmitter.min.js" defer></script>
419-
<script src="styleguide/bower_components/script.min.js" defer></script>
420-
410+
<script src="annotations/annotations.js" defer></script>
421411

412+
<!-- load the Pattern Lab viewer js -->
422413
<script>(function(){window.whenDefined=function(e,n,t){e[n]?t():Object.defineProperty(e,n,{configurable:!0,enumerable:!0,writeable:!0,get:function(){return this["_"+n]},set:function(e){this["_"+n]=e,t()}})}}).call(this);</script>
423-
<script>!function(r){var e=function(e,t){"use strict";var n=r.document.getElementsByTagName("script")[0],o=r.document.createElement("script");return o.src=e,o.async=!0,n.parentNode.insertBefore(o,n),t&&"function"==typeof t&&(o.onload=t),o};"undefined"!=typeof module?module.exports=e:r.loadJS=e}("undefined"!=typeof global?global:this);</script>
414+
<script src="styleguide/js/patternlab-viewer.js" defer></script>
424415

425416
<!-- temp workaround to allow everything to be asynced / deffered with current setup. @todo: remove once refactored components + improved build process is in place. -->
426417
<script>
427-
window.Dispatcher;
428-
window.addEventListener('DOMContentLoaded', function () {
429-
window.Dispatcher = new EventEmitter();
430-
431-
// load the Pattern Lab viewer js -- preloaded earlier ^
432-
loadJS('styleguide/js/patternlab-viewer.js');
433-
});
434-
435418
whenDefined(window, 'config', function() {
436419
if (window.config.theme){
437420
window.patternlab.applyTheme();
@@ -448,6 +431,7 @@ <h3 class="pl-c-annotations__item-title">{{ title }}</h3>
448431
// }
449432
</script>
450433

434+
451435
</body>
452436

453437
</html>

packages/uikit-workshop/dist/styleguide/bower_components/EventEmitter.min.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/uikit-workshop/dist/styleguide/bower_components/hogan-3.0.2.min.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/uikit-workshop/dist/styleguide/bower_components/jquery.min.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)