Skip to content

Commit 636342c

Browse files
author
Brian Muenzenmeyer
committed
Merge pull request #255 from pattern-lab/dev
added .github dir and templates
2 parents e132d89 + 757142a commit 636342c

File tree

3 files changed

+21
-7
lines changed

3 files changed

+21
-7
lines changed
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
#Contributing to Patternlab - Node
2-
If you'd like to contribute to patternlab - node, please do so! There is always a lot of ground to cover, with patternlab - php being so feature-rich.
1+
# Contributing to Patternlab Node
2+
If you'd like to contribute to Pattern Lab Node, please do so! There is always a lot of ground to cover and something for your wheelhouse.
33

4-
No pull request is too small. Check out any [up for grabs issues](https://github.com/pattern-lab/patternlab-node/labels/up%20for%20grabs) as a good way to get your feet wet.
4+
No pull request is too small. Check out any [up for grabs issues](https://github.com/pattern-lab/patternlab-node/labels/up%20for%20grabs) as a good way to get your feet wet, or add some more unit tests.
55

6-
##Guidelines
7-
1. Please keep your pull requests concise and limited to **ONE** substantive change at a time.
8-
2. _ALWAYS_ submit pull requests against the [dev branch](https://github.com/pattern-lab/patternlab-node/tree/dev). If this does not occur, I will first, try to redirect you gently, second, port over your contribution manually if time allows, and/or third, close your pull request.
9-
3. If you can, add some unit tests using the existing patterns
6+
## Guidelines
7+
1. Please keep your pull requests concise and limited to **ONE** substantive change at a time. This makes reviewing and testing so much easier.
8+
2. _ALWAYS_ submit pull requests against the [dev branch](https://github.com/pattern-lab/patternlab-node/tree/dev). If this does not occur, I will first, try to redirect you gently, second, port over your contribution manually if time allows, and/or third, close your pull request. If you have a major feature to stabilize over time, talk to @bmuenzenmeyer about making a dedicated `feature-branch`
9+
3. If you can, add some unit tests using the existing patterns in the `./test` directory
1010

1111
##Coding style
1212
Regarding code style like indentation and whitespace, follow the conventions you see used in the source already. Add enough source code comments to help the next person.

.github/ISSUE_TEMPLATE.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
I am using Pattern Lab Node `vX.X.X` on `Windows|Mac|Linux`, using the `grunt|gulp` configuration.
2+
3+
##### Expected Behavior
4+
5+
6+
##### Actual Behavior
7+
8+
9+
##### Steps to Reproduce

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
**Target the `dev` branch!**
2+
3+
Addresses #
4+
5+
Summary of changes:

0 commit comments

Comments
 (0)