Skip to content

Commit 72613c5

Browse files
committed
refactor: clean up console logs + add ability to close context menu via hitting the escape key
1 parent bd1c32c commit 72613c5

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/uikit-workshop/src/scripts/components/pl-nav/pl-nav.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ class Nav extends BaseComponent {
202202
this.previousActiveLinks = [];
203203
this.iframeElem = document.querySelector('pl-iframe');
204204

205-
Mousetrap.bind('esc', function(e) {
205+
Mousetrap(this).bind('esc', () => {
206206
self.cleanupActiveNav();
207207
});
208208

@@ -260,10 +260,6 @@ class Nav extends BaseComponent {
260260
window.innerWidth <= 670 ||
261261
(window.innerWidth >= 670 && self.layoutMode !== 'vertical')
262262
) {
263-
console.log(
264-
window.innerWidth <= 670 ||
265-
(window.innerWidth >= 670 && self.layoutMode !== 'vertical')
266-
);
267263
self.cleanupActiveNav();
268264
}
269265
} catch (error) {

packages/uikit-workshop/src/scripts/components/pl-tools-menu/pl-tools-menu.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
/* eslint-disable no-unused-vars */
22
import { define, props } from 'skatejs';
3+
import Mousetrap from 'mousetrap';
34
import { h } from 'preact';
45
import { BaseComponent } from '../base-component.js';
56
import { urlHandler, patternName } from '../../utils';
@@ -49,6 +50,10 @@ class ToolsMenu extends BaseLitComponent {
4950

5051
window.addEventListener('message', this.receiveIframeMessage, false);
5152
document.addEventListener('click', this.handleExternalClicks);
53+
54+
Mousetrap(this).bind('esc', () => {
55+
this.close();
56+
});
5257
}
5358

5459
disconnecting() {
@@ -114,7 +119,6 @@ class ToolsMenu extends BaseLitComponent {
114119

115120
if (data.event !== undefined && data.event === 'patternLab.pageClick') {
116121
try {
117-
console.log('patternLab.pageClick');
118122
self.isOpen = false;
119123
} catch (error) {
120124
console.log(error);

0 commit comments

Comments
 (0)