Skip to content

Commit 726c18c

Browse files
committed
cleaned up some whitespace. will try to slowly convert over to using spaces instead of tabs for indentation
updated CHANGELOG
1 parent d9636e0 commit 726c18c

File tree

5 files changed

+536
-531
lines changed

5 files changed

+536
-531
lines changed

CHANGELOG

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@ PL-node-v0.9.0
1111
- ADD: Added support for all keyboard shortcuts found in PL-PHP-v1.0.0
1212
- FIX: Fixed an issue where Hay mode and Disco mode did not stop one another when using keyboard shortcuts
1313
- FIX: Fix location of paragraph closing tag to wrap citation
14-
- THX @laurendorman for the pull request!
14+
- THX: @laurendorman for the pull request!
15+
- FIX: Removed some dead code.
16+
- ADD: Added View All links in each menu subsection
17+
- THX: BIG THANKS TO @walmokrani for this work!
1518

1619
PL-node-v0.8.1
1720
- FIX: v8 is not pulling in values from global data.json

CONTRIBUTING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@ No pull request is too small.
55

66
##Guidelines
77
1. Please keep your pull requests concise
8-
2. _ALWAYS_ submit it against the [dev branch](https://github.com/pattern-lab/patternlab-node/tree/dev). If this does not occur, I will first, try to redirect you gently, second, port over your contribution manually if time allows, and/or third, close your pull request.
8+
2. _ALWAYS_ submit it against the [dev branch](https://github.com/pattern-lab/patternlab-node/tree/dev). If this does not occur, I will first, try to redirect you gently, second, port over your contribution manually if time allows, and/or third, close your pull request.
9+
3. If you can, add some unit tests using the existing patterns

builder/object_factory.js

Lines changed: 44 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -9,54 +9,54 @@
99
*/
1010

1111
(function () {
12-
"use strict";
12+
"use strict";
1313

14-
var oPattern = function(subdir, filename, data){
15-
this.fileName = filename.substring(0, filename.indexOf('.'));
16-
this.subdir = subdir;
17-
this.name = subdir.replace(/[\/\\]/g, '-') + '-' + this.fileName; //this is the unique name with the subDir
18-
this.data = data || null;
19-
this.patternName = this.fileName.substring(this.fileName.indexOf('-') + 1); //this is the display name for the ui
20-
this.patternLink = this.name + '/' + this.name + '.html';
21-
this.patternGroup = this.name.substring(this.name.indexOf('-') + 1, this.name.indexOf('-', 4) + 1 - this.name.indexOf('-') + 1);
22-
this.patternSubGroup = subdir.substring(subdir.indexOf('/') + 4);
23-
this.flatPatternPath = subdir.replace(/[\/\\]/g, '-');
24-
this.key = this.patternGroup + '-' + this.patternName;
25-
this.template = '';
26-
this.patternPartial = '';
27-
this.lineage = [];
28-
this.lineageIndex = [];
29-
this.lineageR = [];
30-
this.lineageRIndex = [];
31-
};
14+
var oPattern = function(subdir, filename, data){
15+
this.fileName = filename.substring(0, filename.indexOf('.'));
16+
this.subdir = subdir;
17+
this.name = subdir.replace(/[\/\\]/g, '-') + '-' + this.fileName; //this is the unique name with the subDir
18+
this.data = data || null;
19+
this.patternName = this.fileName.substring(this.fileName.indexOf('-') + 1); //this is the display name for the ui
20+
this.patternLink = this.name + '/' + this.name + '.html';
21+
this.patternGroup = this.name.substring(this.name.indexOf('-') + 1, this.name.indexOf('-', 4) + 1 - this.name.indexOf('-') + 1);
22+
this.patternSubGroup = subdir.substring(subdir.indexOf('/') + 4);
23+
this.flatPatternPath = subdir.replace(/[\/\\]/g, '-');
24+
this.key = this.patternGroup + '-' + this.patternName;
25+
this.template = '';
26+
this.patternPartial = '';
27+
this.lineage = [];
28+
this.lineageIndex = [];
29+
this.lineageR = [];
30+
this.lineageRIndex = [];
31+
};
3232

33-
var oBucket = function(name){
34-
this.bucketNameLC = name;
35-
this.bucketNameUC = name.charAt(0).toUpperCase() + name.slice(1);
36-
this.navItems = [];
37-
this.navItemsIndex = [];
38-
this.patternItems = [];
39-
this.patternItemsIndex = [];
40-
};
33+
var oBucket = function(name){
34+
this.bucketNameLC = name;
35+
this.bucketNameUC = name.charAt(0).toUpperCase() + name.slice(1);
36+
this.navItems = [];
37+
this.navItemsIndex = [];
38+
this.patternItems = [];
39+
this.patternItemsIndex = [];
40+
};
4141

42-
var oNavItem = function(name){
43-
this.sectionNameLC = name;
44-
this.sectionNameUC = name.charAt(0).toUpperCase() + name.slice(1);
45-
this.navSubItems = [];
46-
this.navSubItemsIndex = [];
47-
};
42+
var oNavItem = function(name){
43+
this.sectionNameLC = name;
44+
this.sectionNameUC = name.charAt(0).toUpperCase() + name.slice(1);
45+
this.navSubItems = [];
46+
this.navSubItemsIndex = [];
47+
};
4848

49-
var oNavSubItem = function(name){
50-
this.patternPath = '';
51-
this.patternPartial = '';
52-
this.patternName = name.charAt(0).toUpperCase() + name.slice(1);
53-
};
49+
var oNavSubItem = function(name){
50+
this.patternPath = '';
51+
this.patternPartial = '';
52+
this.patternName = name.charAt(0).toUpperCase() + name.slice(1);
53+
};
5454

55-
module.exports = {
56-
oPattern: oPattern,
57-
oBucket: oBucket,
58-
oNavItem: oNavItem,
59-
oNavSubItem: oNavSubItem
60-
};
55+
module.exports = {
56+
oPattern: oPattern,
57+
oBucket: oBucket,
58+
oNavItem: oNavItem,
59+
oNavSubItem: oNavSubItem
60+
};
6161

6262
}());

0 commit comments

Comments
 (0)