Skip to content

Commit 767315f

Browse files
committed
chore(getDefaultConfig): Move call and tests
Attempt to avoid invoking module until needed
1 parent a058a03 commit 767315f

File tree

4 files changed

+25
-9
lines changed

4 files changed

+25
-9
lines changed

core/index.js

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ const pa = require('./lib/pattern_assembler');
2222
const pe = require('./lib/pattern_exporter');
2323
const lh = require('./lib/lineage_hunter');
2424

25-
const PatternLab = require('./lib/patternlab');
25+
const defaultConfig = require('../patternlab-config.json');
2626

2727
let fs = require('fs-extra'); // eslint-disable-line
2828
let ui_builder = require('./lib/ui_builder'); // eslint-disable-line
@@ -39,7 +39,18 @@ updateNotifier({
3939
updateCheckInterval: 1000 * 60 * 60 * 24 // notify at most once a day
4040
}).notify();
4141

42+
43+
/**
44+
* Returns the standardized default config
45+
*
46+
* @return {object} Returns the object representation of the patternlab-config.json
47+
*/
48+
const getDefaultConfig = function () {
49+
return defaultConfig;
50+
};
51+
4252
const patternlab_module = function (config) {
53+
const PatternLab = require('./lib/patternlab');
4354
const patternlab = new PatternLab(config);
4455
const paths = patternlab.config.paths;
4556

@@ -380,4 +391,6 @@ const patternlab_module = function (config) {
380391
};
381392
};
382393

394+
patternlab_module.getDefaultConfig = getDefaultConfig;
395+
383396
module.exports = patternlab_module;

core/lib/patternlab.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ const cleanHtml = require('js-beautify').html;
88
const inherits = require('util').inherits;
99
const pm = require('./plugin_manager');
1010
const packageInfo = require('../../package.json');
11-
const defaultConfig = require('../../patternlab-config.json');
1211
const dataLoader = require('./data_loader')();
1312
const logger = require('./log');
1413
const jsonCopy = require('./json_copy');

test/index_tests.js

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
const tap = require('tap');
2+
const defaultConfig = require('../patternlab-config.json');
3+
4+
const entry = require('../core/index');
5+
6+
tap.test('getDefaultConfig - should return the default config object', function(test) {
7+
const requestedConfig = entry.getDefaultConfig();
8+
test.type(requestedConfig, 'object');
9+
test.equals(requestedConfig, defaultConfig);
10+
test.end();
11+
});

test/patternlab_tests.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,6 @@ tap.test('buildPatternData - can load json, yaml, and yml files', function(test)
5454
test.end();
5555
});
5656

57-
tap.test('getDefaultConfig - should return the default config object', function(test) {
58-
const requestedConfig = plEngineModule.getDefaultConfig();
59-
test.type(requestedConfig, 'object');
60-
test.equals(requestedConfig, defaultConfig);
61-
test.end();
62-
});
63-
6457
// this test needs to be re-jiggered
6558
// tap.test('buildPatterns - should replace data link even when pattern parameter present', function(test) {
6659
// //arrange

0 commit comments

Comments
 (0)