Skip to content

Commit 812c234

Browse files
committed
add additional debugging info to json catch use case
1 parent a15dfe2 commit 812c234

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

core/lib/parameter_hunter.js

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,10 @@ var parameter_hunter = function () {
5050
* * Return paramStringWellFormed.
5151
*
5252
* @param {string} pString
53+
* @param {object} patternlab
5354
* @returns {string} paramStringWellFormed
5455
*/
55-
function paramToJson(pString) {
56+
function paramToJson(pString, patternlab) {
5657
var colonPos = -1;
5758
var keys = [];
5859
var paramString = pString; // to not reassign param
@@ -62,12 +63,15 @@ var parameter_hunter = function () {
6263
var values = [];
6364
var wrapper;
6465

65-
// attempt to parse the data incase it is already well formed JSON
66+
// attempt to parse the data in case it is already well formed JSON
6667
try {
6768
paramStringWellFormed = JSON.stringify(JSON.parse(pString));
6869
return paramStringWellFormed;
69-
} catch(err) {
70-
console.log('Not valid JSON - will attempt to parse manually...');
70+
} catch (err) {
71+
//todo this might be a good candidate for a different log level, should we implement that someday
72+
if (patternlab.config.debug) {
73+
console.log(`Not valid JSON found for passed pattern parameter ${pString} will attempt to parse manually...`);
74+
}
7175
}
7276

7377
//replace all escaped double-quotes with escaped unicode
@@ -261,7 +265,7 @@ var parameter_hunter = function () {
261265
var leftParen = pMatch.indexOf('(');
262266
var rightParen = pMatch.lastIndexOf(')');
263267
var paramString = '{' + pMatch.substring(leftParen + 1, rightParen) + '}';
264-
var paramStringWellFormed = paramToJson(paramString);
268+
var paramStringWellFormed = paramToJson(paramString, patternlab);
265269

266270
var paramData = {};
267271
var globalData = {};

0 commit comments

Comments
 (0)