fix(cli): pass watch options cleanly to core

Author: bmuenzenmeyer

packages/cli/bin/cli-actions/serve.js

@@ -7,7 +7,6 @@ const serve = options =>
   wrapAsync(function*() {
     const config = yield resolveConfig(options.parent.config);
     servePatterns(config, options);
-    servePatterns(config, options.watch);
   });
 
 module.exports = serve;

packages/cli/bin/patternlab.js

@@ -57,6 +57,7 @@ cli
   .alias('compile')
   .description('Build Pattern Lab. Optionally (re-)build only the patterns')
   .option('-p, --patterns-only', 'Whether to only build patterns')
+  .option('--no-watch', 'Start watching for changes')
   .action(build);
 
 /**
@@ -130,7 +131,7 @@ cli
   .command('serve')
   .alias('browse')
   .description('Starts a server to inspect files in browser')
-  .option('-w, --watch', 'Start watching for changes')
+  .option('--no-watch', 'Start watching for changes')
   .action(serve);
 
 // Show additional help

packages/cli/bin/serve.js

@@ -9,8 +9,9 @@ const { error, info } = require('./utils');
  * @func serve
  * @desc Start a browser-sync server in the Pattern Lab public dir
  * @param {object} config - The passed Pattern Lab config
+ * @param {object} options - The passed options at invocation time
  */
-function serve(config) {
+function serve(config, options) {
   if (!isValidConfig) {
     throw new TypeError(
       'serve: Expects config not to be empty and of type object.'
@@ -37,7 +38,7 @@ function serve(config) {
   try {
     info(`serve: Serving your files …`);
     const pl = patternlab(config);
-    pl.server.serve({});
+    pl.server.serve(options);
   } catch (err) {
     error(err);
   }

packages/core/src/index.js

@@ -266,13 +266,12 @@ const patternlab_module = function(config) {
        * @param {object} options an object used to control build behavior
        * @param {bool} options.cleanPublic whether or not to delete the configured output location (usually `public/`) before build
        * @param {object} options.data additional data to be merged with global data prior to build
-       * @param {bool} options.watch **ALWAYS OVERRIDDEN to `true`** whether or not Pattern Lab should watch configured `source/` directories for changes to rebuild
+       * @param {bool} [true] options.watch whether or not Pattern Lab should watch configured `source/` directories for changes to rebuild
        * @returns {Promise} a promise fulfilled when build is complete
        */
       serve: options => {
-        const _options = Object.assign({}, options, { watch: true });
         return _api
-          .build(_options)
+          .build(options)
           .then(() => server.serve())
           .catch(e =>
             logger.error(`error inside core index.js server serve: ${e}`)