Skip to content

Commit 930b619

Browse files
committed
fix: misc IE 11-specific UI and layout bugs
1 parent b3abb20 commit 930b619

File tree

5 files changed

+28
-1
lines changed

5 files changed

+28
-1
lines changed

packages/uikit-workshop/src/sass/scss/04-components/_controls.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,11 @@
1010
margin-left: auto; /* 2 */
1111
display: flex;
1212
flex-wrap: nowrap;
13+
14+
// IE 11 layout bug
15+
.pl-c-body--theme-sidebar & {
16+
display: block;
17+
}
1318
}
1419

1520
/**

packages/uikit-workshop/src/sass/scss/04-components/_ish-sizing.scss

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,8 @@
7070
list-style: none;
7171
margin: 0;
7272
padding: 0;
73+
overflow-x: auto;
74+
padding: 0 0.25rem;
7375

7476
@media all and (min-width: $pl-bp-med) {
7577
align-items: center;
@@ -96,3 +98,12 @@
9698
.pl-c-size-list__action {
9799
@include linkStyle();
98100
}
101+
102+
// Force list items to center align if not overflow scrolling
103+
.pl-c-size-list__item:first-child {
104+
margin-left: auto;
105+
}
106+
107+
.pl-c-size-list__item:last-child {
108+
margin-right: auto;
109+
}

packages/uikit-workshop/src/sass/scss/04-components/_viewport.scss

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,10 @@
3333
@supports (position: sticky) {
3434
top: 0;
3535
}
36+
37+
.pl-c-body--theme-sidebar & {
38+
top: 0;
39+
}
3640
}
3741

3842
/**
@@ -159,6 +163,11 @@
159163
.pl-c-body--theme-sidebar & {
160164
@media all and (min-width: $pl-bp-med) {
161165
max-width: calc(100vw - #{$pl-sidebar-width});
166+
167+
// IE 11 bug causing viewport to be offset
168+
@media all and (-ms-high-contrast: none), (-ms-high-contrast: active) {
169+
margin-left: $pl-sidebar-width;
170+
}
162171
}
163172
}
164173
}

packages/uikit-workshop/src/sass/scss/05-themes/_sidebar-theme.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
padding: 1rem;
2424
overflow: auto;
2525
@include hideScrollBar();
26+
justify-content: space-between;
2627
}
2728

2829
/**
@@ -154,7 +155,7 @@
154155
* they appear at the bottom
155156
*/
156157
.pl-c-controls {
157-
margin-top: auto; /* 1 */
158+
justify-self: flex-end;
158159
margin-left: 0;
159160
flex-direction: column;
160161
}

packages/uikit-workshop/src/scripts/components/pl-layout/pl-layout.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ pl-layout {
55
flex-direction: column;
66
height: 100%;
77
background-color: $pl-color-gray-13;
8+
overflow: hidden; // Fix for IE 11 layout bug
89

910
&.pl-c-body--theme-sidebar {
1011
@media all and (min-width: $pl-bp-med) {

0 commit comments

Comments
 (0)