Skip to content

Commit a1d11c9

Browse files
author
Tobias Brennecke
committed
Fixes #580 Renaming pattern causes patternlab to break and #581 Setting cleanPublic = true after incremental build does not recompile all patterns.
1 parent ecb3c46 commit a1d11c9

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

core/lib/patternlab.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -448,7 +448,7 @@ var patternlab_engine = function (config) {
448448
* @param {boolean} deletePatternDir When {@code true}, an empty graph is returned
449449
* @return {PatternGraph}
450450
*/
451-
function loadPatternGraph(patternlab, deletePatternDir) {
451+
function loadPatternGraph(deletePatternDir) {
452452
// Sanity check to prevent problems when code is refactored
453453
if (deletePatternDir) {
454454
return PatternGraph.empty();
@@ -460,7 +460,7 @@ var patternlab_engine = function (config) {
460460

461461
patternlab.events.emit('patternlab-build-pattern-start', patternlab);
462462

463-
let graph = patternlab.graph = loadPatternGraph(patternlab, deletePatternDir);
463+
let graph = patternlab.graph = loadPatternGraph(deletePatternDir);
464464

465465
let graphNeedsUpgrade = !PatternGraph.checkVersion(graph);
466466

@@ -476,7 +476,7 @@ var patternlab_engine = function (config) {
476476
let incrementalBuildsEnabled = !(deletePatternDir || graphNeedsUpgrade);
477477

478478
if (incrementalBuildsEnabled) {
479-
plutils.log.info("Incremental builds enabled.")
479+
plutils.log.info("Incremental builds enabled.");
480480
} else {
481481
// needs to be done BEFORE processing patterns
482482
fs.removeSync(paths.public.patterns);
@@ -559,7 +559,7 @@ var patternlab_engine = function (config) {
559559
// When the graph was loaded from file, some patterns might have been moved/deleted between runs
560560
// so the graph data become out of sync
561561
patternlab.graph.sync().forEach(n => {
562-
plutils.log.info("[Deleted/Moved] " + n)
562+
plutils.log.info("[Deleted/Moved] " + n);
563563
});
564564

565565
// TODO Find created or deleted files
@@ -599,8 +599,6 @@ var patternlab_engine = function (config) {
599599
return getVersion();
600600
},
601601
build: function (callback, deletePatternDir) {
602-
console.log("console log");
603-
plutils.log.info("plutils log")
604602
if (patternlab && patternlab.isBusy) {
605603
console.log('Pattern Lab is busy building a previous run - returning early.');
606604
return;

core/lib/ui_builder.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,7 @@ var ui_builder = function () {
568568
output += 'var ishControls = {"ishControlsHide":' + JSON.stringify(patternlab.config.ishControlsHide) + '};' + eol;
569569

570570
//navItems
571-
output += 'var navItems = {"patternTypes": ' + JSON.stringify(patternlab.patternTypes) + ', "ishControlsHide": ' + JSON.stringify(patternlab.config.ishControlsHide) +'};' + eol;
571+
output += 'var navItems = {"patternTypes": ' + JSON.stringify(patternlab.patternTypes) + ', "ishControlsHide": ' + JSON.stringify(patternlab.config.ishControlsHide) + '};' + eol;
572572

573573
//patternPaths
574574
output += 'var patternPaths = ' + JSON.stringify(patternlab.patternPaths) + ';' + eol;

0 commit comments

Comments
 (0)