refactor(codebase): Auto-fix simple lint issues

Author: bmuenzenmeyer

core/lib/addPattern.js

@@ -13,8 +13,8 @@ module.exports = function(pattern, patternlab) {
     '/patterns/' + pattern.patternLink;
 
   //only push to array if the array doesn't contain this pattern
-  var isNew = true;
-  for (var i = 0; i < patternlab.patterns.length; i++) {
+  let isNew = true;
+  for (let i = 0; i < patternlab.patterns.length; i++) {
     //so we need the identifier to be unique, which patterns[i].relPath is
     if (pattern.relPath === patternlab.patterns[i].relPath) {
       //if relPath already exists, overwrite that element

core/lib/buildListItems.js

@@ -4,21 +4,21 @@ const _ = require('lodash');
 
 module.exports = function(container) {
   //combine all list items into one structure
-  var list = [];
-  for (var item in container.listitems) {
+  const list = [];
+  for (const item in container.listitems) {
     if (container.listitems.hasOwnProperty(item)) {
       list.push(container.listitems[item]);
     }
   }
   container.listItemArray = _.shuffle(list);
 
-  for (var i = 1; i <= container.listItemArray.length; i++) {
-    var tempItems = [];
+  for (let i = 1; i <= container.listItemArray.length; i++) {
+    const tempItems = [];
     if (i === 1) {
       tempItems.push(container.listItemArray[0]);
       container.listitems['' + i] = tempItems;
     } else {
-      for (var c = 1; c <= i; c++) {
+      for (let c = 1; c <= i; c++) {
         tempItems.push(container.listItemArray[c - 1]);
         container.listitems['' + i] = tempItems;
       }

core/lib/expandPartials.js

@@ -31,8 +31,8 @@ module.exports = function(currentPattern, patternlab) {
       .then(() => {
         //do something with the regular old partials
         foundPatternPartials.forEach(foundPartial => {
-          var partial = currentPattern.findPartial(foundPartial);
-          var partialPattern = getPartial(partial, patternlab);
+          const partial = currentPattern.findPartial(foundPartial);
+          const partialPattern = getPartial(partial, patternlab);
 
           //recurse through nested partials to fill out this extended template.
           return processRecursive(partialPattern.relPath, patternlab)
@@ -41,7 +41,7 @@ module.exports = function(currentPattern, patternlab) {
 
               //complete assembly of extended template
               //create a copy of the partial so as to not pollute it after the getPartial call.
-              var cleanPartialPattern = jsonCopy(
+              const cleanPartialPattern = jsonCopy(
                 partialPattern,
                 `partial pattern ${partial}`
               );

core/lib/get.js

@@ -22,7 +22,7 @@ module.exports = function(partialName, patternlab) {
 
   //return the fuzzy match if all else fails
   for (var i = 0; i < patternlab.patterns.length; i++) {
-    var partialParts = partialName.split('-'),
+    let partialParts = partialName.split('-'),
       partialType = partialParts[0],
       partialNameEnd = partialParts.slice(1).join('-');
 

core/lib/loadPattern.js

@@ -22,7 +22,7 @@ let fs = require('fs-extra'); //eslint-disable-line prefer-const
 // loads a pattern from disk, creates a Pattern object from it and
 // all its associated files, and records it in patternlab.patterns[]
 module.exports = function(relPath, patternlab) {
-  var relativeDepth = (relPath.match(/\w(?=\\)|\w(?=\/)/g) || []).length;
+  const relativeDepth = (relPath.match(/\w(?=\\)|\w(?=\/)/g) || []).length;
   if (relativeDepth > 2) {
     logger.warning('');
     logger.warning('Warning:');
@@ -50,24 +50,24 @@ module.exports = function(relPath, patternlab) {
   }
 
   //check if the found file is a top-level markdown file
-  var fileObject = path.parse(relPath);
+  const fileObject = path.parse(relPath);
   if (fileObject.ext === '.md') {
     try {
-      var proposedDirectory = path.resolve(
+      const proposedDirectory = path.resolve(
         patternlab.config.paths.source.patterns,
         fileObject.dir,
         fileObject.name
       );
-      var proposedDirectoryStats = fs.statSync(proposedDirectory);
+      const proposedDirectoryStats = fs.statSync(proposedDirectory);
       if (proposedDirectoryStats.isDirectory()) {
-        var subTypeMarkdownFileContents = fs.readFileSync(
+        const subTypeMarkdownFileContents = fs.readFileSync(
           proposedDirectory + '.md',
           'utf8'
         );
-        var subTypeMarkdown = markdown_parser.parse(
+        const subTypeMarkdown = markdown_parser.parse(
           subTypeMarkdownFileContents
         );
-        var subTypePattern = new Pattern(relPath, null, patternlab);
+        const subTypePattern = new Pattern(relPath, null, patternlab);
         subTypePattern.patternSectionSubtype = true;
         subTypePattern.patternDesc = subTypeMarkdown
           ? subTypeMarkdown.markdown
@@ -91,17 +91,17 @@ module.exports = function(relPath, patternlab) {
   }
 
   //extract some information
-  var filename = fileObject.base;
-  var ext = fileObject.ext;
-  var patternsPath = patternlab.config.paths.source.patterns;
+  const filename = fileObject.base;
+  const ext = fileObject.ext;
+  const patternsPath = patternlab.config.paths.source.patterns;
 
   // skip non-pattern files
   if (!patternEngines.isPatternFile(filename, patternlab)) {
     return null;
   }
 
   //make a new Pattern Object
-  var currentPattern = new Pattern(relPath, null, patternlab);
+  const currentPattern = new Pattern(relPath, null, patternlab);
 
   //if file is named in the syntax for variants
   if (patternEngines.isPseudoPatternJSON(filename)) {
@@ -166,7 +166,7 @@ module.exports = function(relPath, patternlab) {
   readDocumentation(currentPattern, patternlab);
 
   //add the raw template to memory
-  var templatePath = path.resolve(patternsPath, currentPattern.relPath);
+  const templatePath = path.resolve(patternsPath, currentPattern.relPath);
 
   currentPattern.template = fs.readFileSync(templatePath, 'utf8');
 

core/lib/parseAllLinks.js

@@ -9,7 +9,7 @@ module.exports = function(patternlab) {
   patternlab.data = parseLink(patternlab, patternlab.data, 'data.json');
 
   //loop through all patterns
-  for (var i = 0; i < patternlab.patterns.length; i++) {
+  for (let i = 0; i < patternlab.patterns.length; i++) {
     patternlab.patterns[i].jsonFileData = parseLink(
       patternlab,
       patternlab.patterns[i].jsonFileData,

core/lib/parseLink.js

@@ -6,7 +6,7 @@ const logger = require('./log');
 const getPartial = require('./get');
 
 module.exports = function(patternlab, obj, key) {
-  var linkRE, dataObjAsString, linkMatches;
+  let linkRE, dataObjAsString, linkMatches;
 
   //check for 'link.patternPartial'
   linkRE = /(?:'|")(link\.[A-z0-9-_]+)(?:'|")/g;
@@ -21,18 +21,18 @@ module.exports = function(patternlab, obj, key) {
   linkMatches = dataObjAsString.match(linkRE);
 
   if (linkMatches) {
-    for (var i = 0; i < linkMatches.length; i++) {
-      var dataLink = linkMatches[i];
+    for (let i = 0; i < linkMatches.length; i++) {
+      const dataLink = linkMatches[i];
       if (dataLink && dataLink.split('.').length >= 2) {
         //get the partial the link refers to
-        var linkPatternPartial = dataLink
+        const linkPatternPartial = dataLink
           .split('.')[1]
           .replace('"', '')
           .replace("'", '');
-        var pattern = getPartial(linkPatternPartial, patternlab);
+        const pattern = getPartial(linkPatternPartial, patternlab);
         if (pattern !== undefined) {
           //get the full built link and replace it
-          var fullLink = patternlab.data.link[linkPatternPartial];
+          let fullLink = patternlab.data.link[linkPatternPartial];
           if (fullLink) {
             fullLink = path.normalize(fullLink).replace(/\\/g, '/');
 
@@ -54,7 +54,7 @@ module.exports = function(patternlab, obj, key) {
     }
   }
 
-  var dataObj;
+  let dataObj;
   try {
     dataObj = JSON.parse(dataObjAsString);
   } catch (err) {

core/lib/pattern_engines.js

@@ -132,7 +132,7 @@ const PatternEngines = Object.create({
    * @memberof PatternEngines
    */
   loadAllEngines: function(patternLabConfig) {
-    var self = this;
+    const self = this;
 
     // Try to load engines! We scan for engines at each path specified above. This
     // function is kind of a big deal.

core/lib/pattern_graph.js

@@ -51,7 +51,7 @@ const PatternGraph = function(graph, timestamp, version) {
 };
 
 // shorthand. Use relPath as it is always unique, even with subPatternType
-var nodeName = p => (p instanceof Pattern ? p.relPath : p);
+const nodeName = p => (p instanceof Pattern ? p.relPath : p);
 
 PatternGraph.prototype = {
   /**

core/lib/patternlab.js

@@ -402,7 +402,7 @@ module.exports = class PatternLab {
     // see if patternData really needs these other duped values
 
     // construct our extraOutput dump
-    var extraOutput = Object.assign(
+    const extraOutput = Object.assign(
       {},
       pattern.extraOutput,
       pattern.allMarkdown