Skip to content

Commit b0cb3fc

Browse files
authored
chore: add ifDefined to height / width props passed to the Logo from the Header component
1 parent c130f69 commit b0cb3fc

File tree

1 file changed

+3
-2
lines changed
  • packages/uikit-workshop/src/scripts/lit-components/pl-header

1 file changed

+3
-2
lines changed

packages/uikit-workshop/src/scripts/lit-components/pl-header/pl-header.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
/* eslint-disable no-unused-vars, no-param-reassign */
22
import { store } from '../../store.js'; // connect to redux
3+
import { ifDefined } from 'lit-html/directives/if-defined';
34
import { html } from 'lit-html';
45
import { BaseLitComponent } from '../../components/base-component';
56
import { customElement } from 'lit-element';
@@ -116,8 +117,8 @@ class Header extends BaseLitComponent {
116117
: window.config?.theme?.logo?.url || '/'}"
117118
alt-text="${window.config?.theme?.logo?.altText || ''}"
118119
theme="${this.themeMode}"
119-
width="${window.config?.theme?.logo?.width || ''}"
120-
height="${window.config?.theme?.logo?.height || ''}"
120+
width="${ifDefined(window.config?.theme?.logo?.width)}"
121+
height="${ifDefined(window.config?.theme?.logo?.height)}"
121122
text="${window.config?.theme?.logo?.text === '' ||
122123
window.config?.theme?.logo?.text === false ||
123124
window.config?.theme?.logo?.text === 'none'

0 commit comments

Comments
 (0)