Skip to content

Commit b10b157

Browse files
Merge pull request #871 from pattern-lab/fix/835-viewall
Fix/835 viewall
2 parents 023562c + 543558a commit b10b157

File tree

5 files changed

+22
-22
lines changed

5 files changed

+22
-22
lines changed

packages/core/src/lib/ui_builder.js

Lines changed: 22 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -517,9 +517,9 @@ const ui_builder = function() {
517517
* @param patternPartial - a key used to identify the viewall page
518518
* @returns A promise which resolves with the HTML
519519
*/
520-
function buildViewAllHTML(patternlab, patterns, patternPartial) {
520+
function buildViewAllHTML(patternlab, patterns, patternPartial, uikit) {
521521
return render(
522-
Pattern.createEmpty({ extendedTemplate: patternlab.viewAll }),
522+
Pattern.createEmpty({ extendedTemplate: uikit.viewAll }),
523523
{
524524
//data
525525
partials: patterns,
@@ -528,8 +528,8 @@ const ui_builder = function() {
528528
},
529529
{
530530
//templates
531-
patternSection: patternlab.patternSection,
532-
patternSectionSubtype: patternlab.patternSectionSubType,
531+
patternSection: uikit.patternSection,
532+
patternSectionSubtype: uikit.patternSectionSubType,
533533
}
534534
).catch(reason => {
535535
console.log(reason);
@@ -558,20 +558,26 @@ const ui_builder = function() {
558558
const allPatternTypePromises = _.map(
559559
styleguidePatterns.patternGroups,
560560
(patternGroup, patternType) => {
561-
let p;
562561
let typePatterns = [];
563562
let styleguideTypePatterns = [];
564563
const styleGuideExcludes =
565564
patternlab.config.styleGuideExcludes ||
566565
patternlab.config.styleguideExcludes;
567-
568566
const subTypePromises = _.map(
569567
_.values(patternGroup),
570-
(patternSubtypes, patternSubtype) => {
571-
const patternPartial = patternType + '-' + patternSubtype;
568+
(patternSubtypes, patternSubtype, originalPatternGroup) => {
569+
let p;
570+
const samplePattern = _.find(patternSubtypes, st => {
571+
return !st.patternPartial.startsWith('viewall-');
572+
});
573+
const patternName = Object.keys(
574+
_.values(originalPatternGroup)[patternSubtype]
575+
)[1];
576+
const patternPartial =
577+
patternType + '-' + samplePattern.patternSubType;
572578

573579
//do not create a viewall page for flat patterns
574-
if (patternType === patternSubtype) {
580+
if (patternType === patternName) {
575581
writeViewAllFile = false;
576582
logger.debug(
577583
`skipping ${patternType} as flat patterns do not have view all pages`
@@ -580,7 +586,7 @@ const ui_builder = function() {
580586
}
581587

582588
//render the footer needed for the viewall template
583-
return buildFooter(patternlab, 'viewall-' + patternPartial, uikit)
589+
return buildFooter(patternlab, `viewall-${patternPartial}`, uikit)
584590
.then(footerHTML => {
585591
//render the viewall template by finding these smallest subtype-grouped patterns
586592
const subtypePatterns = sortPatterns(_.values(patternSubtypes));
@@ -595,11 +601,11 @@ const ui_builder = function() {
595601
styleGuideExcludes &&
596602
styleGuideExcludes.length &&
597603
_.some(styleGuideExcludes, function(exclude) {
598-
return exclude === patternType + '/' + patternSubtype;
604+
return exclude === patternType + '/' + patternName;
599605
});
600606
if (omitPatternType) {
601607
logger.debug(
602-
`Omitting ${patternType}/${patternSubtype} from building a viewall page because its patternSubGroup is specified in styleguideExcludes.`
608+
`Omitting ${patternType}/${patternName} from building a viewall page because its patternSubGroup is specified in styleguideExcludes.`
603609
);
604610
} else {
605611
styleguideTypePatterns = styleguideTypePatterns.concat(
@@ -613,7 +619,8 @@ const ui_builder = function() {
613619
return buildViewAllHTML(
614620
patternlab,
615621
subtypePatterns,
616-
patternPartial
622+
patternPartial,
623+
uikit
617624
)
618625
.then(viewAllHTML => {
619626
return fs.outputFile(
@@ -670,7 +677,8 @@ const ui_builder = function() {
670677
return buildViewAllHTML(
671678
patternlab,
672679
typePatterns,
673-
patternType
680+
patternType,
681+
uikit
674682
)
675683
.then(viewAllHTML => {
676684
fs.outputFileSync(

packages/edition-node-gulp/dependencyGraph.json

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/edition-node-gulp/source/_patterns/atoms/global/button.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/edition-node-gulp/source/_patterns/atoms/global/button.mustache

Lines changed: 0 additions & 1 deletion
This file was deleted.

packages/edition-node-gulp/source/_patterns/atoms/global/card.mustache

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)