Skip to content

Commit cd4e7b1

Browse files
committed
Pass the sorted styleguidePatterns data structure to buildViewAllPages()
rather than overwriting patternlab's main patterns data structure with the pared down list of patterns.
1 parent 6e47793 commit cd4e7b1

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

core/lib/ui_builder.js

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -299,15 +299,15 @@ function buildViewAllHTML(patternlab, patterns, patternPartial) {
299299
return viewAllHTML;
300300
}
301301

302-
function buildViewAllPages(mainPageHeadHtml, patternlab) {
302+
function buildViewAllPages(mainPageHeadHtml, patternlab, styleguidePatterns) {
303303
var paths = patternlab.config.paths;
304304
var prevSubdir = '';
305305
var prevGroup = '';
306306
var i;
307307

308-
for (i = 0; i < patternlab.patterns.length; i++) {
308+
for (i = 0; i < styleguidePatterns.length; i++) {
309309

310-
var pattern = patternlab.patterns[i];
310+
var pattern = styleguidePatterns[i];
311311

312312
// skip underscore-prefixed files
313313
if (isPatternExcluded(pattern)) {
@@ -336,29 +336,29 @@ function buildViewAllPages(mainPageHeadHtml, patternlab) {
336336
var j;
337337

338338

339-
for (j = 0; j < patternlab.patterns.length; j++) {
339+
for (j = 0; j < styleguidePatterns.length; j++) {
340340

341341

342-
if (patternlab.patterns[j].patternGroup === pattern.patternGroup) {
342+
if (styleguidePatterns[j].patternGroup === pattern.patternGroup) {
343343
//again, skip any sibling patterns to the current one that may have underscores
344344

345-
if (isPatternExcluded(patternlab.patterns[j])) {
345+
if (isPatternExcluded(styleguidePatterns[j])) {
346346
if (patternlab.config.debug) {
347-
console.log('Omitting ' + patternlab.patterns[j].patternPartial + " from view all sibling rendering.");
347+
console.log('Omitting ' + styleguidePatterns[j].patternPartial + " from view all sibling rendering.");
348348
}
349349
continue;
350350
}
351351

352352
//this is meant to be a homepage that is not present anywhere else
353-
if (patternlab.patterns[j].patternPartial === patternlab.config.defaultPattern) {
353+
if (styleguidePatterns[j].patternPartial === patternlab.config.defaultPattern) {
354354
if (patternlab.config.debug) {
355355
console.log('Omitting ' + pattern.patternPartial + ' from view all sibling rendering because it is defined as a defaultPattern');
356356
}
357357
continue;
358358
}
359359

360360

361-
viewAllPatterns.push(patternlab.patterns[j]);
361+
viewAllPatterns.push(styleguidePatterns[j]);
362362
}
363363
}
364364

@@ -379,26 +379,26 @@ function buildViewAllPages(mainPageHeadHtml, patternlab) {
379379
viewAllPatterns = [];
380380
patternPartial = "viewall-" + pattern.patternGroup + "-" + pattern.patternSubGroup;
381381

382-
for (j = 0; j < patternlab.patterns.length; j++) {
382+
for (j = 0; j < styleguidePatterns.length; j++) {
383383

384-
if (patternlab.patterns[j].subdir === pattern.subdir) {
384+
if (styleguidePatterns[j].subdir === pattern.subdir) {
385385
//again, skip any sibling patterns to the current one that may have underscores
386-
if (isPatternExcluded(patternlab.patterns[j])) {
386+
if (isPatternExcluded(styleguidePatterns[j])) {
387387
if (patternlab.config.debug) {
388-
console.log('Omitting ' + patternlab.patterns[j].patternPartial + " from view all sibling rendering.");
388+
console.log('Omitting ' + styleguidePatterns[j].patternPartial + " from view all sibling rendering.");
389389
}
390390
continue;
391391
}
392392

393393
//this is meant to be a homepage that is not present anywhere else
394-
if (patternlab.patterns[j].patternPartial === patternlab.config.defaultPattern) {
394+
if (styleguidePatterns[j].patternPartial === patternlab.config.defaultPattern) {
395395
if (patternlab.config.debug) {
396396
console.log('Omitting ' + pattern.patternPartial + ' from view all sibling rendering because it is defined as a defaultPattern');
397397
}
398398
continue;
399399
}
400400

401-
viewAllPatterns.push(patternlab.patterns[j]);
401+
viewAllPatterns.push(styleguidePatterns[j]);
402402
}
403403

404404
}
@@ -446,7 +446,7 @@ function buildFrontEnd(patternlab) {
446446
styleguidePatterns = assembleStyleguidePatterns(patternlab);
447447

448448
//sort all patterns explicitly.
449-
patternlab.patterns = sortPatterns(styleguidePatterns);
449+
styleguidePatterns = sortPatterns(styleguidePatterns);
450450

451451
//set the pattern-specific header by compiling the general-header with data, and then adding it to the meta header
452452
var headerPartial = pattern_assembler.renderPattern(patternlab.header, {

0 commit comments

Comments
 (0)