refactor(parameter_hunter): replaceParameter helper. may still be brittle

Author: bmuenzenmeyer

core/lib/replaceParameter.js

@@ -0,0 +1,30 @@
+"use strict";
+
+const logger = require('./log');
+
+module.exports = function (template, prop, data) {
+  let t = template;
+
+  if (typeof data === 'string') {
+    return t.replace(`{{${prop}}}`, data);
+  }
+
+  if (typeof data === 'boolean') {
+    const startRE = new RegExp(`{{\\s?#[${prop}]+\\s?}}`);
+    const endRE = new RegExp(`{{\\s?/[${prop}]+\\s?}}`);
+    if (data) {
+      t = t.replace(startRE, '');
+      t = t.replace(endRE, '');
+    } else {
+      const bIdx = t.search(startRE);
+      const eIdxStart = t.search(endRE);
+      const eIdxEnd = t.indexOf('}}', eIdxStart) + 2;
+      t = t.substring(0, bIdx) + t.substring(eIdxEnd, t.length);
+    }
+    return t;
+  }
+
+  console.log(`Could not replace ${prop} with ${data} inside ${template}`);
+  logger.warning(`Could not replace ${prop} with ${data} inside ${template}`);
+  return t;
+};

test/replaceParameter_tests.js

@@ -0,0 +1,31 @@
+"use strict";
+
+const path = require('path');
+const util = require('./util/test_utils.js');
+const tap = require('tap');
+
+const replaceParameter = require('../core/lib/replaceParameter');
+
+tap.test('replaces simple value', function (test) {
+  const result = replaceParameter('{{key}}', 'key', 'value');
+  test.equals(result, 'value');
+  test.end();
+});
+
+tap.test('replaces boolean true', function (test) {
+  const result = replaceParameter('1{{#key}}value{{/key}}2', 'key', true);
+  test.equals(result, '1value2');
+  test.end();
+});
+
+tap.only('replaces boolean true with spaces', function (test) {
+  const result = replaceParameter('1{{ #key }}value{{ /key }}2', 'key', true);
+  test.equals(result, '1value2');
+  test.end();
+});
+
+tap.test('replaces boolean false', function (test) {
+  const result = replaceParameter('1{{#key}}value{{/key}}2', 'key', false);
+  test.equals(result, '12');
+  test.end();
+});