merged and covered #414

Author: bmuenzenmeyer

core/lib/patternlab.js

@@ -32,16 +32,6 @@ function buildPatternData(dataFilesPath, fs) {
 function processAllPatternsIterative(pattern_assembler, patterns_dir, patternlab) {
   diveSync(
     patterns_dir,
-    {
-      filter: function (thisPath, dir) {
-        if (dir) {
-          var remainingPath = thisPath.replace(patterns_dir, '');
-          var isValidPath = remainingPath.indexOf('/_') === -1;
-          return isValidPath;
-        }
-        return true;
-      }
-    },
     function (err, file) {
       //log any errors
       if (err) {
@@ -56,16 +46,6 @@ function processAllPatternsIterative(pattern_assembler, patterns_dir, patternlab
 function processAllPatternsRecursive(pattern_assembler, patterns_dir, patternlab) {
   diveSync(
     patterns_dir,
-    {
-      filter: function (thisPath, dir) {
-        if (dir) {
-          var remainingPath = thisPath.replace(patterns_dir, '');
-          var isValidPath = remainingPath.indexOf('/_') === -1;
-          return isValidPath;
-        }
-        return true;
-      }
-    },
     function (err, file) {
       //log any errors
       if (err) {

core/lib/ui_builder.js

@@ -113,6 +113,15 @@ var ui_builder = function () {
       return true;
     }
 
+    //this pattern is contained with a directory prefixed with an underscore (a handy way to hide whole directories from the nav
+    isOmitted = pattern.relPath.charAt(0) === '_' || pattern.relPath.indexOf('/_') > -1;
+    if (isOmitted) {
+      if (patternlab.config.debug) {
+        console.log('Omitting ' + pattern.patternPartial + ' from styleguide patterns its contained within an underscored directory.');
+      }
+      return true;
+    }
+
     //yay, let's include this on the front end
     return isOmitted;
   }

test/ui_builder_tests.js

@@ -68,6 +68,42 @@ exports['ui_builder'] = {
     test.done();
   },
 
+  'isPatternExcluded - returns true when pattern within underscored directory - top level': function (test) {
+    //arrange
+    var patternlab = createFakePatternLab({});
+    var pattern = Pattern.createEmpty({
+      relPath: '_hidden/patternsubtype/foo.mustache',
+      isPattern: true,
+      fileName : 'foo.mustache',
+      patternPartial: 'hidden-foo'
+    });
+
+    //act
+    var result = ui.isPatternExcluded(pattern, patternlab);
+
+    //assert
+    test.equals(result, true);
+    test.done();
+  },
+
+  'isPatternExcluded - returns true when pattern within underscored directory - subtype level': function (test) {
+    //arrange
+    var patternlab = createFakePatternLab({});
+    var pattern = Pattern.createEmpty({
+      relPath: 'shown/_patternsubtype/foo.mustache',
+      isPattern: true,
+      fileName : 'foo.mustache',
+      patternPartial: 'shown-foo'
+    });
+
+    //act
+    var result = ui.isPatternExcluded(pattern, patternlab);
+
+    //assert
+    test.equals(result, true);
+    test.done();
+  },
+
   'groupPatterns - creates pattern groups correctly': function (test) {
     //arrange
     var patternlab = createFakePatternLab({