reset extendedTemplate to template after retrieval

passing unit test and passing npm linked private instance of PL
closes #356

Author: bmuenzenmeyer

core/lib/list_item_hunter.js

@@ -91,6 +91,9 @@ var list_item_hunter = function () {
                 console.log(err);
               }
 
+              //if we retrieved a pattern we should make sure that its extendedTemplate is reset. looks to fix #356
+              cleanPartialPattern.extendedTemplate = cleanPartialPattern.template;
+
               //if partial has style modifier data, replace the styleModifier value
               if (foundPartials[j].indexOf(':') > -1) {
                 style_modifier_hunter.consume_style_modifier(cleanPartialPattern, foundPartials[j], patternlab);

test/list_item_hunter_tests.js

@@ -4,6 +4,8 @@
   var lih = require('../core/lib/list_item_hunter');
   var Pattern = require('../core/lib/object_factory').Pattern;
   var extend = require('util')._extend;
+  var pa = require('../core/lib/pattern_assembler');
+  var pattern_assembler = new pa();
 
   // fake pattern creators
   function createFakeListPattern(customProps) {
@@ -17,15 +19,40 @@
   }
 
   function createFakePatternLab(customProps) {
+
+    //NOTE: These listitems are faked so that pattern_assembler.combine_listitems has already clobbered them.
+
     var pl = {
       "listitems": {
         "1": [
-          { "title": "Foo" },
-          { "message" : "FooM"}
+          {
+            "title": "Foo",
+            "message": "FooM"
+          }
         ],
-        "2": [
-          { "title": "Foo" },
-          { "title": "Bar" }
+        "2" : [
+          {
+            "title": "Foo",
+            "message": "FooM"
+          },
+          {
+            "title": "Bar",
+            "message": "BarM"
+          }
+        ],
+        "3": [
+          {
+            "title": "Foo",
+            "message": "FooM"
+          },
+          {
+            "title": "Bar",
+            "message": "BarM"
+          },
+          {
+            "title": "Baz",
+            "message": "BazM"
+          },
         ]
       },
       "data": {
@@ -349,25 +376,22 @@
     'process_list_item_partials - correctly ignores already processed partial that had a style modifier when the same partial no longer has one' : function(test){
       //arrange
       var fs = require('fs-extra');
-      var pa = require('../core/lib/pattern_assembler');
-      var pattern_assembler = new pa();
       var list_item_hunter = new lih();
-      var patterns_dir = './test/files/_patterns';
 
       var pl = createFakePatternLab();
 
       var atomPattern = new Pattern('00-test/03-styled-atom.mustache');
-      atomPattern.template = fs.readFileSync(patterns_dir + '/00-test/03-styled-atom.mustache', 'utf8');
+      atomPattern.template = fs.readFileSync(pl.config.paths.source.patterns + '/00-test/03-styled-atom.mustache', 'utf8');
       atomPattern.extendedTemplate = atomPattern.template;
       atomPattern.stylePartials = pattern_assembler.find_pattern_partials_with_style_modifiers(atomPattern);
 
       var anotherStyledAtomPattern = new Pattern('00-test/12-another-styled-atom.mustache');
-      anotherStyledAtomPattern.template = fs.readFileSync(patterns_dir + '/00-test/12-another-styled-atom.mustache', 'utf8');
+      anotherStyledAtomPattern.template = fs.readFileSync(pl.config.paths.source.patterns + '/00-test/12-another-styled-atom.mustache', 'utf8');
       anotherStyledAtomPattern.extendedTemplate = anotherStyledAtomPattern.template;
       anotherStyledAtomPattern.stylePartials = pattern_assembler.find_pattern_partials_with_style_modifiers(anotherStyledAtomPattern);
 
       var listPattern = new Pattern('00-test/13-listitem.mustache');
-      listPattern.template = fs.readFileSync(patterns_dir + '/00-test/13-listitem.mustache', 'utf8');
+      listPattern.template = fs.readFileSync(pl.config.paths.source.patterns + '/00-test/13-listitem.mustache', 'utf8');
       listPattern.extendedTemplate = listPattern.template;
       listPattern.stylePartials = pattern_assembler.find_pattern_partials_with_style_modifiers(listPattern);