You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/CONTRIBUTING.md
+4-4Lines changed: 4 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -20,12 +20,12 @@ The best way to make changes to the Pattern Lab Node core and test them is throu
20
20
Guidelines
21
21
----------
22
22
23
-
-*ALWAYS* submit pull requests against the [dev branch](https://github.com/pattern-lab/patternlab-node/tree/dev). If this does not occur, I will first, try to redirect you gently, second, port over your contribution manually if time allows, and/or third, close your pull request. If you have a major feature to stabilize over time, talk to @bmuenzenmeyer via an issue about making a dedicated `feature-branch`
24
-
-Please keep your pull requests concise and limited to **ONE** substantive change at a time. This makes reviewing and testing so much easier.
23
+
-*ALWAYS* submit pull requests against the [dev branch](https://github.com/pattern-lab/patternlab-node/tree/dev). If this does not occur, I will first, try to redirect you gently, second, attempt to redirect the target branch myself, thirdly, port over your contribution manually if time allows, and/or lastly, close your pull request. If you have a major feature to stabilize over time, talk to @bmuenzenmeyer via an issue about making a dedicated `feature-branch`
24
+
-Keep your pull requests concise and limited to **ONE** substantive change at a time. This makes reviewing and testing so much easier.
25
25
- Commits should reference the issue you are adressing. For any Pull Request that you send, use the template provided.
26
26
- If you can, add some unit tests using the existing patterns in the `./test` directory
27
27
- Large enhancements should begin with opening an issue. This will result in a more systematic way for us to review your contribution and determine if a [specifcation discussion](https://github.com/pattern-lab/the-spec/issues) needs to occur.
28
-
-Please mention the issue number in commits if you can, so anyone can see to which issue your changes belong to. For instance:
28
+
-Mention the issue number in commits, so anyone can see to which issue your changes belong to. For instance:
29
29
- `#123 Fix resolving patterns in pattern_hunter`
30
30
- `Feature #42: improve improbability drive`
31
31
@@ -40,7 +40,7 @@ Two files combine within the project to define and maintain our coding style.
40
40
Tests
41
41
-----
42
42
43
-
Please add unit and integration tests if you can. It's always nice if our code coverage improves bit by bit (literally!). We are using [Node Tap](http://www.node-tap.org/) as test framework and [Rewire](https://github.com/jhnns/rewire) for mocking things like file system access.
43
+
Add unit and integration tests if you can. It's always nice if our code coverage improves bit by bit (literally!). We are using [Node Tap](http://www.node-tap.org/) as test framework and [Rewire](https://github.com/jhnns/rewire) for mocking things like file system access.
0 commit comments