Skip to content

Commit edd246b

Browse files
committed
chore(Contributions Guidelines): Simplified copy
1 parent 95f03e3 commit edd246b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ The best way to make changes to the Pattern Lab Node core and test them is throu
2020
Guidelines
2121
----------
2222

23-
- *ALWAYS* submit pull requests against the [dev branch](https://github.com/pattern-lab/patternlab-node/tree/dev). If this does not occur, I will first, try to redirect you gently, second, port over your contribution manually if time allows, and/or third, close your pull request. If you have a major feature to stabilize over time, talk to @bmuenzenmeyer via an issue about making a dedicated `feature-branch`
24-
- Please keep your pull requests concise and limited to **ONE** substantive change at a time. This makes reviewing and testing so much easier.
23+
- *ALWAYS* submit pull requests against the [dev branch](https://github.com/pattern-lab/patternlab-node/tree/dev). If this does not occur, I will first, try to redirect you gently, second, attempt to redirect the target branch myself, thirdly, port over your contribution manually if time allows, and/or lastly, close your pull request. If you have a major feature to stabilize over time, talk to @bmuenzenmeyer via an issue about making a dedicated `feature-branch`
24+
- Keep your pull requests concise and limited to **ONE** substantive change at a time. This makes reviewing and testing so much easier.
2525
- Commits should reference the issue you are adressing. For any Pull Request that you send, use the template provided.
2626
- If you can, add some unit tests using the existing patterns in the `./test` directory
2727
- Large enhancements should begin with opening an issue. This will result in a more systematic way for us to review your contribution and determine if a [specifcation discussion](https://github.com/pattern-lab/the-spec/issues) needs to occur.
28-
- Please mention the issue number in commits if you can, so anyone can see to which issue your changes belong to. For instance:
28+
- Mention the issue number in commits, so anyone can see to which issue your changes belong to. For instance:
2929
- `#123 Fix resolving patterns in pattern_hunter`
3030
- `Feature #42: improve improbability drive`
3131

@@ -40,7 +40,7 @@ Two files combine within the project to define and maintain our coding style.
4040
Tests
4141
-----
4242

43-
Please add unit and integration tests if you can. It's always nice if our code coverage improves bit by bit (literally!). We are using [Node Tap](http://www.node-tap.org/) as test framework and [Rewire](https://github.com/jhnns/rewire) for mocking things like file system access.
43+
Add unit and integration tests if you can. It's always nice if our code coverage improves bit by bit (literally!). We are using [Node Tap](http://www.node-tap.org/) as test framework and [Rewire](https://github.com/jhnns/rewire) for mocking things like file system access.
4444

4545
Branching Scheme
4646
----------------

0 commit comments

Comments
 (0)