slimming down the ignoreDir function

dmolsen · dmolsen · commit b846a28e2f65 · 2013-09-20T10:55:31.000-04:00
diff --git a/builder/lib/builder.lib.php b/builder/lib/builder.lib.php
@@ -709,15 +709,13 @@ protected function moveStaticFile($fileName,$copy = "") {
 	* @return {Boolean}      whether the directory should be ignored
 	*/
 	protected function ignoreDir($fileName) {
-		$y = false;
 		foreach($this->id as $dir) {
 			$pos = strpos($fileName,DIRECTORY_SEPARATOR.$dir.DIRECTORY_SEPARATOR);
 			if ($pos !== false) {
-				$y = true;
-				break;
+				return true;
 			}
 		}
-		return $y;
+		return false;
 	}
 	
 	/**

Original file line number	Diff line number	Diff line change
`@@ -709,15 +709,13 @@ protected function moveStaticFile($fileName,$copy = "") {`
`709`	`709`	`* @return {Boolean} whether the directory should be ignored`
`710`	`710`	`*/`
`711`	`711`	`protected function ignoreDir($fileName) {`
`712`		`- $y = false;`
`713`	`712`	`foreach($this->id as $dir) {`
`714`	`713`	`$pos = strpos($fileName,DIRECTORY_SEPARATOR.$dir.DIRECTORY_SEPARATOR);`
`715`	`714`	`if ($pos !== false) {`
`716`		`- $y = true;`
`717`		`- break;`
	`715`	`+ return true;`
`718`	`716`	`}`
`719`	`717`	`}`
`720`		`- return $y;`
	`718`	`+ return false;`
`721`	`719`	`}`
`722`	`720`
`723`	`721`	`/**`