Merge pull request #489 from AllenBW/bug/488-componet-binding-misspelling

Renames colummn to column

Author: jeff-phillips-18

src/table/tableview/examples/table-view-basic.js

@@ -42,7 +42,7 @@
           config="config"
           empty-state-config="emptyStateConfig"
           dt-options="dtOptions"
-          colummns="colummns"
+          columns="columns"
           items="items"
           action-buttons="actionButtons"
           menu-actions="menuActions">
@@ -77,7 +77,7 @@
           order: [[2, "asc"]],
         };
 
-        $scope.colummns = [
+        $scope.columns = [
           { header: "Name", itemField: "name" },
           { header: "Address", itemField: "address"},
           { header: "City", itemField: "city" },

src/table/tableview/examples/table-view-with-toolbar.js

@@ -43,7 +43,7 @@
         <pf-table-view config="tableConfig"
                        empty-state-config="emptyStateConfig"
                        dt-options="dtOptions"
-                       colummns="colummns"
+                       columns="columns"
                        items="items"
                        action-buttons="tableActionButtons"
                        menu-actions="tableMenuActions">
@@ -82,7 +82,7 @@
     function ($scope, pfViewUtils, $filter) {
       $scope.actionsText = "";
 
-      $scope.colummns = [
+      $scope.columns = [
         { header: "Name", itemField: "name" },
         { header: "Age", itemField: "age"},
         { header: "Address", itemField: "address" },

src/table/tableview/table-view.component.js

@@ -2,7 +2,8 @@ angular.module('patternfly.table').component('pfTableView', {
   bindings: {
     config: '<?',
     dtOptions: '<?',
-    colummns: '<',
+    colummns: '<?',
+    columns: '<?',
     items: '<',
     actionButtons: '<?',
     menuActions: '<?',
@@ -41,6 +42,9 @@ angular.module('patternfly.table').component('pfTableView', {
         $log.debug("$onInit");
       }
 
+      if (angular.isDefined(ctrl.colummns) && angular.isUndefined(ctrl.columns)) {
+        ctrl.columns = ctrl.colummns;
+      }
       if (angular.isUndefined(ctrl.dtOptions)) {
         ctrl.dtOptions = {};
       }
@@ -79,7 +83,7 @@ angular.module('patternfly.table').component('pfTableView', {
       // lodash-amd a-pf is using
 
       if (!validSelectionMatchProp()) {
-        angular.forEach(ctrl.colummns, function (col) {
+        angular.forEach(ctrl.columns, function (col) {
           if (props.length === 0) {
             props = col.itemField;
           } else {
@@ -88,7 +92,7 @@ angular.module('patternfly.table').component('pfTableView', {
         });
         throw new Error("pfTableView - " +
           "config.selectionMatchProp '" + ctrl.config.selectionMatchProp +
-          "' does not match any property in 'config.colummns'! Please set config.selectionMatchProp " +
+          "' does not match any property in 'config.columns'! Please set config.selectionMatchProp " +
           "to one of these properties: " + props);
       }
 
@@ -342,7 +346,7 @@ angular.module('patternfly.table').component('pfTableView', {
 
     ctrl.isColItemFld = function (key) {
       var retVal = false;
-      var tableCol = $filter('filter')(ctrl.colummns, {itemField: key});
+      var tableCol = $filter('filter')(ctrl.columns, {itemField: key});
 
       if (tableCol && tableCol.length === 1) {
         retVal = true;

src/table/tableview/table-view.html

@@ -5,7 +5,7 @@
     <thead>
       <tr role="row">
         <th class="table-view-pf-select"><input type="checkbox" value="$ctrl.selectAll" ng-model="$ctrl.selectAll" ng-change="$ctrl.toggleAll()"/></th>
-        <th ng-repeat="col in $ctrl.colummns">{{col.header}}</th>
+        <th ng-repeat="col in $ctrl.columns">{{col.header}}</th>
         <th ng-if="$ctrl.areActions()" colspan="{{$ctrl.calcActionsColspan()}}">Actions</th>
       </tr>
     </thead>

src/toolbars/examples/toolbar.js

@@ -119,7 +119,7 @@
       </div>
       <div class="col-md-12" ng-show="viewType == 'tableView'">
         <pf-table-view config="tableConfig"
-                       colummns="colummns"
+                       columns="columns"
                        items="items"
                        empty-state-config="emptyStateConfig">
         </pf-table-view>
@@ -156,7 +156,7 @@
     function ($scope, pfViewUtils, $filter) {
       $scope.filtersText = '';
 
-      $scope.colummns = [
+      $scope.columns = [
         { header: "Name", itemField: "name" },
         { header: "Age", itemField: "age"},
         { header: "Address", itemField: "address" },